From c173a9f1cce4b01fb0364c8690c6e860aa649f9d Mon Sep 17 00:00:00 2001 From: Bruno da Silva Belo Date: Fri, 27 Sep 2019 15:07:37 +0000 Subject: [PATCH] efl_ui_suite: Some pointers were being delete. `efl_ui_smart_transition_lifetime` test causes segfault when compile with `clang`. Fixes half of T8277 Reviewed-by: Marcel Hollerbach Differential Revision: https://phab.enlightenment.org/D10221 --- src/tests/elementary/efl_ui_test_spotlight.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/tests/elementary/efl_ui_test_spotlight.c b/src/tests/elementary/efl_ui_test_spotlight.c index 9749258..c093efb 100644 --- a/src/tests/elementary/efl_ui_test_spotlight.c +++ b/src/tests/elementary/efl_ui_test_spotlight.c @@ -353,11 +353,11 @@ EFL_START_TEST (efl_ui_smart_transition_lifetime) t = _create_transition(); efl_wref_add(t, &t); t1 = _create_transition(); - efl_wref_add(t1, &t1); efl_ui_spotlight_manager_set(container, t); efl_ui_spotlight_manager_set(container, t1); ck_assert_ptr_eq(t, NULL); + ck_assert_ptr_ne(t1, NULL); } EFL_END_TEST @@ -426,6 +426,7 @@ EFL_START_TEST (efl_ui_smart_indicator_calls) Efl_Ui_Spotlight_Manager*i = _create_indicator(); efl_ui_spotlight_indicator_set(container, i); _verify_indicator_calls(); + ck_assert_ptr_ne(i, NULL); } EFL_END_TEST @@ -438,6 +439,8 @@ EFL_START_TEST (efl_ui_smart_indicator_transition_calls) efl_ui_spotlight_indicator_set(container, i); efl_ui_spotlight_manager_set(container, t); _verify_indicator_calls(); + ck_assert_ptr_ne(i, NULL); + ck_assert_ptr_ne(t, NULL); } EFL_END_TEST -- 2.7.4