From c1435b08326d2273f2cb7b905b10724bf2cfe1cb Mon Sep 17 00:00:00 2001 From: "hpayer@chromium.org" Date: Mon, 14 Apr 2014 13:52:41 +0000 Subject: [PATCH] Don't run tests that rely on compaction when compaction is turned off. BUG= R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/236203010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20728 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- test/cctest/test-api.cc | 1 + test/cctest/test-heap.cc | 4 ++++ test/cctest/test-weakmaps.cc | 2 ++ test/cctest/test-weaksets.cc | 2 ++ 4 files changed, 9 insertions(+) diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc index 78ecc36..1da3cd5 100644 --- a/test/cctest/test-api.cc +++ b/test/cctest/test-api.cc @@ -14182,6 +14182,7 @@ static void event_handler(const v8::JitCodeEvent* event) { UNINITIALIZED_TEST(SetJitCodeEventHandler) { i::FLAG_stress_compaction = true; i::FLAG_incremental_marking = false; + if (i::FLAG_never_compact) return; const char* script = "function bar() {" " var sum = 0;" diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc index 1a6e632..eec5264 100644 --- a/test/cctest/test-heap.cc +++ b/test/cctest/test-heap.cc @@ -2017,6 +2017,7 @@ TEST(InstanceOfStubWriteBarrier) { TEST(PrototypeTransitionClearing) { + if (FLAG_never_compact) return; CcTest::InitializeVM(); Isolate* isolate = CcTest::i_isolate(); Factory* factory = isolate->factory(); @@ -2891,6 +2892,7 @@ TEST(Regress2143b) { TEST(ReleaseOverReservedPages) { + if (FLAG_never_compact) return; i::FLAG_trace_gc = true; // The optimizer can allocate stuff, messing up the test. i::FLAG_crankshaft = false; @@ -3554,6 +3556,7 @@ TEST(Regress169928) { TEST(Regress168801) { + if (i::FLAG_never_compact) return; i::FLAG_always_compact = true; i::FLAG_cache_optimized_code = false; i::FLAG_allow_natives_syntax = true; @@ -3610,6 +3613,7 @@ TEST(Regress168801) { TEST(Regress173458) { + if (i::FLAG_never_compact) return; i::FLAG_always_compact = true; i::FLAG_cache_optimized_code = false; i::FLAG_allow_natives_syntax = true; diff --git a/test/cctest/test-weakmaps.cc b/test/cctest/test-weakmaps.cc index 97eca86..61f6bf8 100644 --- a/test/cctest/test-weakmaps.cc +++ b/test/cctest/test-weakmaps.cc @@ -180,6 +180,7 @@ TEST(Shrinking) { // Test that weak map values on an evacuation candidate which are not reachable // by other paths are correctly recorded in the slots buffer. TEST(Regress2060a) { + if (i::FLAG_never_compact) return; FLAG_always_compact = true; LocalContext context; Isolate* isolate = GetIsolateFrom(&context); @@ -215,6 +216,7 @@ TEST(Regress2060a) { // Test that weak map keys on an evacuation candidate which are reachable by // other strong paths are correctly recorded in the slots buffer. TEST(Regress2060b) { + if (i::FLAG_never_compact) return; FLAG_always_compact = true; #ifdef VERIFY_HEAP FLAG_verify_heap = true; diff --git a/test/cctest/test-weaksets.cc b/test/cctest/test-weaksets.cc index 514b6b2..c8f3bbf 100644 --- a/test/cctest/test-weaksets.cc +++ b/test/cctest/test-weaksets.cc @@ -180,6 +180,7 @@ TEST(WeakSet_Shrinking) { // Test that weak set values on an evacuation candidate which are not reachable // by other paths are correctly recorded in the slots buffer. TEST(WeakSet_Regress2060a) { + if (i::FLAG_never_compact) return; FLAG_always_compact = true; LocalContext context; Isolate* isolate = GetIsolateFrom(&context); @@ -215,6 +216,7 @@ TEST(WeakSet_Regress2060a) { // Test that weak set keys on an evacuation candidate which are reachable by // other strong paths are correctly recorded in the slots buffer. TEST(WeakSet_Regress2060b) { + if (i::FLAG_never_compact) return; FLAG_always_compact = true; #ifdef VERIFY_HEAP FLAG_verify_heap = true; -- 2.7.4