From c10e6ec19c9aed8cef44205a41ec1c57f1dede81 Mon Sep 17 00:00:00 2001 From: Robert Hencke Date: Sun, 6 Sep 2015 09:53:22 -0400 Subject: [PATCH] Fix double-free in unit test on Windows. The LOG_SYSRESULT refers to result twice. Since, in this test, result expands to FindClose(handle), the handle was being freed twice. --- src/logging_unittest.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/logging_unittest.cc b/src/logging_unittest.cc index e180567..e0e3676 100644 --- a/src/logging_unittest.cc +++ b/src/logging_unittest.cc @@ -635,7 +635,8 @@ static void GetFiles(const string& pattern, vector* files) { do { files->push_back(dirname + data.cFileName); } while (FindNextFileA(handle, &data)); - LOG_SYSRESULT(FindClose(handle)); + BOOL result = FindClose(handle); + LOG_SYSRESULT(result); #else # error There is no way to do glob. #endif -- 2.7.4