From c0cbfe9ac7d483f30d9c784f6ab7f8a840f70ca3 Mon Sep 17 00:00:00 2001
From: Piotr Ganicz
Date: Wed, 1 Feb 2017 09:04:57 +0100
Subject: [PATCH] Style check
Change-Id: I5a42fc44148b91f076b2ce3d43527afb27b054d2
---
src/lib/tpk_archive_info.cc | 2 +-
src/tpk/step/security/step_check_tpk_background_category.cc | 2 ++
src/unit_tests/smoke_test.cc | 4 ++--
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/lib/tpk_archive_info.cc b/src/lib/tpk_archive_info.cc
index 3b5a591..14526fb 100644
--- a/src/lib/tpk_archive_info.cc
+++ b/src/lib/tpk_archive_info.cc
@@ -92,7 +92,7 @@ bool GetPrivilegesInfo(const tpk::parse::TPKConfigParser& parser,
const auto& privileges = privileges_info->GetPrivileges();
for (auto& priv : privileges) {
- // TODO: remove duplicates
+ // TODO(s89.jang): remove duplicates
info->privilege_list = g_list_append(info->privilege_list,
strdup(priv.first.c_str()));
}
diff --git a/src/tpk/step/security/step_check_tpk_background_category.cc b/src/tpk/step/security/step_check_tpk_background_category.cc
index 30a207f..bf9f5a1 100644
--- a/src/tpk/step/security/step_check_tpk_background_category.cc
+++ b/src/tpk/step/security/step_check_tpk_background_category.cc
@@ -7,7 +7,9 @@
#include
namespace {
+
namespace ci_sec = common_installer::security;
+
} // namespace
namespace tpk {
diff --git a/src/unit_tests/smoke_test.cc b/src/unit_tests/smoke_test.cc
index 15e3ac8..9715deb 100644
--- a/src/unit_tests/smoke_test.cc
+++ b/src/unit_tests/smoke_test.cc
@@ -49,8 +49,8 @@ const uid_t kDefaultUserUid = tzplatform_getuid(TZ_SYS_DEFAULT_USER);
const uid_t kTestUserId = kGlobalUserUid;
const gid_t kTestGroupId = kGlobalUserGid;
const char kSystemShareGroupName[] = "system_share";
-const std::string kTestUserIdStr = std::to_string(kTestUserId);
-const std::string kDefaultUserIdStr = std::to_string(kDefaultUserUid);
+const std::string& kTestUserIdStr = std::to_string(kTestUserId);
+const std::string& kDefaultUserIdStr = std::to_string(kDefaultUserUid);
const char kLegacyExtImageDir[] = "legacy_extimage_dir";
const char kMigrateTestDBName[] = "app2sd_migrate.db";
--
2.7.4