From c0aae343f2f7bd63d2aa057b7a82fa101fa78525 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Wed, 8 Feb 2017 17:37:48 +0900 Subject: [PATCH] Fix uninitialized value issue detected by static analysis tool Change-Id: I3bbed4db5f87bbf0a29c938fadb554d799f164a9 Signed-off-by: Jihoon Kim --- ism/modules/panelagent/ecoresocket/ecore_socket_panel_agent_module.cpp | 3 ++- ism/src/isf_message_queue.h | 3 ++- ism/src/isf_panel_agent_base.cpp | 1 + ism/src/privilege_checker.h | 1 - ism/src/scim_helper.cpp | 1 + 5 files changed, 6 insertions(+), 3 deletions(-) diff --git a/ism/modules/panelagent/ecoresocket/ecore_socket_panel_agent_module.cpp b/ism/modules/panelagent/ecoresocket/ecore_socket_panel_agent_module.cpp index 722a267..95dcd25 100644 --- a/ism/modules/panelagent/ecoresocket/ecore_socket_panel_agent_module.cpp +++ b/ism/modules/panelagent/ecoresocket/ecore_socket_panel_agent_module.cpp @@ -118,7 +118,8 @@ public: m_should_exit(false), m_socket_timeout(scim_get_default_socket_timeout()), m_should_shared_ise(false), - m_ise_exiting(false) { + m_ise_exiting(false), + m_info_manager(NULL) { m_socket_server.signal_connect_accept(slot(this, &EcoreSocketPanelAgent::socket_accept_callback)); m_socket_server.signal_connect_receive(slot(this, &EcoreSocketPanelAgent::socket_receive_callback)); m_socket_server.signal_connect_exception(slot(this, &EcoreSocketPanelAgent::socket_exception_callback)); diff --git a/ism/src/isf_message_queue.h b/ism/src/isf_message_queue.h index 96896c8..c4f27fc 100644 --- a/ism/src/isf_message_queue.h +++ b/ism/src/isf_message_queue.h @@ -398,7 +398,8 @@ protected: class MessageItemUpdateCandidateGeometry : public MessageItemHelper { public: - MessageItemUpdateCandidateGeometry() {} + MessageItemUpdateCandidateGeometry() : + m_info.pos_x(0), m_info.pos_y(0), m_info.width(0), m_info.height(0) {} virtual ~MessageItemUpdateCandidateGeometry() {} struct rectinfo& get_rectinfo_ref() { return m_info; } diff --git a/ism/src/isf_panel_agent_base.cpp b/ism/src/isf_panel_agent_base.cpp index e6743c4..4594dcf 100644 --- a/ism/src/isf_panel_agent_base.cpp +++ b/ism/src/isf_panel_agent_base.cpp @@ -62,6 +62,7 @@ namespace scim PanelAgentBase::PanelAgentBase (const String& name) :m_name (name) { + m_impl = NULL; } PanelAgentBase::~PanelAgentBase () diff --git a/ism/src/privilege_checker.h b/ism/src/privilege_checker.h index 77484f2..64d5ad7 100644 --- a/ism/src/privilege_checker.h +++ b/ism/src/privilege_checker.h @@ -12,7 +12,6 @@ public: private: char *m_client; - char *m_session; char *m_user; int m_sockfd; diff --git a/ism/src/scim_helper.cpp b/ism/src/scim_helper.cpp index bb489a7..f64f9b4 100644 --- a/ism/src/scim_helper.cpp +++ b/ism/src/scim_helper.cpp @@ -220,6 +220,7 @@ public: public: HelperAgentImpl (HelperAgent* thiz) : focused_ic ((uint32) -1), thiz (thiz), + magic(0), magic_active(0), timeout(-1), surrounding_text (NULL), selection_text (NULL), cursor_pos (0), need_update_surrounding_text (0), need_update_selection_text (0), layout (0) { -- 2.7.4