From c06a180dd574c24ca50766461c10d3a6bfa3ad2b Mon Sep 17 00:00:00 2001 From: Boyan Ding Date: Sun, 6 Jul 2014 11:44:58 +0800 Subject: [PATCH] xwm: check whether the picked seat can be NULL The seat picked in weston_wm_window_handle_moveresize can sometimes be NULL when it is (somehow) triggered with all buttons released. This patch checks whether the seat is NULL to avoid NULL dereference. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=80837 Signed-off-by: Boyan Ding --- xwayland/window-manager.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c index 6cac278..f1523f5 100644 --- a/xwayland/window-manager.c +++ b/xwayland/window-manager.c @@ -1244,8 +1244,8 @@ weston_wm_window_handle_moveresize(struct weston_wm_window *window, struct weston_shell_interface *shell_interface = &wm->server->compositor->shell_interface; - if (seat->pointer->button_count != 1 || !window->view - || seat->pointer->focus != window->view) + if (seat == NULL || seat->pointer->button_count != 1 + || !window->view || seat->pointer->focus != window->view) return; detail = client_message->data.data32[2]; -- 2.7.4