From c0144c0c64e67d78907d1da2aedeed78288ca374 Mon Sep 17 00:00:00 2001 From: jkummerow Date: Tue, 19 May 2015 04:35:02 -0700 Subject: [PATCH] Fix has_pending_exception logic in API's Array::CloneElementAt BUG=v8:4103 LOG=y R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/1138723003 Cr-Commit-Position: refs/heads/master@{#28477} --- src/api.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/api.cc b/src/api.cc index bd915ef..a688238 100644 --- a/src/api.cc +++ b/src/api.cc @@ -6078,8 +6078,9 @@ MaybeLocal Array::CloneElementAt(Local context, if (!paragon->IsJSObject()) return Local(); i::Handle paragon_handle(i::JSObject::cast(paragon)); Local result; - has_pending_exception = ToLocal( - isolate->factory()->CopyJSObject(paragon_handle), &result); + has_pending_exception = + !ToLocal(isolate->factory()->CopyJSObject(paragon_handle), + &result); RETURN_ON_FAILED_EXECUTION(Object); RETURN_ESCAPED(result); } -- 2.7.4