From bfeb3c5625713eb207db83ef7da142cb056f17a1 Mon Sep 17 00:00:00 2001 From: Jan Schmidt Date: Fri, 14 Oct 2022 06:21:41 +1100 Subject: [PATCH] adaptivedemux2/downloadhelper: Remove return val for download_request_add_buffer() The function can't actually fail, and the only caller was ignoring the result anyway, so remove the return value. Part-of: --- .../gst-plugins-good/ext/adaptivedemux2/downloadrequest.c | 10 ++++------ .../gst-plugins-good/ext/adaptivedemux2/downloadrequest.h | 2 +- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/subprojects/gst-plugins-good/ext/adaptivedemux2/downloadrequest.c b/subprojects/gst-plugins-good/ext/adaptivedemux2/downloadrequest.c index 67cbb32..a40878c 100644 --- a/subprojects/gst-plugins-good/ext/adaptivedemux2/downloadrequest.c +++ b/subprojects/gst-plugins-good/ext/adaptivedemux2/downloadrequest.c @@ -367,18 +367,18 @@ download_request_get_caps (DownloadRequest * request) return caps; } -gboolean +void download_request_add_buffer (DownloadRequest * request, GstBuffer * buffer) { DownloadRequestPrivate *priv = DOWNLOAD_REQUEST_PRIVATE (request); - g_return_val_if_fail (request != NULL, FALSE); - g_return_val_if_fail (buffer != NULL, FALSE); + g_return_if_fail (request != NULL); + g_return_if_fail (buffer != NULL); if (request->state == DOWNLOAD_REQUEST_STATE_COMPLETE) { GST_WARNING ("Download request is completed, could not add more buffers"); gst_buffer_unref (buffer); - return FALSE; + return; } GST_DEBUG ("Adding new buffer %" GST_PTR_FORMAT " to the request data", @@ -391,6 +391,4 @@ download_request_add_buffer (DownloadRequest * request, GstBuffer * buffer) priv->buffer = buffer; else priv->buffer = gst_buffer_append (priv->buffer, buffer); - - return TRUE; } diff --git a/subprojects/gst-plugins-good/ext/adaptivedemux2/downloadrequest.h b/subprojects/gst-plugins-good/ext/adaptivedemux2/downloadrequest.h index 23b666a..b814d92 100644 --- a/subprojects/gst-plugins-good/ext/adaptivedemux2/downloadrequest.h +++ b/subprojects/gst-plugins-good/ext/adaptivedemux2/downloadrequest.h @@ -83,7 +83,7 @@ void download_request_set_caps (DownloadRequest * request, GstCaps * caps); GstCaps * download_request_get_caps (DownloadRequest * request); -gboolean download_request_add_buffer (DownloadRequest *request, GstBuffer *buffer); +void download_request_add_buffer (DownloadRequest *request, GstBuffer *buffer); GstBuffer * download_request_take_buffer (DownloadRequest *request); DownloadRequest * download_request_new (void); -- 2.7.4