From bf9dada717bf0d75981aba9174c56a34cc6bedf2 Mon Sep 17 00:00:00 2001 From: "ojan@chromium.org" Date: Fri, 20 Jan 2012 23:47:02 +0000 Subject: [PATCH] run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree https://bugs.webkit.org/show_bug.cgi?id=76748 Reviewed by Ryosuke Niwa. It crawls the whole subtree and then doesn't use the data. Cutting this out saves 4 seconds warm and 17 seconds cold on my Mac Pro. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (run): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105551 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Tools/ChangeLog | 13 +++++++++++++ Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py | 6 +++--- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/Tools/ChangeLog b/Tools/ChangeLog index 9b7e1e5..2af6924 100644 --- a/Tools/ChangeLog +++ b/Tools/ChangeLog @@ -1,3 +1,16 @@ +2012-01-20 Ojan Vafai + + run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree + https://bugs.webkit.org/show_bug.cgi?id=76748 + + Reviewed by Ryosuke Niwa. + + It crawls the whole subtree and then doesn't use the data. Cutting this out + saves 4 seconds warm and 17 seconds cold on my Mac Pro. + + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + (run): + 2012-01-20 Adam Barth Another tiny tweak to the garden-o-matic CSS. This makes things line diff --git a/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py b/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py index b6068b6..484298c 100755 --- a/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py +++ b/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py @@ -64,6 +64,9 @@ def run(port, options, args, regular_output=sys.stderr, buildbot_output=sys.stdo manager = Manager(port, options, printer) manager.print_config() + if options.lint_test_files: + return manager.lint() + printer.print_update("Collecting tests ...") try: manager.collect_tests(args) @@ -72,9 +75,6 @@ def run(port, options, args, regular_output=sys.stderr, buildbot_output=sys.stdo return -1 raise - if options.lint_test_files: - return manager.lint() - printer.print_update("Checking build ...") if not port.check_build(manager.needs_servers()): _log.error("Build check failed") -- 2.7.4