From bf9054c38cb5679a6e1332a6e833ca8e1499d643 Mon Sep 17 00:00:00 2001 From: Stephen Toub Date: Thu, 25 Jul 2019 04:45:20 -0400 Subject: [PATCH] Re-enable xUnit1025 (duplicate InlineData) (dotnet/corefx#39737) Commit migrated from https://github.com/dotnet/corefx/commit/47d96f89df41ce18d3ba77b38007ec68f7f66fc6 --- src/libraries/CodeAnalysis.ruleset | 1 - .../Compression/CompressionStreamUnitTestBase.cs | 4 +- .../Common/tests/Tests/System/StringTests.cs | 8 --- .../tests/CompilerServices/VersionedTests.cs | 1 - .../tests/InformationTests.cs | 1 - .../tests/StringsTests.cs | 1 - .../System/CodeDom/CodeRegionDirectiveTests.cs | 1 - .../CodeDom/Compiler/CodeDomProviderTests.cs | 2 - .../HybridDictionary.RemoveTests.cs | 2 +- .../Generic/List/List.Generic.Tests.Reverse.cs | 1 - .../ComponentModel/CategoryAttributeTests.cs | 2 - .../System/Configuration/ValidatiorUtilsTests.cs | 2 - .../tests/DiagnosticSourceTests.cs | 8 +-- .../System.Drawing.Common/tests/BitmapTests.cs | 2 - .../System.Drawing.Common/tests/GraphicsTests.cs | 2 +- .../System.Drawing.Common/tests/PenTests.cs | 1 - .../tests/mono/System.Drawing/BitmapTests.cs | 36 ++++--------- .../tests/SizeFTests.netcoreapp.cs | 4 +- .../tests/CompressionStreamUnitTests.Deflate.cs | 4 +- .../tests/CompressionStreamUnitTests.Gzip.cs | 4 +- .../tests/FileSystemWatcher.WaitForChanged.cs | 1 - .../tests/FileInfo/Extension.cs | 1 - src/libraries/System.Memory/tests/Memory/Trim.cs | 3 +- .../HttpClientHandlerTest.Authentication.cs | 1 - .../HttpClientHandlerTest.Cancellation.cs | 4 +- .../tests/HttpListenerAuthenticationTests.cs | 1 - .../tests/HttpListenerPrefixCollectionTests.cs | 1 - .../tests/HttpListenerRequestTests.cs | 2 - .../tests/HttpListenerWebSocketTests.cs | 1 - .../tests/Functional/SmtpClientTest.cs | 1 - .../XslCompiledTransform.cs | 6 --- .../tests/Xslt/XslTransformApi/CXslTransform.cs | 8 --- .../ConstructorBuilderGetILGenerator.cs | 2 - .../MethodBuilder/MethodBuilderGetILGenerator.cs | 2 - .../MethodBuilderSetImplementationFlags.cs | 3 -- .../tests/ModuleBuilder/ModuleBuilderDefineEnum.cs | 2 - .../tests/TypeBuilder/TypeBuilderCreateType.cs | 4 -- .../tests/TypeBuilder/TypeBuilderCreateTypeInfo.cs | 4 -- .../System.Reflection/tests/TypeInfoTests.cs | 4 -- .../tests/System/EnvironmentTests.cs | 3 +- .../tests/System/IO/PathTests.netcoreapp.cs | 1 - .../System.Runtime.Extensions/tests/System/Math.cs | 2 + .../tests/System/MathF.netcoreapp.cs | 2 + .../tests/System/MathTests.netcoreapp.cs | 2 + .../Marshal/GetObjectForNativeVariantTests.cs | 7 +-- .../Marshal/StringToCoTaskMemUTF8Tests.cs | 1 - .../System.Runtime/tests/System/ByteTests.cs | 1 - .../System.Runtime/tests/System/DateTimeTests.cs | 1 - .../System.Runtime/tests/System/DecimalTests.cs | 1 - .../System.Runtime/tests/System/DoubleTests.cs | 4 +- .../tests/System/DoubleTests.netcoreapp.cs | 3 +- .../System.Runtime/tests/System/SingleTests.cs | 3 +- .../tests/System/SingleTests.netcoreapp.cs | 3 +- .../tests/System/Text/RuneTests.netcoreapp.cs | 1 - .../Utf16UtilityTests.ValidateChars.netcoreapp.cs | 1 - .../System.Runtime/tests/System/UInt16Tests.cs | 1 - .../System.Runtime/tests/System/UInt32Tests.cs | 1 - .../System.Runtime/tests/System/UInt64Tests.cs | 1 - .../tests/Signature_ArbitraryElements.cs | 2 - .../UTF7Encoding/UTF7EncodingGetMaxByteCount.cs | 1 - .../tests/JsonElementWriteTests.cs | 2 +- .../tests/RegexParserTests.cs | 60 ---------------------- .../tests/NonMsdtcPromoterTests.cs | 2 - 63 files changed, 46 insertions(+), 198 deletions(-) diff --git a/src/libraries/CodeAnalysis.ruleset b/src/libraries/CodeAnalysis.ruleset index efd527f..e2f8929 100644 --- a/src/libraries/CodeAnalysis.ruleset +++ b/src/libraries/CodeAnalysis.ruleset @@ -80,7 +80,6 @@ - diff --git a/src/libraries/Common/tests/System/IO/Compression/CompressionStreamUnitTestBase.cs b/src/libraries/Common/tests/System/IO/Compression/CompressionStreamUnitTestBase.cs index c8af957..cfec5a1 100644 --- a/src/libraries/Common/tests/System/IO/Compression/CompressionStreamUnitTestBase.cs +++ b/src/libraries/Common/tests/System/IO/Compression/CompressionStreamUnitTestBase.cs @@ -565,7 +565,7 @@ namespace System.IO.Compression } [Theory] - [InlineData(true)] + [InlineData(false)] [InlineData(true)] public virtual void Write_ArgumentValidation(bool useAsync) { @@ -586,7 +586,7 @@ namespace System.IO.Compression } [Theory] - [InlineData(true)] + [InlineData(false)] [InlineData(true)] public virtual void Read_ArgumentValidation(bool useAsync) { diff --git a/src/libraries/Common/tests/Tests/System/StringTests.cs b/src/libraries/Common/tests/Tests/System/StringTests.cs index 74e5d8f..2cdeb26 100644 --- a/src/libraries/Common/tests/Tests/System/StringTests.cs +++ b/src/libraries/Common/tests/Tests/System/StringTests.cs @@ -549,9 +549,7 @@ namespace System.Tests [InlineData("HELLO", 2, "hello", 2, 3, StringComparison.Ordinal, -1)] [InlineData("Hello", 2, "Goodbye", 2, 3, StringComparison.Ordinal, -1)] [InlineData("Hello", 0, "Hello", 0, 0, StringComparison.Ordinal, 0)] - [InlineData("Hello", 0, "Hello", 0, 5, StringComparison.Ordinal, 0)] [InlineData("Hello", 0, "Hello", 0, 3, StringComparison.Ordinal, 0)] - [InlineData("Hello", 2, "Hello", 2, 3, StringComparison.Ordinal, 0)] [InlineData("Hello", 0, "He" + SoftHyphen + "llo", 0, 5, StringComparison.Ordinal, -1)] [InlineData("Hello", 0, "-==-", 3, 5, StringComparison.Ordinal, 0)] [InlineData("\uD83D\uDD53Hello\uD83D\uDD50", 1, "\uD83D\uDD53Hello\uD83D\uDD54", 1, 7, StringComparison.Ordinal, 0)] // Surrogate split @@ -2642,8 +2640,6 @@ namespace System.Tests [InlineData("Hello", 'l', 3, 0, -1)] [InlineData("Hello", 'l', 0, 2, -1)] [InlineData("Hello", 'l', 0, 3, 2)] - [InlineData("Hello", 'l', 4, 1, -1)] - [InlineData("Hello", 'x', 1, 4, -1)] [InlineData("Hello", 'o', 5, 0, -1)] [InlineData("H" + SoftHyphen + "ello", 'e', 0, 3, 2)] // For some reason, this is failing on *nix with ordinal comparisons. @@ -3841,13 +3837,9 @@ namespace System.Tests [InlineData("Hello", 'l', 1, 2, -1)] [InlineData("Hello", 'l', 0, 1, -1)] [InlineData("Hello", 'x', 3, 4, -1)] - [InlineData("Hello", 'l', 3, 4, 3)] - [InlineData("Hello", 'l', 1, 2, -1)] [InlineData("Hello", 'l', 1, 0, -1)] [InlineData("Hello", 'l', 4, 2, 3)] [InlineData("Hello", 'l', 4, 3, 3)] - [InlineData("Hello", 'l', 0, 1, -1)] - [InlineData("Hello", 'x', 3, 4, -1)] [InlineData("H" + SoftHyphen + "ello", 'H', 2, 3, 0)] [InlineData("", 'H', 0, 0, -1)] public static void LastIndexOf_SingleLetter(string s, char value, int startIndex, int count, int expected) diff --git a/src/libraries/Microsoft.VisualBasic.Core/tests/CompilerServices/VersionedTests.cs b/src/libraries/Microsoft.VisualBasic.Core/tests/CompilerServices/VersionedTests.cs index 96a2c5a..ac82578 100644 --- a/src/libraries/Microsoft.VisualBasic.Core/tests/CompilerServices/VersionedTests.cs +++ b/src/libraries/Microsoft.VisualBasic.Core/tests/CompilerServices/VersionedTests.cs @@ -82,7 +82,6 @@ namespace Microsoft.VisualBasic.Tests [InlineData("12x", false)] [InlineData("123", true)] [InlineData('1', true)] - [InlineData('a', false)] [InlineData("&O123", true)] [InlineData("&H123", true)] public void IsNumeric(object value, bool expected) diff --git a/src/libraries/Microsoft.VisualBasic.Core/tests/InformationTests.cs b/src/libraries/Microsoft.VisualBasic.Core/tests/InformationTests.cs index 74eca86..9d4047d 100644 --- a/src/libraries/Microsoft.VisualBasic.Core/tests/InformationTests.cs +++ b/src/libraries/Microsoft.VisualBasic.Core/tests/InformationTests.cs @@ -150,7 +150,6 @@ namespace Microsoft.VisualBasic.Tests [InlineData("12x", false)] [InlineData("123", true)] [InlineData('1', true)] - [InlineData('a', false)] [InlineData("&O123", true)] [InlineData("&H123", true)] public void IsNumeric(object value, bool expected) diff --git a/src/libraries/Microsoft.VisualBasic.Core/tests/StringsTests.cs b/src/libraries/Microsoft.VisualBasic.Core/tests/StringsTests.cs index 88e04cb..9606845 100644 --- a/src/libraries/Microsoft.VisualBasic.Core/tests/StringsTests.cs +++ b/src/libraries/Microsoft.VisualBasic.Core/tests/StringsTests.cs @@ -832,7 +832,6 @@ namespace Microsoft.VisualBasic.Tests [InlineData("", "", -1, CompareMethod.Text, new string[] { "" })] [InlineData("ABC", ",", -1, CompareMethod.Text, new string[] { "ABC" })] [InlineData("A,,BC", ",", -1, CompareMethod.Text, new string[] { "A", "", "BC" })] - [InlineData("A,,BC", ",", -1, CompareMethod.Text, new string[] { "A", "", "BC" })] [InlineData("ABC", "b", -1, CompareMethod.Text, new string[] { "A", "C" })] [InlineData("ABC", "b", -1, CompareMethod.Binary, new string[] { "ABC" })] [InlineData("A, B, C", ", ", -1, CompareMethod.Text, new string[] { "A", "B", "C" })] diff --git a/src/libraries/System.CodeDom/tests/System/CodeDom/CodeRegionDirectiveTests.cs b/src/libraries/System.CodeDom/tests/System/CodeDom/CodeRegionDirectiveTests.cs index 2602db0..b4b9560 100644 --- a/src/libraries/System.CodeDom/tests/System/CodeDom/CodeRegionDirectiveTests.cs +++ b/src/libraries/System.CodeDom/tests/System/CodeDom/CodeRegionDirectiveTests.cs @@ -46,7 +46,6 @@ namespace System.CodeDom.Tests [InlineData(CodeRegionMode.None - 1)] [InlineData(CodeRegionMode.None)] [InlineData(CodeRegionMode.Start | CodeRegionMode.End)] - [InlineData(CodeRegionMode.End + 1)] public void Value_Set_Get_ReturnsExpected(CodeRegionMode value) { var region = new CodeRegionDirective(); diff --git a/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CodeDomProviderTests.cs b/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CodeDomProviderTests.cs index 103fbaf..b8aa777 100644 --- a/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CodeDomProviderTests.cs +++ b/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CodeDomProviderTests.cs @@ -164,7 +164,6 @@ namespace System.CodeDom.Compiler.Tests [InlineData(" cs ", "c#")] [InlineData(".cs", "c#")] [InlineData("Cs", "c#")] - [InlineData("cs", "c#")] [InlineData("vb", "vb")] [InlineData(".vb", "vb")] [InlineData("VB", "vb")] @@ -193,7 +192,6 @@ namespace System.CodeDom.Compiler.Tests [InlineData("cs", true)] [InlineData(".cs", true)] [InlineData("Cs", true)] - [InlineData("cs", true)] [InlineData("vb", true)] [InlineData(".vb", true)] [InlineData("VB", true)] diff --git a/src/libraries/System.Collections.Specialized/tests/HybridDictionary/HybridDictionary.RemoveTests.cs b/src/libraries/System.Collections.Specialized/tests/HybridDictionary/HybridDictionary.RemoveTests.cs index da03bcf..0fa9fc5 100644 --- a/src/libraries/System.Collections.Specialized/tests/HybridDictionary/HybridDictionary.RemoveTests.cs +++ b/src/libraries/System.Collections.Specialized/tests/HybridDictionary/HybridDictionary.RemoveTests.cs @@ -11,7 +11,7 @@ namespace System.Collections.Specialized.Tests [Theory] [InlineData(0, true)] [InlineData(0, false)] - [InlineData(0, true)] + [InlineData(5, true)] [InlineData(5, false)] [InlineData(50, true)] [InlineData(50, false)] diff --git a/src/libraries/System.Collections/tests/Generic/List/List.Generic.Tests.Reverse.cs b/src/libraries/System.Collections/tests/Generic/List/List.Generic.Tests.Reverse.cs index 947bb19..8d5e1a1 100644 --- a/src/libraries/System.Collections/tests/Generic/List/List.Generic.Tests.Reverse.cs +++ b/src/libraries/System.Collections/tests/Generic/List/List.Generic.Tests.Reverse.cs @@ -31,7 +31,6 @@ namespace System.Collections.Tests [Theory] [InlineData(10, 0, 10)] [InlineData(10, 3, 3)] - [InlineData(10, 0, 10)] [InlineData(10, 10, 0)] [InlineData(10, 5, 5)] [InlineData(10, 0, 5)] diff --git a/src/libraries/System.ComponentModel.Primitives/tests/System/ComponentModel/CategoryAttributeTests.cs b/src/libraries/System.ComponentModel.Primitives/tests/System/ComponentModel/CategoryAttributeTests.cs index 2759e8d..f98f44a 100644 --- a/src/libraries/System.ComponentModel.Primitives/tests/System/ComponentModel/CategoryAttributeTests.cs +++ b/src/libraries/System.ComponentModel.Primitives/tests/System/ComponentModel/CategoryAttributeTests.cs @@ -109,13 +109,11 @@ namespace System.ComponentModel.Tests [InlineData("Font")] [InlineData("Format")] [InlineData("Key")] - [InlineData("Format")] [InlineData("Layout")] [InlineData("List")] [InlineData("Mouse")] [InlineData("Position")] [InlineData("Scale")] - [InlineData("Position")] [InlineData("Text")] [InlineData("WindowStyle")] public void GetLocalizedString_InvokeValueExists_ReturnsNonEmpty(string value) diff --git a/src/libraries/System.Configuration.ConfigurationManager/tests/System/Configuration/ValidatiorUtilsTests.cs b/src/libraries/System.Configuration.ConfigurationManager/tests/System/Configuration/ValidatiorUtilsTests.cs index 0aee3fe..7889bd1 100644 --- a/src/libraries/System.Configuration.ConfigurationManager/tests/System/Configuration/ValidatiorUtilsTests.cs +++ b/src/libraries/System.Configuration.ConfigurationManager/tests/System/Configuration/ValidatiorUtilsTests.cs @@ -40,11 +40,9 @@ namespace System.ConfigurationTests // Exclusive out of range InlineData(2, 1, 1, 1, true, false, null), InlineData(3, 1, 2, 1, true, false, null), - InlineData(3, 1, 2, 1, true, false, null), // Not exclusive out of range InlineData(2, 1, 1, 1, false, true, "Validation_scalar_range_violation_not_equal"), InlineData(3, 1, 2, 1, false, true, "Validation_scalar_range_violation_not_in_range"), - InlineData(3, 1, 2, 1, false, true, "Validation_scalar_range_violation_not_in_range") ] public void ValidateIntScalar(int value, int min, int max, int resolution, bool exclusiveRange, bool shouldThrow, string message) { diff --git a/src/libraries/System.Diagnostics.DiagnosticSource/tests/DiagnosticSourceTests.cs b/src/libraries/System.Diagnostics.DiagnosticSource/tests/DiagnosticSourceTests.cs index 8be5cc9..fd8eeb1 100644 --- a/src/libraries/System.Diagnostics.DiagnosticSource/tests/DiagnosticSourceTests.cs +++ b/src/libraries/System.Diagnostics.DiagnosticSource/tests/DiagnosticSourceTests.cs @@ -503,10 +503,10 @@ namespace System.Diagnostics.Tests [OuterLoop] [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNotArm64Process))] // [ActiveIssue(35539)] [InlineData(100, 100)] // run multiple times to stress it further - [InlineData(100, 100)] - [InlineData(100, 100)] - [InlineData(100, 100)] - [InlineData(100, 100)] + [InlineData(100, 101)] + [InlineData(100, 102)] + [InlineData(100, 103)] + [InlineData(100, 104)] public void AllSubscriberStress(int numThreads, int numListenersPerThread) { // No listeners have been created yet diff --git a/src/libraries/System.Drawing.Common/tests/BitmapTests.cs b/src/libraries/System.Drawing.Common/tests/BitmapTests.cs index bc0d05b..43dd421 100644 --- a/src/libraries/System.Drawing.Common/tests/BitmapTests.cs +++ b/src/libraries/System.Drawing.Common/tests/BitmapTests.cs @@ -271,7 +271,6 @@ namespace System.Drawing.Tests [InlineData(PixelFormat.Undefined - 1)] [InlineData(PixelFormat.Undefined)] [InlineData(PixelFormat.Gdi - 1)] - [InlineData(PixelFormat.DontCare)] [InlineData(PixelFormat.Max)] [InlineData(PixelFormat.Indexed)] [InlineData(PixelFormat.Gdi)] @@ -479,7 +478,6 @@ namespace System.Drawing.Tests [ConditionalTheory(Helpers.IsDrawingSupported)] [InlineData(0, 0, 4, 1)] [InlineData(0, 0, 1, 4)] - [InlineData(0, 0, 1, 4)] [InlineData(1, 0, 3, 1)] [InlineData(0, 1, 1, 3)] [InlineData(4, 1, 1, 1)] diff --git a/src/libraries/System.Drawing.Common/tests/GraphicsTests.cs b/src/libraries/System.Drawing.Common/tests/GraphicsTests.cs index 26fed28..79d81e9 100644 --- a/src/libraries/System.Drawing.Common/tests/GraphicsTests.cs +++ b/src/libraries/System.Drawing.Common/tests/GraphicsTests.cs @@ -632,7 +632,7 @@ namespace System.Drawing.Tests [InlineData(FlushIntention.Flush)] [InlineData(FlushIntention.Sync)] [InlineData(FlushIntention.Flush - 1)] // Not in the range of valid values of FlushIntention. - [InlineData(FlushIntention.Sync - 1)] // Not in the range of valid values of FlushIntention. + [InlineData(FlushIntention.Sync + 1)] // Not in the range of valid values of FlushIntention. public void Flush_MultipleTimes_Success(FlushIntention intention) { using (var image = new Bitmap(10, 10)) diff --git a/src/libraries/System.Drawing.Common/tests/PenTests.cs b/src/libraries/System.Drawing.Common/tests/PenTests.cs index 48e0273..80e0898 100644 --- a/src/libraries/System.Drawing.Common/tests/PenTests.cs +++ b/src/libraries/System.Drawing.Common/tests/PenTests.cs @@ -115,7 +115,6 @@ namespace System.Drawing.Tests [InlineData(float.NegativeInfinity)] [InlineData(float.PositiveInfinity)] [InlineData(float.NaN)] - [InlineData(float.PositiveInfinity)] public void Ctor_Color_Width(float width) { using (var pen = new Pen(Color.Red, width)) diff --git a/src/libraries/System.Drawing.Common/tests/mono/System.Drawing/BitmapTests.cs b/src/libraries/System.Drawing.Common/tests/mono/System.Drawing/BitmapTests.cs index a7f989d..701fb50 100644 --- a/src/libraries/System.Drawing.Common/tests/mono/System.Drawing/BitmapTests.cs +++ b/src/libraries/System.Drawing.Common/tests/mono/System.Drawing/BitmapTests.cs @@ -508,38 +508,22 @@ namespace MonoTests.System.Drawing // Rotate 1- and 4-bit bitmaps in different ways and check the // resulting pixels using MD5 [ConditionalTheory(Helpers.IsDrawingSupported)] - [InlineData("1bit.png", RotateFlipType.RotateNoneFlipNone, "A4DAF507C92BDE10626BC7B34FEFE5")] - [InlineData("1bit.png", RotateFlipType.Rotate180FlipXY, "A4DAF507C92BDE10626BC7B34FEFE5")] - [InlineData("1bit.png", RotateFlipType.Rotate90FlipNone, "C0975EAFD2FC1CC9CC7AF20B92FC9F")] - [InlineData("1bit.png", RotateFlipType.Rotate270FlipXY, "C0975EAFD2FC1CC9CC7AF20B92FC9F")] [InlineData("1bit.png", RotateFlipType.Rotate180FlipNone, "64AE60858A02228F7B1B18C7812FB6")] - [InlineData("1bit.png", RotateFlipType.RotateNoneFlipXY, "64AE60858A02228F7B1B18C7812FB6")] - [InlineData("1bit.png", RotateFlipType.Rotate270FlipNone, "E96D3390938350F9DE2608C4364424")] - [InlineData("1bit.png", RotateFlipType.Rotate90FlipXY, "E96D3390938350F9DE2608C4364424")] - [InlineData("1bit.png", RotateFlipType.RotateNoneFlipX, "23947CE822C1DDE6BEA69C01F8D0D9")] - [InlineData("1bit.png", RotateFlipType.Rotate180FlipY, "23947CE822C1DDE6BEA69C01F8D0D9")] - [InlineData("1bit.png", RotateFlipType.Rotate90FlipX, "BE45F685BDEBD7079AA1B2CBA46723")] - [InlineData("1bit.png", RotateFlipType.Rotate270FlipY, "BE45F685BDEBD7079AA1B2CBA46723")] [InlineData("1bit.png", RotateFlipType.Rotate180FlipX, "353E937CFF31B1BF6C3DD0A031ACB5")] - [InlineData("1bit.png", RotateFlipType.RotateNoneFlipY, "353E937CFF31B1BF6C3DD0A031ACB5")] + [InlineData("1bit.png", RotateFlipType.Rotate180FlipXY, "A4DAF507C92BDE10626BC7B34FEFE5")] + [InlineData("1bit.png", RotateFlipType.Rotate180FlipY, "23947CE822C1DDE6BEA69C01F8D0D9")] + [InlineData("1bit.png", RotateFlipType.Rotate270FlipNone, "E96D3390938350F9DE2608C4364424")] [InlineData("1bit.png", RotateFlipType.Rotate270FlipX, "AEA18A770A845E25B6A8CE28DD6DCB")] - [InlineData("1bit.png", RotateFlipType.Rotate90FlipY, "AEA18A770A845E25B6A8CE28DD6DCB")] - [InlineData("4bit.png", RotateFlipType.RotateNoneFlipNone, "3CC874B571902366AACED5D619E87D")] - [InlineData("4bit.png", RotateFlipType.Rotate180FlipXY, "3CC874B571902366AACED5D619E87D")] - [InlineData("4bit.png", RotateFlipType.Rotate90FlipNone, "8DE25C7E1BE4A3B535DB5D83198D83")] - [InlineData("4bit.png", RotateFlipType.Rotate270FlipXY, "8DE25C7E1BE4A3B535DB5D83198D83")] + [InlineData("1bit.png", RotateFlipType.Rotate270FlipXY, "C0975EAFD2FC1CC9CC7AF20B92FC9F")] + [InlineData("1bit.png", RotateFlipType.Rotate270FlipY, "BE45F685BDEBD7079AA1B2CBA46723")] [InlineData("4bit.png", RotateFlipType.Rotate180FlipNone, "27CF5E9CE70BE9EBC47FB996721B95")] - [InlineData("4bit.png", RotateFlipType.RotateNoneFlipXY, "27CF5E9CE70BE9EBC47FB996721B95")] - [InlineData("4bit.png", RotateFlipType.Rotate270FlipNone, "A919CCB8F97CAD7DC1F01026D11A5D")] - [InlineData("4bit.png", RotateFlipType.Rotate90FlipXY, "A919CCB8F97CAD7DC1F01026D11A5D")] - [InlineData("4bit.png", RotateFlipType.RotateNoneFlipX, "545876C99ACF833E69FBFFBF436034")] - [InlineData("4bit.png", RotateFlipType.Rotate180FlipY, "545876C99ACF833E69FBFFBF436034")] - [InlineData("4bit.png", RotateFlipType.Rotate90FlipX, "5DB56687757CDEFC52D89C77CA9223")] - [InlineData("4bit.png", RotateFlipType.Rotate270FlipY, "5DB56687757CDEFC52D89C77CA9223")] [InlineData("4bit.png", RotateFlipType.Rotate180FlipX, "05A77EDDCDF20D5B0AC0169E95D7D7")] - [InlineData("4bit.png", RotateFlipType.RotateNoneFlipY, "05A77EDDCDF20D5B0AC0169E95D7D7")] + [InlineData("4bit.png", RotateFlipType.Rotate180FlipXY, "3CC874B571902366AACED5D619E87D")] + [InlineData("4bit.png", RotateFlipType.Rotate180FlipY, "545876C99ACF833E69FBFFBF436034")] + [InlineData("4bit.png", RotateFlipType.Rotate270FlipNone, "A919CCB8F97CAD7DC1F01026D11A5D")] [InlineData("4bit.png", RotateFlipType.Rotate270FlipX, "B6B6245796C836923ABAABDF368B29")] - [InlineData("4bit.png", RotateFlipType.Rotate90FlipY, "B6B6245796C836923ABAABDF368B29")] + [InlineData("4bit.png", RotateFlipType.Rotate270FlipXY, "8DE25C7E1BE4A3B535DB5D83198D83")] + [InlineData("4bit.png", RotateFlipType.Rotate270FlipY, "5DB56687757CDEFC52D89C77CA9223")] [PlatformSpecific(TestPlatforms.AnyUnix)] public void Rotate1bit4bit(string file, RotateFlipType type, string md5) { diff --git a/src/libraries/System.Drawing.Primitives/tests/SizeFTests.netcoreapp.cs b/src/libraries/System.Drawing.Primitives/tests/SizeFTests.netcoreapp.cs index c93704f..f6a4209 100644 --- a/src/libraries/System.Drawing.Primitives/tests/SizeFTests.netcoreapp.cs +++ b/src/libraries/System.Drawing.Primitives/tests/SizeFTests.netcoreapp.cs @@ -71,9 +71,9 @@ namespace System.Drawing.PrimitivesTest [InlineData(float.MinValue, -1.0f)] [InlineData(float.MinValue, 0.0f)] [InlineData(1.0f, float.MinValue)] - [InlineData(1.0f, float.MinValue)] - [InlineData(-1.0f, float.MinValue)] + [InlineData(1.0f, float.MaxValue)] [InlineData(-1.0f, float.MinValue)] + [InlineData(-1.0f, float.MaxValue)] public void DivideTestSizeFloat(float dimension, float divisor) { SizeF size = new SizeF(dimension, dimension); diff --git a/src/libraries/System.IO.Compression/tests/CompressionStreamUnitTests.Deflate.cs b/src/libraries/System.IO.Compression/tests/CompressionStreamUnitTests.Deflate.cs index 03f6371..5e90afd 100644 --- a/src/libraries/System.IO.Compression/tests/CompressionStreamUnitTests.Deflate.cs +++ b/src/libraries/System.IO.Compression/tests/CompressionStreamUnitTests.Deflate.cs @@ -81,7 +81,7 @@ namespace System.IO.Compression [InlineData(false, false)] [InlineData(false, true)] [InlineData(true, false)] - [InlineData(true, false)] + [InlineData(true, true)] public async Task DisposeAsync_Flushes(bool derived, bool leaveOpen) { var ms = new MemoryStream(); @@ -106,7 +106,7 @@ namespace System.IO.Compression [InlineData(false, false)] [InlineData(false, true)] [InlineData(true, false)] - [InlineData(true, false)] + [InlineData(true, true)] public async Task DisposeAsync_MultipleCallsAllowed(bool derived, bool leaveOpen) { using (var ds = derived ? diff --git a/src/libraries/System.IO.Compression/tests/CompressionStreamUnitTests.Gzip.cs b/src/libraries/System.IO.Compression/tests/CompressionStreamUnitTests.Gzip.cs index a95d14d..ed04e16 100644 --- a/src/libraries/System.IO.Compression/tests/CompressionStreamUnitTests.Gzip.cs +++ b/src/libraries/System.IO.Compression/tests/CompressionStreamUnitTests.Gzip.cs @@ -197,7 +197,7 @@ namespace System.IO.Compression [InlineData(false, false)] [InlineData(false, true)] [InlineData(true, false)] - [InlineData(true, false)] + [InlineData(true, true)] public async Task DisposeAsync_Flushes(bool derived, bool leaveOpen) { var ms = new MemoryStream(); @@ -227,7 +227,7 @@ namespace System.IO.Compression [InlineData(false, false)] [InlineData(false, true)] [InlineData(true, false)] - [InlineData(true, false)] + [InlineData(true, true)] public async Task DisposeAsync_MultipleCallsAllowed(bool derived, bool leaveOpen) { using (var gs = derived ? diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.WaitForChanged.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.WaitForChanged.cs index 5899007..6e7a0d9 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.WaitForChanged.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.WaitForChanged.cs @@ -32,7 +32,6 @@ namespace System.IO.Tests [InlineData((WatcherChangeTypes)0)] [InlineData((WatcherChangeTypes)int.MinValue)] [InlineData((WatcherChangeTypes)int.MaxValue)] - [InlineData((WatcherChangeTypes)int.MaxValue)] public static void WaitForChangedResult_ChangeType_Roundtrip(WatcherChangeTypes changeType) { var result = new WaitForChangedResult(); diff --git a/src/libraries/System.IO.FileSystem/tests/FileInfo/Extension.cs b/src/libraries/System.IO.FileSystem/tests/FileInfo/Extension.cs index 5137924..f9897cf 100644 --- a/src/libraries/System.IO.FileSystem/tests/FileInfo/Extension.cs +++ b/src/libraries/System.IO.FileSystem/tests/FileInfo/Extension.cs @@ -13,7 +13,6 @@ namespace System.IO.Tests [InlineData("filename", "")] [InlineData("foo.bar.fkl;fkds92-509450-4359.$#%()#%().%#(%)_#(%_)", ".cool")] [InlineData("filename", ".$#@$_)+_)!@@!!@##&_$)#_")] - [InlineData("filename", ".$#@$_)+_)!@@!!@##&_$)#_")] public void ValidExtensions(string fileName, string extension) { string path = Path.Combine(TestDirectory, fileName + extension); diff --git a/src/libraries/System.Memory/tests/Memory/Trim.cs b/src/libraries/System.Memory/tests/Memory/Trim.cs index 537e154..b45323a 100644 --- a/src/libraries/System.Memory/tests/Memory/Trim.cs +++ b/src/libraries/System.Memory/tests/Memory/Trim.cs @@ -2,10 +2,11 @@ // The .NET Foundation licenses this file to you under the MIT license. // See the LICENSE file in the project root for more information. -using System; using System.Collections.Generic; using Xunit; +#pragma warning disable xUnit1025 // analyzer is flagging unique InlineDatas as duplicates + namespace System.MemoryTests { public static partial class MemoryTests diff --git a/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Authentication.cs b/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Authentication.cs index 433d966..f296a2e 100644 --- a/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Authentication.cs +++ b/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Authentication.cs @@ -285,7 +285,6 @@ namespace System.Net.Http.Functional.Tests [InlineData((HttpStatusCode)208)] // AlreadyReported [InlineData((HttpStatusCode)226)] // IMUsed [InlineData(HttpStatusCode.Ambiguous)] - [InlineData(HttpStatusCode.Ambiguous)] [InlineData(HttpStatusCode.NotModified)] [InlineData(HttpStatusCode.UseProxy)] [InlineData(HttpStatusCode.Unused)] diff --git a/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Cancellation.cs b/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Cancellation.cs index 701dd39..9213839 100644 --- a/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Cancellation.cs +++ b/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Cancellation.cs @@ -226,8 +226,8 @@ namespace System.Net.Http.Functional.Tests [Theory] [InlineData(CancellationMode.CancelPendingRequests, false)] - [InlineData(CancellationMode.DisposeHttpClient, true)] - [InlineData(CancellationMode.CancelPendingRequests, false)] + [InlineData(CancellationMode.DisposeHttpClient, false)] + [InlineData(CancellationMode.CancelPendingRequests, true)] [InlineData(CancellationMode.DisposeHttpClient, true)] public async Task GetAsync_CancelPendingRequests_DoesntCancelReadAsyncOnResponseStream(CancellationMode mode, bool copyToAsync) { diff --git a/src/libraries/System.Net.HttpListener/tests/HttpListenerAuthenticationTests.cs b/src/libraries/System.Net.HttpListener/tests/HttpListenerAuthenticationTests.cs index 4e07a46..9601fc7 100644 --- a/src/libraries/System.Net.HttpListener/tests/HttpListenerAuthenticationTests.cs +++ b/src/libraries/System.Net.HttpListener/tests/HttpListenerAuthenticationTests.cs @@ -67,7 +67,6 @@ namespace System.Net.Tests [Theory] [InlineData(AuthenticationSchemes.Basic)] - [InlineData(AuthenticationSchemes.Basic | AuthenticationSchemes.None)] [InlineData(AuthenticationSchemes.Basic | AuthenticationSchemes.Anonymous)] public async Task BasicAuthentication_ValidUsernameAndPassword_Success(AuthenticationSchemes authScheme) { diff --git a/src/libraries/System.Net.HttpListener/tests/HttpListenerPrefixCollectionTests.cs b/src/libraries/System.Net.HttpListener/tests/HttpListenerPrefixCollectionTests.cs index f37f10f..9aeb03c 100644 --- a/src/libraries/System.Net.HttpListener/tests/HttpListenerPrefixCollectionTests.cs +++ b/src/libraries/System.Net.HttpListener/tests/HttpListenerPrefixCollectionTests.cs @@ -395,7 +395,6 @@ namespace System.Net.Tests [InlineData("http://localhost:9200")] [InlineData("http://localhost/path")] [InlineData("http://::/")] - [InlineData("http://::/")] public void Add_InvalidPrefix_ThrowsArgumentException(string uriPrefix) { var listener = new HttpListener(); diff --git a/src/libraries/System.Net.HttpListener/tests/HttpListenerRequestTests.cs b/src/libraries/System.Net.HttpListener/tests/HttpListenerRequestTests.cs index 4ddd9d1..aa85689 100644 --- a/src/libraries/System.Net.HttpListener/tests/HttpListenerRequestTests.cs +++ b/src/libraries/System.Net.HttpListener/tests/HttpListenerRequestTests.cs @@ -33,7 +33,6 @@ namespace System.Net.Tests [Theory] [InlineData("Accept: Test", new string[] { "Test" })] [InlineData("Accept: Test, Test2,Test3 , Test4", new string[] { "Test", "Test2", "Test3 ", " Test4" })] - [InlineData("Accept: Test", new string[] { "Test" })] [InlineData("Accept: ", new string[] { "" })] [InlineData("Unknown-Header: ", null)] public async Task AcceptTypes_GetProperty_ReturnsExpected(string acceptString, string[] expected) @@ -135,7 +134,6 @@ namespace System.Net.Tests [InlineData("PUT", "Content-Length: 1\nContent-Length: 1", 1, true)] [InlineData("POST", "Transfer-Encoding: chunked", -1, true)] [InlineData("PUT", "Transfer-Encoding: chunked", -1, true)] - [InlineData("PUT", "Transfer-Encoding: chunked", -1, true)] [InlineData("PUT", "Content-Length: 10\nTransfer-Encoding: chunked", -1, true)] [InlineData("PUT", "Transfer-Encoding: chunked\nContent-Length: 10", -1, true)] public async Task ContentLength_GetProperty_ReturnsExpected(string method, string contentLengthString, long expected, bool hasEntityBody) diff --git a/src/libraries/System.Net.HttpListener/tests/HttpListenerWebSocketTests.cs b/src/libraries/System.Net.HttpListener/tests/HttpListenerWebSocketTests.cs index 3efa3b0..811fdc6 100644 --- a/src/libraries/System.Net.HttpListener/tests/HttpListenerWebSocketTests.cs +++ b/src/libraries/System.Net.HttpListener/tests/HttpListenerWebSocketTests.cs @@ -71,7 +71,6 @@ namespace System.Net.Tests [ConditionalTheory(nameof(IsNotWindows7))] [InlineData(WebSocketMessageType.Close)] [InlineData(WebSocketMessageType.Text - 1)] - [InlineData(WebSocketMessageType.Binary + 1)] public async Task SendAsync_InvalidMessageType_ThrowsArgumentNullException(WebSocketMessageType messageType) { HttpListenerWebSocketContext context = await GetWebSocketContext(); diff --git a/src/libraries/System.Net.Mail/tests/Functional/SmtpClientTest.cs b/src/libraries/System.Net.Mail/tests/Functional/SmtpClientTest.cs index ceb2aab..3e5665f 100644 --- a/src/libraries/System.Net.Mail/tests/Functional/SmtpClientTest.cs +++ b/src/libraries/System.Net.Mail/tests/Functional/SmtpClientTest.cs @@ -49,7 +49,6 @@ namespace System.Net.Mail.Tests [Theory] [InlineData(SmtpDeliveryMethod.SpecifiedPickupDirectory)] [InlineData(SmtpDeliveryMethod.PickupDirectoryFromIis)] - [InlineData(SmtpDeliveryMethod.PickupDirectoryFromIis)] public void DeliveryMethodTest(SmtpDeliveryMethod method) { Smtp.DeliveryMethod = method; diff --git a/src/libraries/System.Private.Xml/tests/Xslt/XslCompiledTransformApi/XslCompiledTransform.cs b/src/libraries/System.Private.Xml/tests/Xslt/XslCompiledTransformApi/XslCompiledTransform.cs index 014d8a4..c3e86a7 100644 --- a/src/libraries/System.Private.Xml/tests/Xslt/XslCompiledTransformApi/XslCompiledTransform.cs +++ b/src/libraries/System.Private.Xml/tests/Xslt/XslCompiledTransformApi/XslCompiledTransform.cs @@ -1294,13 +1294,7 @@ namespace System.Xml.Tests //[Variation("Style sheet has import/include, call Load first with default resolver and then with custom null resolver, should fail", Param = "XmlResolverTestMain.txt")] [InlineData("XmlResolverTestMain.txt", XslInputType.URI, ReaderType.XmlValidatingReader)] - [InlineData("XmlResolverTestMain.txt", XslInputType.URI, ReaderType.XmlValidatingReader)] - [InlineData("XmlResolverTestMain.txt", XslInputType.URI, ReaderType.XmlValidatingReader)] - [InlineData("XmlResolverTestMain.txt", XslInputType.Reader, ReaderType.XmlValidatingReader)] [InlineData("XmlResolverTestMain.txt", XslInputType.Reader, ReaderType.XmlValidatingReader)] - [InlineData("XmlResolverTestMain.txt", XslInputType.Reader, ReaderType.XmlValidatingReader)] - [InlineData("XmlResolverTestMain.txt", XslInputType.Navigator, ReaderType.XmlValidatingReader)] - [InlineData("XmlResolverTestMain.txt", XslInputType.Navigator, ReaderType.XmlValidatingReader)] [InlineData("XmlResolverTestMain.txt", XslInputType.Navigator, ReaderType.XmlValidatingReader)] [Theory] public void LoadGeneric8(object param, XslInputType xslInputType, ReaderType readerType) diff --git a/src/libraries/System.Private.Xml/tests/Xslt/XslTransformApi/CXslTransform.cs b/src/libraries/System.Private.Xml/tests/Xslt/XslTransformApi/CXslTransform.cs index 3b3f264..3d39445 100644 --- a/src/libraries/System.Private.Xml/tests/Xslt/XslTransformApi/CXslTransform.cs +++ b/src/libraries/System.Private.Xml/tests/Xslt/XslTransformApi/CXslTransform.cs @@ -1884,14 +1884,6 @@ namespace System.Xml.Tests [InlineData(TransformType.Stream, DocType.XPathDocument)] [InlineData(TransformType.Writer, DocType.XPathDocument)] [InlineData(TransformType.TextWriter, DocType.XPathDocument)] - [InlineData(TransformType.Reader, DocType.XPathDocument)] - [InlineData(TransformType.Writer, DocType.XPathDocument)] - [InlineData(TransformType.Stream, DocType.XPathDocument)] - [InlineData(TransformType.TextWriter, DocType.XPathDocument)] - [InlineData(TransformType.Reader, DocType.XPathDocument)] - [InlineData(TransformType.Writer, DocType.XPathDocument)] - [InlineData(TransformType.Stream, DocType.XPathDocument)] - [InlineData(TransformType.TextWriter, DocType.XPathDocument)] [Theory] public void TransformGeneric4(TransformType transformType, DocType docType) { diff --git a/src/libraries/System.Reflection.Emit/tests/ConstructorBuilder/ConstructorBuilderGetILGenerator.cs b/src/libraries/System.Reflection.Emit/tests/ConstructorBuilder/ConstructorBuilderGetILGenerator.cs index d7091da..d4207f5 100644 --- a/src/libraries/System.Reflection.Emit/tests/ConstructorBuilder/ConstructorBuilderGetILGenerator.cs +++ b/src/libraries/System.Reflection.Emit/tests/ConstructorBuilder/ConstructorBuilderGetILGenerator.cs @@ -20,7 +20,6 @@ namespace System.Reflection.Emit.Tests [InlineData(MethodAttributes.MemberAccessMask)] [InlineData(MethodAttributes.NewSlot)] [InlineData(MethodAttributes.Private)] - [InlineData(MethodAttributes.PrivateScope)] [InlineData(MethodAttributes.Public)] [InlineData(MethodAttributes.RequireSecObject)] [InlineData(MethodAttributes.ReuseSlot)] @@ -29,7 +28,6 @@ namespace System.Reflection.Emit.Tests [InlineData(MethodAttributes.Static)] [InlineData(MethodAttributes.UnmanagedExport)] [InlineData(MethodAttributes.Virtual)] - [InlineData(MethodAttributes.VtableLayoutMask)] public void GetILGenerator_ReturnsNonNull(MethodAttributes attributes) { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); diff --git a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderGetILGenerator.cs b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderGetILGenerator.cs index 6720d90..70b5499 100644 --- a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderGetILGenerator.cs +++ b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderGetILGenerator.cs @@ -52,7 +52,6 @@ namespace System.Reflection.Emit.Tests [InlineData(MethodAttributes.MemberAccessMask)] [InlineData(MethodAttributes.NewSlot)] [InlineData(MethodAttributes.Private)] - [InlineData(MethodAttributes.PrivateScope)] [InlineData(MethodAttributes.Public)] [InlineData(MethodAttributes.RequireSecObject)] [InlineData(MethodAttributes.ReuseSlot)] @@ -61,7 +60,6 @@ namespace System.Reflection.Emit.Tests [InlineData(MethodAttributes.Static)] [InlineData(MethodAttributes.UnmanagedExport)] [InlineData(MethodAttributes.Virtual)] - [InlineData(MethodAttributes.VtableLayoutMask)] [InlineData(MethodAttributes.Assembly | MethodAttributes.CheckAccessOnOverride | MethodAttributes.FamORAssem | MethodAttributes.Final | MethodAttributes.HasSecurity | MethodAttributes.HideBySig | MethodAttributes.MemberAccessMask | diff --git a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetImplementationFlags.cs b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetImplementationFlags.cs index cd1bc56..59fc94e 100644 --- a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetImplementationFlags.cs +++ b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetImplementationFlags.cs @@ -9,12 +9,9 @@ namespace System.Reflection.Emit.Tests public class MethodBuilderSetImplementationFlags { [Theory] - [InlineData(MethodImplAttributes.CodeTypeMask)] [InlineData(MethodImplAttributes.ForwardRef)] [InlineData(MethodImplAttributes.IL)] [InlineData(MethodImplAttributes.InternalCall)] - [InlineData(MethodImplAttributes.Managed)] - [InlineData(MethodImplAttributes.ManagedMask)] [InlineData(MethodImplAttributes.Native)] [InlineData(MethodImplAttributes.NoInlining)] [InlineData(MethodImplAttributes.OPTIL)] diff --git a/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineEnum.cs b/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineEnum.cs index cc820b7..b882e0a 100644 --- a/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineEnum.cs +++ b/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineEnum.cs @@ -125,14 +125,12 @@ namespace System.Reflection.Emit.Tests [InlineData(TypeAttributes.ExplicitLayout, "name")] [InlineData(TypeAttributes.HasSecurity, "name")] [InlineData(TypeAttributes.Import, "name")] - [InlineData(TypeAttributes.ClassSemanticsMask, "name")] [InlineData(TypeAttributes.LayoutMask, "name")] [InlineData(TypeAttributes.RTSpecialName, "name")] [InlineData(TypeAttributes.Sealed, "name")] [InlineData(TypeAttributes.SequentialLayout, "name")] [InlineData(TypeAttributes.Serializable, "name")] [InlineData(TypeAttributes.SpecialName, "name")] - [InlineData(TypeAttributes.CustomFormatClass, "name")] [InlineData(TypeAttributes.UnicodeClass, "name")] [InlineData(TypeAttributes.NestedAssembly, null)] [InlineData(TypeAttributes.NestedFamANDAssem, null)] diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateType.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateType.cs index b791a65..4e3fd64 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateType.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateType.cs @@ -12,11 +12,8 @@ namespace System.Reflection.Emit.Tests [InlineData(TypeAttributes.Abstract)] [InlineData(TypeAttributes.AnsiClass)] [InlineData(TypeAttributes.AutoClass)] - [InlineData(TypeAttributes.AutoLayout)] [InlineData(TypeAttributes.BeforeFieldInit)] - [InlineData(TypeAttributes.Class)] [InlineData(TypeAttributes.ClassSemanticsMask | TypeAttributes.Abstract)] - [InlineData(TypeAttributes.NotPublic)] [InlineData(TypeAttributes.Public)] [InlineData(TypeAttributes.Sealed)] [InlineData(TypeAttributes.SequentialLayout)] @@ -45,7 +42,6 @@ namespace System.Reflection.Emit.Tests [InlineData(TypeAttributes.NestedPublic)] [InlineData(TypeAttributes.ReservedMask)] [InlineData(TypeAttributes.RTSpecialName)] - [InlineData(TypeAttributes.VisibilityMask)] public void CreateType_BadAttributes(TypeAttributes attributes) { try diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateTypeInfo.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateTypeInfo.cs index 66817e5..e7440a3 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateTypeInfo.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateTypeInfo.cs @@ -12,11 +12,8 @@ namespace System.Reflection.Emit.Tests [InlineData(TypeAttributes.Abstract)] [InlineData(TypeAttributes.AnsiClass)] [InlineData(TypeAttributes.AutoClass)] - [InlineData(TypeAttributes.AutoLayout)] [InlineData(TypeAttributes.BeforeFieldInit)] - [InlineData(TypeAttributes.Class)] [InlineData(TypeAttributes.ClassSemanticsMask | TypeAttributes.Abstract)] - [InlineData(TypeAttributes.NotPublic)] [InlineData(TypeAttributes.Public)] [InlineData(TypeAttributes.Sealed)] [InlineData(TypeAttributes.SequentialLayout)] @@ -64,7 +61,6 @@ namespace System.Reflection.Emit.Tests [InlineData(TypeAttributes.NestedPrivate, typeof(ArgumentException))] [InlineData(TypeAttributes.NestedPublic, typeof(ArgumentException))] [InlineData(TypeAttributes.RTSpecialName, typeof(ArgumentException))] - [InlineData(TypeAttributes.VisibilityMask, typeof(ArgumentException))] public void CreateType_InvalidTypeAttributes_Throws(TypeAttributes attributes, Type exceptionType) { Assert.Throws(exceptionType, () => Helpers.DynamicType(attributes)); diff --git a/src/libraries/System.Reflection/tests/TypeInfoTests.cs b/src/libraries/System.Reflection/tests/TypeInfoTests.cs index 7109e6e..9960b99 100644 --- a/src/libraries/System.Reflection/tests/TypeInfoTests.cs +++ b/src/libraries/System.Reflection/tests/TypeInfoTests.cs @@ -75,7 +75,6 @@ namespace System.Reflection.Tests [InlineData(typeof(TI_SubClass), nameof(TI_SubClass.s_field), true, typeof(string), false)] [InlineData(typeof(TI_SubClass), nameof(TI_SubClass.s_readonlyField), true, typeof(string), false)] [InlineData(typeof(TI_SubClass), nameof(TI_SubClass.s_volatileField), true, typeof(string), false)] - [InlineData(typeof(TI_BaseClass), nameof(TI_SubClass.s_arrayField), true, typeof(string[]), false)] public void DeclaredFields(Type type, string name, bool exists, Type fieldType, bool isPrivate) { IEnumerable fields = type.GetTypeInfo().DeclaredFields.Select(fieldInfo => fieldInfo.Name); @@ -1214,7 +1213,6 @@ namespace System.Reflection.Tests [Theory] [InlineData(typeof(TI_BaseClass), true)] [InlineData(typeof(TI_SubClass), true)] - [InlineData(typeof(TI_BaseClass), true)] [InlineData(typeof(TI_NonGenericInterface1), true)] [InlineData(typeof(TI_ClassWithInterface1), true)] public void IsPublic(Type type, bool expected) @@ -1264,7 +1262,6 @@ namespace System.Reflection.Tests [InlineData(typeof(TI_BaseClass), true)] [InlineData(typeof(TI_NonGenericInterface1), true)] [InlineData(typeof(PublicEnum), true)] - [InlineData(typeof(TI_BaseClass), true)] [InlineData(typeof(TI_BaseClass.PublicNestedClass1), true)] public void IsVisible(Type type, bool expected) { @@ -1275,7 +1272,6 @@ namespace System.Reflection.Tests [InlineData(typeof(TI_BaseClass), "System.Reflection.Tests")] [InlineData(typeof(TI_NonGenericInterface1), "System.Reflection.Tests")] [InlineData(typeof(PublicEnum), "System.Reflection.Tests")] - [InlineData(typeof(TI_BaseClass), "System.Reflection.Tests")] [InlineData(typeof(TI_BaseClass.PublicNestedClass1), "System.Reflection.Tests")] [InlineData(typeof(int), "System")] public void Namespace(Type type, string expected) diff --git a/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs b/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs index a4e3341..923408c 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs @@ -335,8 +335,7 @@ namespace System.Tests [Theory] [PlatformSpecific(TestPlatforms.AnyUnix)] // Tests OS-specific environment [InlineData(Environment.SpecialFolder.UserProfile, Environment.SpecialFolderOption.None)] - [InlineData(Environment.SpecialFolder.Personal, Environment.SpecialFolderOption.None)] - [InlineData(Environment.SpecialFolder.MyDocuments, Environment.SpecialFolderOption.None)] + [InlineData(Environment.SpecialFolder.MyDocuments, Environment.SpecialFolderOption.None)] // MyDocuments == Personal [InlineData(Environment.SpecialFolder.CommonApplicationData, Environment.SpecialFolderOption.None)] [InlineData(Environment.SpecialFolder.CommonTemplates, Environment.SpecialFolderOption.DoNotVerify)] [InlineData(Environment.SpecialFolder.ApplicationData, Environment.SpecialFolderOption.DoNotVerify)] diff --git a/src/libraries/System.Runtime.Extensions/tests/System/IO/PathTests.netcoreapp.cs b/src/libraries/System.Runtime.Extensions/tests/System/IO/PathTests.netcoreapp.cs index ff2b109..af8d24f 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/IO/PathTests.netcoreapp.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/IO/PathTests.netcoreapp.cs @@ -63,7 +63,6 @@ namespace System.IO.Tests } [Theory, - InlineData(@" C:\dir/baz", @" C:\dir"), InlineData(@" C:\dir/baz", @" C:\dir")] public void GetDirectoryName_SkipSpaces(string path, string expected) { diff --git a/src/libraries/System.Runtime.Extensions/tests/System/Math.cs b/src/libraries/System.Runtime.Extensions/tests/System/Math.cs index 3ba410e..855c80f 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/Math.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/Math.cs @@ -6,6 +6,8 @@ using Xunit; using Xunit.Sdk; using System.Collections.Generic; +#pragma warning disable xUnit1025 // reporting duplicate test cases due to not distinguishing 0.0 from -0.0 + namespace System.Tests { public static partial class MathTests diff --git a/src/libraries/System.Runtime.Extensions/tests/System/MathF.netcoreapp.cs b/src/libraries/System.Runtime.Extensions/tests/System/MathF.netcoreapp.cs index fe79fb8..a3c0a83 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/MathF.netcoreapp.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/MathF.netcoreapp.cs @@ -6,6 +6,8 @@ using Xunit; using Xunit.Sdk; using System.Collections.Generic; +#pragma warning disable xUnit1025 // reporting duplicate test cases due to not distinguishing 0.0 from -0.0 + namespace System.Tests { public static partial class MathFTests diff --git a/src/libraries/System.Runtime.Extensions/tests/System/MathTests.netcoreapp.cs b/src/libraries/System.Runtime.Extensions/tests/System/MathTests.netcoreapp.cs index 61e8ca2..48c2a76 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/MathTests.netcoreapp.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/MathTests.netcoreapp.cs @@ -5,6 +5,8 @@ using System.Collections.Generic; using Xunit; +#pragma warning disable xUnit1025 // reporting duplicate test cases due to not distinguishing 0.0 from -0.0 + namespace System.Tests { public static partial class MathTests diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetObjectForNativeVariantTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetObjectForNativeVariantTests.cs index 9852400..86f2900 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetObjectForNativeVariantTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetObjectForNativeVariantTests.cs @@ -771,9 +771,10 @@ namespace System.Runtime.InteropServices.Tests } [Theory] + [InlineData(VT_I1 | VT_BYREF)] [InlineData(VT_I2 | VT_BYREF)] - [InlineData(VT_UI2 | VT_BYREF)] [InlineData(VT_I4 | VT_BYREF)] + [InlineData(VT_I8 | VT_BYREF)] [InlineData(VT_R4 | VT_BYREF)] [InlineData(VT_R8 | VT_BYREF)] [InlineData(VT_CY | VT_BYREF)] @@ -784,11 +785,9 @@ namespace System.Runtime.InteropServices.Tests [InlineData(VT_BOOL | VT_BYREF)] [InlineData(VT_VARIANT | VT_BYREF)] [InlineData(VT_UNKNOWN | VT_BYREF)] - [InlineData(VT_I1 | VT_BYREF)] [InlineData(VT_UI1 | VT_BYREF)] [InlineData(VT_UI2 | VT_BYREF)] [InlineData(VT_UI4 | VT_BYREF)] - [InlineData(VT_I8 | VT_BYREF)] [InlineData(VT_UI8 | VT_BYREF)] [InlineData(VT_INT | VT_BYREF)] [InlineData(VT_UINT | VT_BYREF)] @@ -818,8 +817,6 @@ namespace System.Runtime.InteropServices.Tests [InlineData(VT_ARRAY | VT_BYREF)] [InlineData(VT_RESERVED | VT_BYREF)] [InlineData(VT_ILLEGAL | VT_BYREF)] - [InlineData(VT_ILLEGALMASKED | VT_BYREF)] - [InlineData(VT_TYPEMASK| VT_BYREF)] [PlatformSpecific(TestPlatforms.Windows)] public void GetObjectForNativeVariant_ZeroByRefTypeNotEmptyOrNull_ThrowsArgumentException(ushort vt) { diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/StringToCoTaskMemUTF8Tests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/StringToCoTaskMemUTF8Tests.cs index bbf54a8..a7600b9 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/StringToCoTaskMemUTF8Tests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/StringToCoTaskMemUTF8Tests.cs @@ -16,7 +16,6 @@ namespace System.Runtime.InteropServices.Tests [InlineData("\u0130")] [InlineData("\uD803\uDD75\uD803\uDD75\uD803\uDD75")] [InlineData("za\u0306\u01FD\u03B2\uD8FF\uDCFF")] - [InlineData("za\u0306\u01FD\u03B2\uD8FF\uDCFF")] [InlineData("\u0023\u0025\u03a0\u03a3")] [InlineData("\u00C5")] [InlineData("\u0065\u0065\u00E1\u0065\u0065\u8000\u00E1\u0065\uD800\uDC00\u8000\u00E1\u0065\u0065\u0065")] diff --git a/src/libraries/System.Runtime/tests/System/ByteTests.cs b/src/libraries/System.Runtime/tests/System/ByteTests.cs index cb12223..570abba 100644 --- a/src/libraries/System.Runtime/tests/System/ByteTests.cs +++ b/src/libraries/System.Runtime/tests/System/ByteTests.cs @@ -39,7 +39,6 @@ namespace System.Tests [Theory] [InlineData((byte)234, (byte)234, 0)] [InlineData((byte)234, byte.MinValue, 1)] - [InlineData((byte)234, (byte)0, 1)] [InlineData((byte)234, (byte)123, 1)] [InlineData((byte)234, (byte)235, -1)] [InlineData((byte)234, byte.MaxValue, -1)] diff --git a/src/libraries/System.Runtime/tests/System/DateTimeTests.cs b/src/libraries/System.Runtime/tests/System/DateTimeTests.cs index 9b7dccb..aab0555 100644 --- a/src/libraries/System.Runtime/tests/System/DateTimeTests.cs +++ b/src/libraries/System.Runtime/tests/System/DateTimeTests.cs @@ -873,7 +873,6 @@ namespace System.Tests [InlineData(3155378976000000000)] [InlineData(long.MaxValue)] [InlineData(3155378976000000000 | ((long)DateTimeKind.Utc << 62))] - [InlineData(long.MaxValue | ((long)DateTimeKind.Utc << 62))] public void FromBinary_OutOfRangeTicks_ThrowsArgumentException(long dateData) { AssertExtensions.Throws("dateData", () => DateTime.FromBinary(dateData)); diff --git a/src/libraries/System.Runtime/tests/System/DecimalTests.cs b/src/libraries/System.Runtime/tests/System/DecimalTests.cs index 7e42c04..9bbe006 100644 --- a/src/libraries/System.Runtime/tests/System/DecimalTests.cs +++ b/src/libraries/System.Runtime/tests/System/DecimalTests.cs @@ -150,7 +150,6 @@ namespace System.Tests [InlineData(new int[] { 0, 0, 0 })] [InlineData(new int[] { 0, 0, 0, 0, 0 })] [InlineData(new int[] { 0, 0, 0, 1 })] - [InlineData(new int[] { 0, 0, 0, 0x00001 })] [InlineData(new int[] { 0, 0, 0, 0x1D0000 })] [InlineData(new int[] { 0, 0, 0, unchecked((int)0x40000000) })] public void Ctor_InvalidBits_ThrowsArgumentException(int[] bits) diff --git a/src/libraries/System.Runtime/tests/System/DoubleTests.cs b/src/libraries/System.Runtime/tests/System/DoubleTests.cs index 3c33a2e..fab8f9c 100644 --- a/src/libraries/System.Runtime/tests/System/DoubleTests.cs +++ b/src/libraries/System.Runtime/tests/System/DoubleTests.cs @@ -3,12 +3,12 @@ // See the LICENSE file in the project root for more information. using System.Collections.Generic; -using System.Diagnostics; using System.Globalization; -using System.Runtime.CompilerServices; using Microsoft.DotNet.RemoteExecutor; using Xunit; +#pragma warning disable xUnit1025 // reporting duplicate test cases due to not distinguishing 0.0 from -0.0, NaN from -NaN + namespace System.Tests { public partial class DoubleTests diff --git a/src/libraries/System.Runtime/tests/System/DoubleTests.netcoreapp.cs b/src/libraries/System.Runtime/tests/System/DoubleTests.netcoreapp.cs index ddcb81d..f47687e 100644 --- a/src/libraries/System.Runtime/tests/System/DoubleTests.netcoreapp.cs +++ b/src/libraries/System.Runtime/tests/System/DoubleTests.netcoreapp.cs @@ -3,11 +3,12 @@ // See the LICENSE file in the project root for more information. using System.Collections.Generic; -using System.Diagnostics; using System.Globalization; using Microsoft.DotNet.RemoteExecutor; using Xunit; +#pragma warning disable xUnit1025 // reporting duplicate test cases due to not distinguishing 0.0 from -0.0, NaN from -NaN + namespace System.Tests { public partial class DoubleTests diff --git a/src/libraries/System.Runtime/tests/System/SingleTests.cs b/src/libraries/System.Runtime/tests/System/SingleTests.cs index ae813f2..8d6a50b 100644 --- a/src/libraries/System.Runtime/tests/System/SingleTests.cs +++ b/src/libraries/System.Runtime/tests/System/SingleTests.cs @@ -3,12 +3,13 @@ // See the LICENSE file in the project root for more information. using System.Collections.Generic; -using System.Diagnostics; using System.Globalization; using System.Runtime.CompilerServices; using Microsoft.DotNet.RemoteExecutor; using Xunit; +#pragma warning disable xUnit1025 // reporting duplicate test cases due to not distinguishing 0.0 from -0.0, NaN from -NaN + namespace System.Tests { public partial class SingleTests diff --git a/src/libraries/System.Runtime/tests/System/SingleTests.netcoreapp.cs b/src/libraries/System.Runtime/tests/System/SingleTests.netcoreapp.cs index ff3696c..bd15a04 100644 --- a/src/libraries/System.Runtime/tests/System/SingleTests.netcoreapp.cs +++ b/src/libraries/System.Runtime/tests/System/SingleTests.netcoreapp.cs @@ -3,11 +3,12 @@ // See the LICENSE file in the project root for more information. using System.Collections.Generic; -using System.Diagnostics; using System.Globalization; using Microsoft.DotNet.RemoteExecutor; using Xunit; +#pragma warning disable xUnit1025 // reporting duplicate test cases due to not distinguishing 0.0 from -0.0, NaN from -NaN + namespace System.Tests { public partial class SingleTests diff --git a/src/libraries/System.Runtime/tests/System/Text/RuneTests.netcoreapp.cs b/src/libraries/System.Runtime/tests/System/Text/RuneTests.netcoreapp.cs index d90f688..942c715 100644 --- a/src/libraries/System.Runtime/tests/System/Text/RuneTests.netcoreapp.cs +++ b/src/libraries/System.Runtime/tests/System/Text/RuneTests.netcoreapp.cs @@ -169,7 +169,6 @@ namespace System.Text.Tests [InlineData(new char[] { '\ud83d', '\ude32' }, OperationStatus.Done, 0x1F632, 2)] // supplementary value (U+1F632 ASTONISHED FACE) [InlineData(new char[] { '\udc00' }, OperationStatus.InvalidData, 0xFFFD, 1)] // standalone low surrogate [InlineData(new char[] { '\udc00', '\udc00' }, OperationStatus.InvalidData, 0xFFFD, 1)] // standalone low surrogate - [InlineData(new char[] { '\udc00', '\udc00' }, OperationStatus.InvalidData, 0xFFFD, 1)] // standalone low surrogate [InlineData(new char[] { '\ud800' }, OperationStatus.NeedMoreData, 0xFFFD, 1)] // high surrogate at end of buffer [InlineData(new char[] { '\ud800', '\ud800' }, OperationStatus.InvalidData, 0xFFFD, 1)] // standalone high surrogate [InlineData(new char[] { '\ud800', '\u1234' }, OperationStatus.InvalidData, 0xFFFD, 1)] // standalone high surrogate diff --git a/src/libraries/System.Runtime/tests/System/Text/Unicode/Utf16UtilityTests.ValidateChars.netcoreapp.cs b/src/libraries/System.Runtime/tests/System/Text/Unicode/Utf16UtilityTests.ValidateChars.netcoreapp.cs index 3c509df..cf47587 100644 --- a/src/libraries/System.Runtime/tests/System/Text/Unicode/Utf16UtilityTests.ValidateChars.netcoreapp.cs +++ b/src/libraries/System.Runtime/tests/System/Text/Unicode/Utf16UtilityTests.ValidateChars.netcoreapp.cs @@ -57,7 +57,6 @@ namespace System.Text.Unicode.Tests [InlineData("<1854><012C><4797><41D0><5464>", 4, 4, 11)] [InlineData("<8BD3><5037><3E3A><6336>", 4, 4, 12)] [InlineData("<0F25><7352><4025><0B93><4107>", 2, 2, 6)] - [InlineData("<2BB4><218C><1BC0><613F>", 6, 6, 18)] [InlineData("<887C><012C><4797><41D0><5464>", 4, 4, 11)] public void GetIndexOfFirstInvalidUtf16Sequence_WithEightRandomCharsContainingUnpairedSurrogates(string unprocessedInput, int idxOfFirstInvalidChar, int expectedRuneCount, int expectedUtf8ByteCount) { diff --git a/src/libraries/System.Runtime/tests/System/UInt16Tests.cs b/src/libraries/System.Runtime/tests/System/UInt16Tests.cs index 4c9a9f4..ef837a5 100644 --- a/src/libraries/System.Runtime/tests/System/UInt16Tests.cs +++ b/src/libraries/System.Runtime/tests/System/UInt16Tests.cs @@ -39,7 +39,6 @@ namespace System.Tests [Theory] [InlineData((ushort)234, (ushort)234, 0)] [InlineData((ushort)234, ushort.MinValue, 1)] - [InlineData((ushort)234, (ushort)0, 1)] [InlineData((ushort)234, (ushort)123, 1)] [InlineData((ushort)234, (ushort)456, -1)] [InlineData((ushort)234, ushort.MaxValue, -1)] diff --git a/src/libraries/System.Runtime/tests/System/UInt32Tests.cs b/src/libraries/System.Runtime/tests/System/UInt32Tests.cs index 5b8f54c..9265c13 100644 --- a/src/libraries/System.Runtime/tests/System/UInt32Tests.cs +++ b/src/libraries/System.Runtime/tests/System/UInt32Tests.cs @@ -40,7 +40,6 @@ namespace System.Tests [Theory] [InlineData((uint)234, (uint)234, 0)] [InlineData((uint)234, uint.MinValue, 1)] - [InlineData((uint)234, (uint)0, 1)] [InlineData((uint)234, (uint)123, 1)] [InlineData((uint)234, (uint)456, -1)] [InlineData((uint)234, uint.MaxValue, -1)] diff --git a/src/libraries/System.Runtime/tests/System/UInt64Tests.cs b/src/libraries/System.Runtime/tests/System/UInt64Tests.cs index 6394909..5976972 100644 --- a/src/libraries/System.Runtime/tests/System/UInt64Tests.cs +++ b/src/libraries/System.Runtime/tests/System/UInt64Tests.cs @@ -40,7 +40,6 @@ namespace System.Tests [Theory] [InlineData((ulong)234, (ulong)234, 0)] [InlineData((ulong)234, ulong.MinValue, 1)] - [InlineData((ulong)234, (ulong)0, 1)] [InlineData((ulong)234, (ulong)123, 1)] [InlineData((ulong)234, (ulong)456, -1)] [InlineData((ulong)234, ulong.MaxValue, -1)] diff --git a/src/libraries/System.Security.Cryptography.Xml/tests/Signature_ArbitraryElements.cs b/src/libraries/System.Security.Cryptography.Xml/tests/Signature_ArbitraryElements.cs index eae7bac..a98aa90 100644 --- a/src/libraries/System.Security.Cryptography.Xml/tests/Signature_ArbitraryElements.cs +++ b/src/libraries/System.Security.Cryptography.Xml/tests/Signature_ArbitraryElements.cs @@ -108,8 +108,6 @@ namespace System.Security.Cryptography.Xml.Tests [InlineData(@"this", true, false)] //CData_Text [InlineData(@"&", true, false)] //EntityReference [InlineData(@"", true, false)] //EntityReference - [InlineData(@"", true, false)] //EntityReference - public static void ExtraData(string arbitraryData, bool checkSignatureSucceeds, bool loadThrows) { string xml = $@" diff --git a/src/libraries/System.Text.Encoding/tests/UTF7Encoding/UTF7EncodingGetMaxByteCount.cs b/src/libraries/System.Text.Encoding/tests/UTF7Encoding/UTF7EncodingGetMaxByteCount.cs index c9598f0..588611c 100644 --- a/src/libraries/System.Text.Encoding/tests/UTF7Encoding/UTF7EncodingGetMaxByteCount.cs +++ b/src/libraries/System.Text.Encoding/tests/UTF7Encoding/UTF7EncodingGetMaxByteCount.cs @@ -13,7 +13,6 @@ namespace System.Text.Tests [InlineData(1)] [InlineData(8)] [InlineData(10)] - [InlineData(715827881)] [InlineData((int.MaxValue - 2) / 3)] public void GetMaxByteCount(int charCount) { diff --git a/src/libraries/System.Text.Json/tests/JsonElementWriteTests.cs b/src/libraries/System.Text.Json/tests/JsonElementWriteTests.cs index 0bb5674..9dedb7d 100644 --- a/src/libraries/System.Text.Json/tests/JsonElementWriteTests.cs +++ b/src/libraries/System.Text.Json/tests/JsonElementWriteTests.cs @@ -51,7 +51,7 @@ namespace System.Text.Json.Tests [InlineData("1e-6", true)] [InlineData("-1e6", false)] [InlineData("-1e6", true)] - [InlineData("-1e+6", true)] + [InlineData("-1e+6", false)] [InlineData("-1e+6", true)] [InlineData("-1e-6", false)] [InlineData("-1e-6", true)] diff --git a/src/libraries/System.Text.RegularExpressions/tests/RegexParserTests.cs b/src/libraries/System.Text.RegularExpressions/tests/RegexParserTests.cs index f809681..42ad4d4 100644 --- a/src/libraries/System.Text.RegularExpressions/tests/RegexParserTests.cs +++ b/src/libraries/System.Text.RegularExpressions/tests/RegexParserTests.cs @@ -591,7 +591,6 @@ namespace System.Text.RegularExpressions.Tests [InlineData(@"[^", RegexOptions.None, RegexParseError.UnterminatedBracket)] [InlineData(@"[cat", RegexOptions.None, RegexParseError.UnterminatedBracket)] [InlineData(@"[^cat", RegexOptions.None, RegexParseError.UnterminatedBracket)] - [InlineData(@"\p{", RegexOptions.None, RegexParseError.IncompleteSlashP)] [InlineData(@"\p{cat", RegexOptions.None, RegexParseError.IncompleteSlashP)] [InlineData(@"\k", RegexOptions.None, RegexParseError.NotEnoughParentheses)] - [InlineData("(?'cat'", RegexOptions.None, RegexParseError.NotEnoughParentheses)] - [InlineData("(?imn", RegexOptions.None, RegexParseError.UnrecognizedGrouping)] - [InlineData("(?imn )", RegexOptions.None, RegexParseError.UnrecognizedGrouping)] [InlineData("(?>-", RegexOptions.None, RegexParseError.NotEnoughParentheses)] - [InlineData("(?<)", RegexOptions.None, RegexParseError.InvalidGroupName)] - [InlineData("(?')", RegexOptions.None, RegexParseError.InvalidGroupName)] - // Invalid alternation constructs - [InlineData("(?(", RegexOptions.None, RegexParseError.NotEnoughParentheses)] - [InlineData("(?()|", RegexOptions.None, RegexParseError.NotEnoughParentheses)] - [InlineData("(?(cat", RegexOptions.None, RegexParseError.NotEnoughParentheses)] - [InlineData("(?(cat)|", RegexOptions.None, RegexParseError.NotEnoughParentheses)] - // Regex with 0 numeric names - [InlineData("foo(?<0>bar)", RegexOptions.None, RegexParseError.CapnumNotZero)] - [InlineData("foo(?'0'bar)", RegexOptions.None, RegexParseError.CapnumNotZero)] - // Regex without closing > - [InlineData("foo(?<1bar)", RegexOptions.None, RegexParseError.InvalidGroupName)] - [InlineData("foo(?'1bar)", RegexOptions.None, RegexParseError.InvalidGroupName)] - // Misc - [InlineData("(?r:cat)", RegexOptions.None, RegexParseError.UnrecognizedGrouping)] - [InlineData("(?c:cat)", RegexOptions.None, RegexParseError.UnrecognizedGrouping)] - [InlineData("(??e:cat)", RegexOptions.None, RegexParseError.UnrecognizedGrouping)] - // Character class subtraction - [InlineData("[a-f-[]]+", RegexOptions.None, RegexParseError.UnterminatedBracket)] - //// Not character class substraction - [InlineData("[A-[]+", RegexOptions.None, RegexParseError.UnterminatedBracket)] - // Invalid testgroup - [InlineData("(?(?e))", RegexOptions.None, RegexParseError.UnrecognizedGrouping)] - [InlineData("(?(?a)", RegexOptions.None, RegexParseError.UnrecognizedGrouping)] - [InlineData("(?(?", RegexOptions.None, RegexParseError.UnrecognizedGrouping)] - [InlineData("?(a)", RegexOptions.None, RegexParseError.QuantifyAfterNothing)] - [InlineData("?(a|b)", RegexOptions.None, RegexParseError.QuantifyAfterNothing)] - [InlineData("?((a)", RegexOptions.None, RegexParseError.QuantifyAfterNothing)] - [InlineData("?((a)a", RegexOptions.None, RegexParseError.QuantifyAfterNothing)] - [InlineData("?((a)a|", RegexOptions.None, RegexParseError.QuantifyAfterNothing)] - [InlineData("?((a)a|b", RegexOptions.None, RegexParseError.QuantifyAfterNothing)] // Testgroup with options [InlineData("())", RegexOptions.None, RegexParseError.TooManyParentheses)] [InlineData("[a-z-[aeiuo]", RegexOptions.None, RegexParseError.UnterminatedBracket)] diff --git a/src/libraries/System.Transactions.Local/tests/NonMsdtcPromoterTests.cs b/src/libraries/System.Transactions.Local/tests/NonMsdtcPromoterTests.cs index 7b1d3b9..dc34875 100644 --- a/src/libraries/System.Transactions.Local/tests/NonMsdtcPromoterTests.cs +++ b/src/libraries/System.Transactions.Local/tests/NonMsdtcPromoterTests.cs @@ -2197,8 +2197,6 @@ namespace System.Transactions.Tests [InlineData(true, true, EnlistmentOptions.EnlistDuringPrepareRequired, EnlistmentOptions.EnlistDuringPrepareRequired, true)] [InlineData(true, true, EnlistmentOptions.EnlistDuringPrepareRequired, EnlistmentOptions.None, true)] [InlineData(true, false, EnlistmentOptions.EnlistDuringPrepareRequired, EnlistmentOptions.EnlistDuringPrepareRequired, true)] - [InlineData(true, false, EnlistmentOptions.EnlistDuringPrepareRequired, EnlistmentOptions.EnlistDuringPrepareRequired, true)] - [InlineData(false, true, EnlistmentOptions.None, EnlistmentOptions.None, false)] [InlineData(false, true, EnlistmentOptions.None, EnlistmentOptions.None, false)] [InlineData(true, true, EnlistmentOptions.None, EnlistmentOptions.EnlistDuringPrepareRequired, false)] [InlineData(true, true, EnlistmentOptions.None, EnlistmentOptions.None, false)] -- 2.7.4