From bf830b01a21e6ff2f44c17be4ad4ee897465a677 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Tue, 3 Dec 2019 15:31:46 -0500 Subject: [PATCH] Switch to opening the temp file in binary mode This corrects an issue where the script would write the file with the incorrect line endings on Windows. --- clang/test/AST/gen_ast_dump_json_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clang/test/AST/gen_ast_dump_json_test.py b/clang/test/AST/gen_ast_dump_json_test.py index 87b3318..f783c79 100644 --- a/clang/test/AST/gen_ast_dump_json_test.py +++ b/clang/test/AST/gen_ast_dump_json_test.py @@ -180,7 +180,7 @@ def process_file(source_file, clang_binary, cmdline_filters, cmdline_opts, filter_json(j, filters, out_asts) - with tempfile.NamedTemporaryFile("w", delete=False) as f: + with tempfile.NamedTemporaryFile("wb", delete=False) as f: with open(source_file, "r") as srcf: for line in srcf.readlines(): # copy up to the note: -- 2.7.4