From bf2ee7bcdc9b94aa4c62f197adeb71bab20bcfa3 Mon Sep 17 00:00:00 2001 From: Georg Kotheimer Date: Wed, 24 Jul 2019 11:38:14 +0200 Subject: [PATCH] utils: Use cpu_to_fdt32() when writing to fdt Although it does not make a functional difference, both cpu_to_fdt32() and fdt32_to_cpu() pass on to CPU_TO_FDT32, we should use cpu_to_fdt32() to be semantically correct. Signed-off-by: Georg Kotheimer Reviewed-by: Atish Patra Acked-by: Anup Patel --- lib/utils/irqchip/plic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/utils/irqchip/plic.c b/lib/utils/irqchip/plic.c index 2cd055e..5dcbce0 100644 --- a/lib/utils/irqchip/plic.c +++ b/lib/utils/irqchip/plic.c @@ -68,7 +68,7 @@ void plic_fdt_fixup(void *fdt, const char *compat) for (i = 0; i < (cells_count / 2); i++) { if (fdt32_to_cpu(cells[2 * i + 1]) == IRQ_M_EXT) - cells[2 * i + 1] = fdt32_to_cpu(0xffffffff); + cells[2 * i + 1] = cpu_to_fdt32(0xffffffff); } } -- 2.7.4