From bf2a52fa2ac2c4486653993a765fd922b3cd64a6 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sun, 6 Nov 2016 21:25:22 -0700 Subject: [PATCH] Use gdbpy_ref in gdbpy_breakpoints This changes gdbpy_breakpoints to use gdbpy_ref. 2017-01-10 Tom Tromey * python/py-breakpoint.c (gdbpy_breakpoints): Use gdbpy_ref. --- gdb/ChangeLog | 4 ++++ gdb/python/py-breakpoint.c | 18 +++++------------- 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 330718a..e2cf5b9 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2017-01-10 Tom Tromey + * python/py-breakpoint.c (gdbpy_breakpoints): Use gdbpy_ref. + +2017-01-10 Tom Tromey + * python/py-inferior.c (gdbpy_inferiors): Use gdbpy_ref. 2017-01-10 Tom Tromey diff --git a/gdb/python/py-breakpoint.c b/gdb/python/py-breakpoint.c index c8847ff..eedb697 100644 --- a/gdb/python/py-breakpoint.c +++ b/gdb/python/py-breakpoint.c @@ -762,28 +762,20 @@ build_bp_list (struct breakpoint *b, void *arg) PyObject * gdbpy_breakpoints (PyObject *self, PyObject *args) { - PyObject *list, *tuple; - if (bppy_live == 0) return PyTuple_New (0); - list = PyList_New (0); - if (!list) + gdbpy_ref list (PyList_New (0)); + if (list == NULL) return NULL; /* If iterate_over_breakpoints returns non NULL it signals an error condition. In that case abandon building the list and return NULL. */ - if (iterate_over_breakpoints (build_bp_list, list) != NULL) - { - Py_DECREF (list); - return NULL; - } - - tuple = PyList_AsTuple (list); - Py_DECREF (list); + if (iterate_over_breakpoints (build_bp_list, list.get ()) != NULL) + return NULL; - return tuple; + return PyList_AsTuple (list.get ()); } /* Call the "stop" method (if implemented) in the breakpoint -- 2.7.4