From befb731be64a60b97f857d18eaa40d68f8ba792d Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Fri, 21 Oct 2022 10:53:24 +0200 Subject: [PATCH] [LLParser] Remove redundant remangling (NFCI) UpgradeCallsToIntrinsic() is already intended to perform remangling in case no other upgrades are necessary. The additional remangleIntrinsicFunction() calls are not needed and can hide bugs in the UpgradeCallsToIntrinsic() implementation. --- llvm/lib/AsmParser/LLParser.cpp | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/llvm/lib/AsmParser/LLParser.cpp b/llvm/lib/AsmParser/LLParser.cpp index 052f466..922d081 100644 --- a/llvm/lib/AsmParser/LLParser.cpp +++ b/llvm/lib/AsmParser/LLParser.cpp @@ -303,16 +303,6 @@ bool LLParser::validateEndOfModule(bool UpgradeDebugInfo) { for (Function &F : llvm::make_early_inc_range(*M)) UpgradeCallsToIntrinsic(&F); - // Some types could be renamed during loading if several modules are - // loaded in the same LLVMContext (LTO scenario). In this case we should - // remangle intrinsics names as well. - for (Function &F : llvm::make_early_inc_range(*M)) { - if (auto Remangled = Intrinsic::remangleIntrinsicFunction(&F)) { - F.replaceAllUsesWith(*Remangled); - F.eraseFromParent(); - } - } - if (UpgradeDebugInfo) llvm::UpgradeDebugInfo(*M); -- 2.7.4