From bd58e84b133d60dd34670c7bdc9c30b354e485c2 Mon Sep 17 00:00:00 2001
From: "hyeran74.kim" <hyeran74.kim@samsung.com>
Date: Fri, 12 Sep 2014 16:32:55 +0900
Subject: [PATCH] File : remove unnecessary sql query on the detail view

Change-Id: I84aced6e7f464c966db92276be6e7826b8a0002b
Signed-off-by: hyeran74.kim <hyeran74.kim@samsung.com>
---
 .../ui/file/FileDetailInfoView.java                | 19 +++++++++--
 .../dynamicanalyzer/ui/file/data/FileApiDB.java    | 38 +---------------------
 2 files changed, 17 insertions(+), 40 deletions(-)

diff --git a/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/ui/file/FileDetailInfoView.java b/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/ui/file/FileDetailInfoView.java
index 58949c1..4e7889e 100644
--- a/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/ui/file/FileDetailInfoView.java
+++ b/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/ui/file/FileDetailInfoView.java
@@ -139,6 +139,7 @@ public class FileDetailInfoView extends DAViewComposite {
 	}
 
 	private void updateData(FileSelectedData selectData) {
+		failedApiCount = 0;
 		List<FileEvent> events = null;
 		events = fileChartManager.getApiDB().selectAPITable(
 				selectData.getFilePath(), selectData.getPid(),
@@ -153,12 +154,27 @@ public class FileDetailInfoView extends DAViewComposite {
 			int apiCount = events.size();
 			for(FileEvent data : events) {
 				switch(data.getFdApiType()) {
+				case LogCenterConstants.FD_API_TYPE_OPEN:
+				case LogCenterConstants.FD_API_TYPE_CLOSE:
+				case LogCenterConstants.FD_API_TYPE_OTHERS:
+				case LogCenterConstants.FD_API_TYPE_LOCK_START:
+				case LogCenterConstants.FD_API_TYPE_LOCK_END:
+					if(data.getErrno() != 0) {
+						failedApiCount++;
+					}
+					break;
 				case LogCenterConstants.FD_API_TYPE_READ_END:
+					if(data.getErrno() != 0) {
+						failedApiCount++;
+					}
 					readSize += data.getSize();
 					// except *_end event among the API count
 					apiCount--;
 					break;
 				case LogCenterConstants.FD_API_TYPE_WRITE_END:
+					if(data.getErrno() != 0) {
+						failedApiCount++;
+					}
 					writeSize += data.getSize();
 					// except *_end event among the API count
 					apiCount--;
@@ -171,9 +187,6 @@ public class FileDetailInfoView extends DAViewComposite {
 			this.readSize = readSize;
 			this.writeSize = writeSize;
 		}
-		failedApiCount = fileChartManager.getApiDB().selectFailedAPI(
-				selectData.getFilePath(), selectData.getPid(),
-				selectData.getTid(), selectData.isParentChart());
 		canvas.redraw();
 	}
 
diff --git a/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/ui/file/data/FileApiDB.java b/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/ui/file/data/FileApiDB.java
index 8f66783..11c95a5 100644
--- a/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/ui/file/data/FileApiDB.java
+++ b/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/ui/file/data/FileApiDB.java
@@ -141,24 +141,6 @@ public class FileApiDB extends DBTable {
 			+ COLUMN.SEQ.getName()  + " = '%d'"+ " and "
 			+ COLUMN.TARGET.getName() + " = 'true'";
 	
-	private static final String SELECT_FAILED_APIS_FOR_CHAILD = "select "
-			+ selectAllColumn
-			+ " from "
-			+ TABLE_NAME + " where " 
-			+ COLUMN.FILE_PATH.getName() + " = '%s'" + " and "
-			+ COLUMN.PID.getName() + " = '%d'" + " and "
-			+ COLUMN.TID.getName() + " = '%d'" + " and "
-			+ COLUMN.ERRNO.getName() + " != '0'" + " and "
-			+ COLUMN.TARGET.getName() + " = 'true'";
-	
-	private static final String SELECT_FAILED_APIS_FOR_PARENT = "select "
-			+ selectAllColumn
-			+ " from "
-			+ TABLE_NAME + " where " 
-			+ COLUMN.FILE_PATH.getName() + " = '%s'" + " and "
-			+ COLUMN.ERRNO.getName() + " != '0'" + " and "
-			+ COLUMN.TARGET.getName() + " = 'true'";
-	
 	private static final String SELECT_ALL = "select "
 			+ selectAllColumn
 			+ " from "
@@ -189,7 +171,7 @@ public class FileApiDB extends DBTable {
 	}
 	
 	// for updating api series chart
-		public List<FileEvent> selectFailedAPISeries(double visibleStartTime,
+	public List<FileEvent> selectFailedAPISeries(double visibleStartTime,
 			double visibleEndTime) {
 		double selectStartTime = visibleStartTime
 				* TimelineConstants.MEGA_DOUBLE;
@@ -228,24 +210,6 @@ public class FileApiDB extends DBTable {
 		return apiList;
 	}
 
-	public int selectFailedAPI(String filePath, int pid, int tid,
-			boolean isParentChart) {
-		String query = String.format(SELECT_FAILED_APIS_FOR_CHAILD, filePath, pid, tid);
-		if (isParentChart) {
-			query = String
-					.format(SELECT_FAILED_APIS_FOR_PARENT, filePath);
-		}
-		List<List<Object>> result = SqlConnectionManager.executeQuery(query);
-		if (null == result || result.size() == 0 || result.get(0).size() == 0) {
-			return 0;
-		}
-		List<FileEvent> apiList = new ArrayList<FileEvent>();
-		for (List<Object> data : result) {
-			apiList.add(new FileEvent(data));
-		}
-		return apiList.size();
-	}
-	
 	public List<FileEvent> selectFileEventBySeq(long seq) {
 		String query = String.format(SELECT_FILE_EVENT_BY_SEQ, seq);
 		List<List<Object>> result = SqlConnectionManager.executeQuery(query);
-- 
2.7.4