From bd3c7b9ef7ff26d541393e6c3e985b1c72c277c3 Mon Sep 17 00:00:00 2001 From: Andrey Utkin Date: Tue, 15 Jul 2014 01:56:21 +0300 Subject: [PATCH] drivers/platform/x86/thinkpad_acpi.c: don't test unsigned int for negativity Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80231 Reported-by: David Binderman Signed-off-by: Andrey Utkin Signed-off-by: Matthew Garrett --- drivers/platform/x86/thinkpad_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 0fefb24..61e8ff0 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -6144,7 +6144,7 @@ static int brightness_set(unsigned int value) { int res; - if (value > bright_maxlvl || value < 0) + if (value > bright_maxlvl) return -EINVAL; vdbg_printk(TPACPI_DBG_BRGHT, -- 2.7.4