From bd351effcdb5cf55b72defcdccad905baf1f2d52 Mon Sep 17 00:00:00 2001 From: Tobias Grosser Date: Thu, 3 Aug 2017 04:17:58 +0000 Subject: [PATCH] [unittest] Remove TODO comment which caused concern Remove the second part of the TODO comment that highlighted an issue with possibly connecting all nodes to the exit of the CFG. This caused concerns with Jakub Kuderski regarding its feasability, hence we remove it. Such points are better discussed outside of CFG. If connecting all nodes makes sense and what the impact is is currently part of an active review discussion. llvm-svn: 309919 --- llvm/unittests/IR/DominatorTreeTest.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/llvm/unittests/IR/DominatorTreeTest.cpp b/llvm/unittests/IR/DominatorTreeTest.cpp index da5d502..ed8053e 100644 --- a/llvm/unittests/IR/DominatorTreeTest.cpp +++ b/llvm/unittests/IR/DominatorTreeTest.cpp @@ -454,7 +454,7 @@ TEST(DominatorTree, DeletingEdgesIntroducesUnreachables) { // PDT. We also verify this property. // // TODO: Can we change the PDT definition such that C remains part of the -// CFG, at best without loosing the dominance relation D postdom B. +// CFG? TEST(DominatorTree, DeletingEdgesIntroducesInfiniteLoop) { StringRef ModuleString = "define void @f() {\n" -- 2.7.4