From bcb89a6b68b272f1604e1748bb4f2028f33636b7 Mon Sep 17 00:00:00 2001 From: "yurys@chromium.org" Date: Mon, 27 Oct 2014 12:10:19 +0000 Subject: [PATCH] Make all references from root shortcuts (except one to GC roots) Eventually we are going to nuke this shortcuts from root entry altogether. This fix makes (GC roots) retained size equal to the snapshot's total size. BUG=chromium:414190 LOG=N R=loislo@chromium.org, yangguo@chromium.org Review URL: https://codereview.chromium.org/681743002 Cr-Commit-Position: refs/heads/master@{#24902} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24902 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/heap-snapshot-generator.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/heap-snapshot-generator.cc b/src/heap-snapshot-generator.cc index 680e1cc..6b93f71 100644 --- a/src/heap-snapshot-generator.cc +++ b/src/heap-snapshot-generator.cc @@ -2517,10 +2517,8 @@ void NativeObjectsExplorer::SetRootNativeRootsReference() { HeapEntry* group_entry = filler_->FindOrAddEntry(group_info, native_entries_allocator_); DCHECK(group_entry != NULL); - filler_->SetIndexedAutoIndexReference( - HeapGraphEdge::kElement, - snapshot_->root()->index(), - group_entry); + filler_->SetNamedAutoIndexReference( + HeapGraphEdge::kShortcut, snapshot_->root()->index(), group_entry); } } -- 2.7.4