From bca2b14a59aa9928e471f719906ca6b0cf6004ab Mon Sep 17 00:00:00 2001
From: Peiming Liu <peiming@google.com>
Date: Fri, 21 Oct 2022 23:21:53 +0000
Subject: [PATCH] [mlir][sparse] fix bufferizableOpInterface for InsertOp

Address comments in D136372

Reviewed By: aartbik, springerm

Differential Revision: https://reviews.llvm.org/D136510
---
 .../SparseTensor/Transforms/BufferizableOpInterfaceImpl.cpp  | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/mlir/lib/Dialect/SparseTensor/Transforms/BufferizableOpInterfaceImpl.cpp b/mlir/lib/Dialect/SparseTensor/Transforms/BufferizableOpInterfaceImpl.cpp
index 7c16cf6..6de3957 100644
--- a/mlir/lib/Dialect/SparseTensor/Transforms/BufferizableOpInterfaceImpl.cpp
+++ b/mlir/lib/Dialect/SparseTensor/Transforms/BufferizableOpInterfaceImpl.cpp
@@ -97,14 +97,9 @@ struct NewOpInterface
 struct InsertOpInterface
     : public BufferizableOpInterface::ExternalModel<InsertOpInterface,
                                                     sparse_tensor::InsertOp> {
-  bool bufferizesToAllocation(Operation *op, OpResult opResult) const {
-    // Does bufferization handle realloc?
-    return false;
-  }
-
   bool bufferizesToMemoryRead(Operation *op, OpOperand &opOperand,
                               const AnalysisState &state) const {
-    return false;
+    return true;
   }
 
   bool bufferizesToMemoryWrite(Operation *op, OpOperand &opOperand,
@@ -126,11 +121,6 @@ struct InsertOpInterface
     // aliases).
     return BufferRelation::Equivalent;
   }
-
-  bool isWritable(Operation *op, Value value,
-                  const AnalysisState &state) const {
-    return true;
-  }
 };
 
 } // namespace
-- 
2.7.4