From bc956b47e5a5f824f2a951c372839fdd0ee3e53b Mon Sep 17 00:00:00 2001 From: akallabeth Date: Sat, 27 Feb 2021 08:30:01 +0100 Subject: [PATCH] Added explicit warnings for experimental/unstable features --- CMakeLists.txt | 8 ++++---- cmake/ConfigOptions.cmake | 12 ++++++------ 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index c22db2d..62c9fe2 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -705,7 +705,7 @@ set(FFMPEG_FEATURE_DESCRIPTION "multimedia redirection, audio and video playback set(VAAPI_FEATURE_TYPE "OPTIONAL") set(VAAPI_FEATURE_PURPOSE "multimedia") -set(VAAPI_FEATURE_DESCRIPTION "VA-API hardware acceleration for video playback") +set(VAAPI_FEATURE_DESCRIPTION "[experimental] VA-API hardware acceleration for video playback") set(IPP_FEATURE_TYPE "OPTIONAL") set(IPP_FEATURE_PURPOSE "performance") @@ -725,7 +725,7 @@ set(OPENH264_FEATURE_DESCRIPTION "use OpenH264 library") set(OPENCL_FEATURE_TYPE "OPTIONAL") set(OPENCL_FEATURE_PURPOSE "codec") -set(OPENCL_FEATURE_DESCRIPTION "use OpenCL library") +set(OPENCL_FEATURE_DESCRIPTION "[experimental] use OpenCL library") set(GSM_FEATURE_TYPE "OPTIONAL") set(GSM_FEATURE_PURPOSE "codec") @@ -741,7 +741,7 @@ set(FAAD2_FEATURE_DESCRIPTION "FAAD2 AAC audio codec library") set(FAAC_FEATURE_TYPE "OPTIONAL") set(FAAC_FEATURE_PURPOSE "codec") -set(FAAC_FEATURE_DESCRIPTION "FAAC AAC audio codec library") +set(FAAC_FEATURE_DESCRIPTION "[experimental] FAAC AAC audio codec library") set(SOXR_FEATURE_TYPE "OPTIONAL") set(SOXR_FEATURE_PURPOSE "codec") @@ -749,7 +749,7 @@ set(SOXR_FEATURE_DESCRIPTION "SOX audio resample library") set(GSSAPI_FEATURE_TYPE "OPTIONAL") set(GSSAPI_FEATURE_PURPOSE "auth") -set(GSSAPI_FEATURE_DESCRIPTION "add kerberos support") +set(GSSAPI_FEATURE_DESCRIPTION "[experimental] add kerberos support") if(WIN32) set(X11_FEATURE_TYPE "DISABLED") diff --git a/cmake/ConfigOptions.cmake b/cmake/ConfigOptions.cmake index 44e7dcc..c6f0cb9 100644 --- a/cmake/ConfigOptions.cmake +++ b/cmake/ConfigOptions.cmake @@ -114,23 +114,23 @@ option(WITH_DEBUG_CLIPRDR "Print clipboard redirection debug messages" ${DEFAULT option(WITH_DEBUG_RDPGFX "Print RDPGFX debug messages" ${DEFAULT_DEBUG_OPTION}) option(WITH_DEBUG_DVC "Print dynamic virtual channel debug messages." ${DEFAULT_DEBUG_OPTION}) CMAKE_DEPENDENT_OPTION(WITH_DEBUG_TSMF "Print TSMF virtual channel debug messages." ${DEFAULT_DEBUG_OPTION} "CHANNEL_TSMF" OFF) -option(WITH_DEBUG_KBD "Print keyboard related debug messages." ${DEFAULT_DEBUG_OPTION}) +option(WITH_DEBUG_KBD "Print keyboard related debug messages." OFF) if(WITH_DEBUG_KBD) message(WARNING "WITH_DEBUG_KBD=ON, the build might leak sensitive information, do not use with release builds!") endif() -option(WITH_DEBUG_LICENSE "Print license debug messages." ${DEFAULT_DEBUG_OPTION}) +option(WITH_DEBUG_LICENSE "Print license debug messages." OFF) if(WITH_DEBUG_LICENSE) message(WARNING "WITH_DEBUG_LICENSE=ON, the build might leak sensitive information, do not use with release builds!") endif() -option(WITH_DEBUG_NEGO "Print negotiation related debug messages." ${DEFAULT_DEBUG_OPTION}) +option(WITH_DEBUG_NEGO "Print negotiation related debug messages." OFF) if(WITH_DEBUG_NEGO) message(WARNING "WITH_DEBUG_NEGO=ON, the build might leak sensitive information, do not use with release builds!") endif() -option(WITH_DEBUG_NLA "Print authentication related debug messages." ${DEFAULT_DEBUG_OPTION}) +option(WITH_DEBUG_NLA "Print authentication related debug messages." OFF) if(WITH_DEBUG_NLA) message(WARNING "WITH_DEBUG_NLA=ON, the build might leak sensitive information, do not use with release builds!") endif() -option(WITH_DEBUG_NTLM "Print NTLM debug messages" ${DEFAULT_DEBUG_OPTION}) +option(WITH_DEBUG_NTLM "Print NTLM debug messages" OFF) if(WITH_DEBUG_NTLM) message(WARNING "WITH_DEBUG_NTLM=ON, the build might leak sensitive information, do not use with release builds!") endif() @@ -164,7 +164,7 @@ option(WITH_GSSAPI "Compile support for kerberos authentication. (EXPERIMENTAL)" option(WITH_DSP_EXPERIMENTAL "Enable experimental sound encoder/decoder formats" OFF) if (WITH_FFMPEG) option(WITH_DSP_FFMPEG "Use FFMPEG for audio encoding/decoding" OFF) - option(WITH_VAAPI "Use FFMPEG VAAPI" OFF) + option(WITH_VAAPI "Use FFMPEG VAAPI (EXPERIMENTAL)" OFF) endif(WITH_FFMPEG) option(USE_VERSION_FROM_GIT_TAG "Extract FreeRDP version from git tag." OFF) -- 2.7.4