From bc66982deb57e773bac962fc795bbb249b5416b4 Mon Sep 17 00:00:00 2001 From: "jiyong.min" Date: Mon, 10 Feb 2020 12:22:07 +0900 Subject: [PATCH] Fix coverity issue - Resource leak Change-Id: I3badedd37896e0fb8352be42be9f4b153e74f6b7 --- packaging/capi-media-thumbnail-util.spec | 2 +- src/thumbnail_util.c | 2 +- test/thumbnail_util_test.c | 4 ++++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packaging/capi-media-thumbnail-util.spec b/packaging/capi-media-thumbnail-util.spec index 3404f27..dac4aa0 100755 --- a/packaging/capi-media-thumbnail-util.spec +++ b/packaging/capi-media-thumbnail-util.spec @@ -1,6 +1,6 @@ Name: capi-media-thumbnail-util Summary: A media thumbnail util library in Tizen Native API -Version: 0.1.19 +Version: 0.1.20 Release: 1 Group: Multimedia/API License: Apache-2.0 diff --git a/src/thumbnail_util.c b/src/thumbnail_util.c index 676b4ad..88e4292 100644 --- a/src/thumbnail_util.c +++ b/src/thumbnail_util.c @@ -87,7 +87,7 @@ void __thumbnail_util_extract_completed_cb(int error, int request_id, const char __thumbnail_util_convert_itoa(request_id, &request_id_str); if (_thumb_cb->thumb_extract_cb) _thumb_cb->thumb_extract_cb(__thumbnail_util_error_capi(error), request_id_str, thumb_width, thumb_height, thumb_data, thumb_size, _thumb_cb->user_data); - + SAFE_FREE(request_id_str); } SAFE_FREE(_thumb_cb); } diff --git a/test/thumbnail_util_test.c b/test/thumbnail_util_test.c index dd86720..e94c6ad 100644 --- a/test/thumbnail_util_test.c +++ b/test/thumbnail_util_test.c @@ -118,6 +118,10 @@ gboolean cancel_all(gpointer data) thumbnail_util_debug("thumbnail_util_cancel[%d] is success", i); else thumbnail_util_error("thumbnail_util_cancel[%d] is failed", i); + if (req_str) { + free(req_str); + req_str = NULL; + } } thumbnail_util_destroy(_media_thumb); -- 2.7.4