From bc22b18b1f805dd785c408060f21aecb4c500ea5 Mon Sep 17 00:00:00 2001 From: Jules Irenge Date: Mon, 6 Apr 2020 20:08:30 -0700 Subject: [PATCH] mm/zsmalloc: add missing annotation for unpin_tag() Sparse reports a warning at unpin_tag()() warning: context imbalance in unpin_tag() - unexpected unlock The root cause is the missing annotation at unpin_tag() Add the missing __releases(bitlock) annotation Signed-off-by: Jules Irenge Signed-off-by: Andrew Morton Acked-by: Minchan Kim Link: http://lkml.kernel.org/r/20200214204741.94112-14-jbi.octave@gmail.com Signed-off-by: Linus Torvalds --- mm/zsmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 7bac76ae11b3..2aa2d524a343 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -896,7 +896,7 @@ static void pin_tag(unsigned long handle) __acquires(bitlock) bit_spin_lock(HANDLE_PIN_BIT, (unsigned long *)handle); } -static void unpin_tag(unsigned long handle) +static void unpin_tag(unsigned long handle) __releases(bitlock) { bit_spin_unlock(HANDLE_PIN_BIT, (unsigned long *)handle); } -- 2.34.1