From bbe1394c9602ab9a939d9b17199d5f538cac9d0c Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Tue, 22 Jan 2013 17:00:09 +0000 Subject: [PATCH] Fix a bug in VarDecl::getSourceRange() for static member arrays with an element type with an implicit initializer expression. Patch from Will Wilson ! llvm-svn: 173170 --- clang/lib/AST/Decl.cpp | 4 +++- clang/test/SemaCXX/sourceranges.cpp | 5 ++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/clang/lib/AST/Decl.cpp b/clang/lib/AST/Decl.cpp index c053b6d..7a51814 100644 --- a/clang/lib/AST/Decl.cpp +++ b/clang/lib/AST/Decl.cpp @@ -1206,7 +1206,9 @@ void VarDecl::setStorageClass(StorageClass SC) { SourceRange VarDecl::getSourceRange() const { if (const Expr *Init = getInit()) { SourceLocation InitEnd = Init->getLocEnd(); - if (InitEnd.isValid()) + // If Init is implicit, ignore its source range and fallback on + // DeclaratorDecl::getSourceRange() to handle postfix elements. + if (InitEnd.isValid() && InitEnd != getLocation()) return SourceRange(getOuterLocStart(), InitEnd); } return DeclaratorDecl::getSourceRange(); diff --git a/clang/test/SemaCXX/sourceranges.cpp b/clang/test/SemaCXX/sourceranges.cpp index 0537aa2..1f25d5b 100644 --- a/clang/test/SemaCXX/sourceranges.cpp +++ b/clang/test/SemaCXX/sourceranges.cpp @@ -7,11 +7,14 @@ class P { }; namespace foo { -class A {}; +class A { public: A() {} }; enum B {}; typedef int C; } +// CHECK: VarDecl {{0x[0-9a-fA-F]+}} ImplicitConstrArray 'foo::A [2]' +static foo::A ImplicitConstrArray[2]; + int main() { // CHECK: CXXNewExpr {{0x[0-9a-fA-F]+}} 'foo::A *' P p14 = new foo::A; -- 2.7.4