From bb7c2ee37c46e6f1d75a4c4ba5e37209e4b9bf7b Mon Sep 17 00:00:00 2001 From: Marc Hoersken Date: Tue, 5 Feb 2013 22:02:45 +0100 Subject: [PATCH] schannel: Removed extended error connection setup flag According KB975858 this flag may cause problems on Windows 7 and Windows Server 2008 R2 systems. Extended error information is not currently used by libcurl and therefore not a requirement. The flag may improve the SSL-connection shutdown in case of an error. This means it might be a good improvement in the future. Fixes bug/issue #1187 - thanks for the report --- lib/curl_schannel.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/curl_schannel.c b/lib/curl_schannel.c index b71d8d4..a615f57 100644 --- a/lib/curl_schannel.c +++ b/lib/curl_schannel.c @@ -5,9 +5,9 @@ * | (__| |_| | _ <| |___ * \___|\___/|_| \_\_____| * - * Copyright (C) 2012, Marc Hoersken, , et al. + * Copyright (C) 2012 - 2013, Marc Hoersken, * Copyright (C) 2012, Mark Salisbury, - * Copyright (C) 2012, Daniel Stenberg, , et al. + * Copyright (C) 2012 - 2013, Daniel Stenberg, , et al. * * This software is licensed as described in the file COPYING, which * you should have received as part of this distribution. The terms @@ -219,8 +219,8 @@ schannel_connect_step1(struct connectdata *conn, int sockindex) /* setup request flags */ connssl->req_flags = ISC_REQ_SEQUENCE_DETECT | ISC_REQ_REPLAY_DETECT | - ISC_REQ_CONFIDENTIALITY | ISC_REQ_EXTENDED_ERROR | - ISC_REQ_ALLOCATE_MEMORY | ISC_REQ_STREAM; + ISC_REQ_CONFIDENTIALITY | ISC_REQ_ALLOCATE_MEMORY | + ISC_REQ_STREAM; /* allocate memory for the security context handle */ connssl->ctxt = malloc(sizeof(struct curl_schannel_ctxt)); @@ -503,8 +503,6 @@ schannel_connect_step3(struct connectdata *conn, int sockindex) failf(data, "schannel: failed to setup replay detection"); if(!(connssl->ret_flags & ISC_RET_CONFIDENTIALITY)) failf(data, "schannel: failed to setup confidentiality"); - if(!(connssl->ret_flags & ISC_RET_EXTENDED_ERROR)) - failf(data, "schannel: failed to setup extended errors"); if(!(connssl->ret_flags & ISC_RET_ALLOCATED_MEMORY)) failf(data, "schannel: failed to setup memory allocation"); if(!(connssl->ret_flags & ISC_RET_STREAM)) -- 2.7.4