From bb351cf437f586ee90ce66ccc4a23da25a3b2364 Mon Sep 17 00:00:00 2001 From: Sam Muhammed Date: Sun, 22 Mar 2020 07:50:51 -0400 Subject: [PATCH] Staging: hp: Use netdev_warn(). This replaces printk(KERN_WARNING ..) with netdev_warn(), as the use of printk() isn't preferred when a struct net_device is available. Signed-off-by: Sam Muhammed Acked-by: Julia Lawall Link: https://lore.kernel.org/r/20200322115051.2767-1-jane.pnx9@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/hp/hp100.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c index b89c4dc..c1f5506 100644 --- a/drivers/staging/hp/hp100.c +++ b/drivers/staging/hp/hp100.c @@ -469,8 +469,8 @@ static int hp100_probe1(struct net_device *dev, int ioaddr, u_char bus, eid = hp100_read_id(ioaddr); if (eid == NULL) { /* bad checksum? */ - printk(KERN_WARNING "%s: bad ID checksum at base port 0x%x\n", - __func__, ioaddr); + netdev_warn(dev, "bad ID checksum at base port 0x%x\n", + ioaddr); goto out2; } @@ -478,9 +478,9 @@ static int hp100_probe1(struct net_device *dev, int ioaddr, u_char bus, for (i = uc = 0; i < 7; i++) uc += hp100_inb(LAN_ADDR + i); if (uc != 0xff) { - printk(KERN_WARNING - "%s: bad lan address checksum at port 0x%x)\n", - __func__, ioaddr); + netdev_warn(dev, + "bad lan address checksum at port 0x%x)\n", + ioaddr); err = -EIO; goto out2; } -- 2.7.4