From bb03e613e64ec996e5d1109519a069a5b8134bb2 Mon Sep 17 00:00:00 2001 From: Tony Cook Date: Fri, 27 Jul 2012 23:38:59 +1000 Subject: [PATCH] fix the cygwin breakage introduced in 2f794ae1 All modern Win32 systems* require admin access to use ICMP sockets from cygwin, the refactor in 2f794ae1 changed the condition for the skip, producing a failure here when the test is run unprivileged under cygwin. * assuming XP can be called modern --- dist/Net-Ping/t/500_ping_icmp.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dist/Net-Ping/t/500_ping_icmp.t b/dist/Net-Ping/t/500_ping_icmp.t index 9fe6877..4bc9709 100644 --- a/dist/Net-Ping/t/500_ping_icmp.t +++ b/dist/Net-Ping/t/500_ping_icmp.t @@ -16,7 +16,7 @@ BEGIN {use_ok('Net::Ping')}; SKIP: { skip "icmp ping requires root privileges.", 1 if ($> and $^O ne 'VMS' and $^O ne 'cygwin') - or ($^O eq 'MSWin32' + or (($^O eq 'MSWin32' or $^O eq 'cygwin') and !IsAdminUser()) or ($^O eq 'VMS' and (`write sys\$output f\$privilege("SYSPRV")` =~ m/FALSE/)); -- 2.7.4