From ba8651d474d09bead393cc81b139607210374bb8 Mon Sep 17 00:00:00 2001 From: Yaowu Xu Date: Tue, 24 May 2016 10:49:30 -0700 Subject: [PATCH] Fix comments in build_intra_predictors_high() 1. Removed TODOs, no longer applicable to finalized vp9 profiles. 2. Added explanation on assumed values for highbitdepth profiles. Change-Id: I59e0bebaaab900cc611ed284daa5fa0bdedb8097 --- vp9/common/vp9_reconintra.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/vp9/common/vp9_reconintra.c b/vp9/common/vp9_reconintra.c index c4d91c8..4457858 100644 --- a/vp9/common/vp9_reconintra.c +++ b/vp9/common/vp9_reconintra.c @@ -142,6 +142,7 @@ static void build_intra_predictors_high(const MACROBLOCKD *xd, // 129 C D .. W X // 129 E F .. U V // 129 G H .. S T T T T T + // For 10 bit and 12 bit, 127 and 129 are replaced by base -1 and base + 1. // Get current frame pointer, width and height. if (plane == 0) { @@ -177,7 +178,6 @@ static void build_intra_predictors_high(const MACROBLOCKD *xd, left_col[i] = ref[i * ref_stride - 1]; } } else { - // TODO(Peter): this value should probably change for high bitdepth vpx_memset16(left_col, base + 1, bs); } } @@ -239,7 +239,6 @@ static void build_intra_predictors_high(const MACROBLOCKD *xd, vpx_memset16(above_row + r, above_row[r - 1], x0 + 2 * bs - frame_width); } - // TODO(Peter) this value should probably change for high bitdepth above_row[-1] = left_available ? above_ref[-1] : (base + 1); } else { /* faster path if the block does not need extension */ @@ -251,13 +250,11 @@ static void build_intra_predictors_high(const MACROBLOCKD *xd, memcpy(above_row + bs, above_ref + bs, bs * sizeof(above_row[0])); else vpx_memset16(above_row + bs, above_row[bs - 1], bs); - // TODO(Peter): this value should probably change for high bitdepth above_row[-1] = left_available ? above_ref[-1] : (base + 1); } } } else { vpx_memset16(above_row, base - 1, bs * 2); - // TODO(Peter): this value should probably change for high bitdepth above_row[-1] = base - 1; } } -- 2.7.4