From ba6ec4b70bc49bf8b65b59f64b43df4df3fe786e Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 29 Apr 2015 16:52:17 +0000 Subject: [PATCH] Temporarily relax a check in the debug info verifier. The clang frontend helps out GDB by emitting the members of local anonymous unions as artificial local variables with shared storage. When SROA splits the storage for artificial local variables that are smaller than the entire union, the overhang piece will be outside of the allotted space for the variable and this check fails. rdar://problem/20730771 llvm-svn: 236124 --- llvm/lib/IR/Verifier.cpp | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/llvm/lib/IR/Verifier.cpp b/llvm/lib/IR/Verifier.cpp index 3ccc48e3ffd2..1e1c4942576c 100644 --- a/llvm/lib/IR/Verifier.cpp +++ b/llvm/lib/IR/Verifier.cpp @@ -3478,6 +3478,15 @@ void Verifier::verifyBitPieceExpression(const DbgInfoIntrinsic &I, if (!E->isBitPiece()) return; + // The frontend helps out GDB by emitting the members of local anonymous + // unions as artificial local variables with shared storage. When SROA splits + // the storage for artificial local variables that are smaller than the entire + // union, the overhang piece will be outside of the allotted space for the + // variable and this check fails. + // FIXME: Remove this check as soon as clang stops doing this; it hides bugs. + if (V->isArtificial()) + return; + // If there's no size, the type is broken, but that should be checked // elsewhere. uint64_t VarSize = getVariableSize(*V, TypeRefs); -- 2.34.1