From ba37e4f9c860207256170a192966526ce795bba2 Mon Sep 17 00:00:00 2001 From: "machenbach@chromium.org" Date: Wed, 16 Jul 2014 09:54:34 +0000 Subject: [PATCH] Properly escape benchmark names when retrieving results. This allows benchmarks to contain regular expression characters in their name. BUG= R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/396203003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22428 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- tools/run_benchmarks.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/run_benchmarks.py b/tools/run_benchmarks.py index 4c72eeb..d6e9145 100755 --- a/tools/run_benchmarks.py +++ b/tools/run_benchmarks.py @@ -192,14 +192,14 @@ class Graph(Node): # TODO(machenbach): Currently that makes only sense for the leaf level. # Multiple place holders for multiple levels are not supported. if parent.results_regexp: - regexp_default = parent.results_regexp % suite["name"] + regexp_default = parent.results_regexp % re.escape(suite["name"]) else: regexp_default = None self.results_regexp = suite.get("results_regexp", regexp_default) # A similar regular expression for the standard deviation (optional). if parent.stddev_regexp: - stddev_default = parent.stddev_regexp % suite["name"] + stddev_default = parent.stddev_regexp % re.escape(suite["name"]) else: stddev_default = None self.stddev_regexp = suite.get("stddev_regexp", stddev_default) -- 2.7.4