From ba11d53cc1d209c1735b82c85467a1927cbd7b2b Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Fri, 17 May 2019 03:39:21 +0200 Subject: [PATCH] Use Arcade DotNetTool and NuGetPackageRoot (dotnet/corefx#37647) * Use Arcade props * Use global dotnet if applicable Commit migrated from https://github.com/dotnet/corefx/commit/f42e04b8d4be76b1818cf263ff06234d0e25ada0 --- eng/Packaging.props | 2 +- eng/publish.proj | 2 +- ...ystem.ComponentModel.TypeConverter.Tests.csproj | 2 +- .../tests/System.Drawing.Common.Tests.csproj | 12 ++-- .../System.IO.Compression.Brotli.Tests.csproj | 2 +- .../System.IO.Compression.ZipFile.Tests.csproj | 2 +- .../tests/System.IO.Compression.Tests.csproj | 2 +- .../tests/System.IO.Packaging.Tests.csproj | 2 +- .../System.Net.Http.Functional.Tests.csproj | 2 +- .../System.Net.Security.Tests.csproj | 2 +- .../System.Net.WebSockets.Client.Tests.csproj | 2 +- .../tests/System.Resources.Extensions.Tests.csproj | 2 +- .../System.Runtime.WindowsRuntime.UI.Xaml.pkgproj | 2 +- .../pkg/System.Runtime.WindowsRuntime.pkgproj | 2 +- ...rity.Cryptography.X509Certificates.Tests.csproj | 2 +- .../tests/System.Windows.Extensions.Tests.csproj | 4 +- src/libraries/external/ILLink/ILLink.depproj | 4 +- src/libraries/external/netfx/netfx.depproj | 2 +- .../external/netstandard/netstandard.depproj | 4 +- .../external/test-runtime/XUnit.Runtime.depproj | 70 +++++++++++----------- .../Microsoft.Private.PackageBaseline.pkgproj | 4 +- src/libraries/pkg/frameworkPackage.targets | 2 +- src/libraries/pkg/test/testPackages.proj | 2 +- 23 files changed, 66 insertions(+), 66 deletions(-) diff --git a/eng/Packaging.props b/eng/Packaging.props index b87e77a..e0db02c 100644 --- a/eng/Packaging.props +++ b/eng/Packaging.props @@ -14,7 +14,7 @@ Microsoft.Private.Intellisense 3.0.0-preview3-190305-0 - $(PackagesDir)$(XmlDocPackage.ToLowerInvariant())/$(XmlDocPackageVersion)/xmldocs/netcoreapp + $(NuGetPackageRoot)$(XmlDocPackage.ToLowerInvariant())/$(XmlDocPackageVersion)/xmldocs/netcoreapp $(ArtifactsBinDir)docs diff --git a/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj b/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj index 50be085..8c4a027 100644 --- a/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj +++ b/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj @@ -153,7 +153,7 @@ - + %(RecursiveDir)%(Filename)%(Extension) diff --git a/src/libraries/System.Drawing.Common/tests/System.Drawing.Common.Tests.csproj b/src/libraries/System.Drawing.Common/tests/System.Drawing.Common.Tests.csproj index c8e1f60..0c58d6a 100644 --- a/src/libraries/System.Drawing.Common/tests/System.Drawing.Common.Tests.csproj +++ b/src/libraries/System.Drawing.Common/tests/System.Drawing.Common.Tests.csproj @@ -86,22 +86,22 @@ - + %(RecursiveDir)%(Filename)%(Extension) - + System.Drawing.Tests.48x48_multiple_entries_4bit.ico - + System.Drawing.Tests.bitmap_173x183_indexed_8bit.bmp - + System.Drawing.Tests.empty.file - + System.Drawing.Tests.invalid.ico - + System.Drawing.Tests.Icon_toolboxBitmapAttributeTest diff --git a/src/libraries/System.IO.Compression.Brotli/tests/System.IO.Compression.Brotli.Tests.csproj b/src/libraries/System.IO.Compression.Brotli/tests/System.IO.Compression.Brotli.Tests.csproj index 5b8b48c..c740b70 100644 --- a/src/libraries/System.IO.Compression.Brotli/tests/System.IO.Compression.Brotli.Tests.csproj +++ b/src/libraries/System.IO.Compression.Brotli/tests/System.IO.Compression.Brotli.Tests.csproj @@ -28,7 +28,7 @@ - + %(RecursiveDir)%(Filename)%(Extension) diff --git a/src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj b/src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj index eff9402..24454eb 100644 --- a/src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj +++ b/src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj @@ -38,7 +38,7 @@ - + %(RecursiveDir)%(Filename)%(Extension) diff --git a/src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj b/src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj index 3f15edd..cde91e5 100644 --- a/src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj +++ b/src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj @@ -49,7 +49,7 @@ - + %(RecursiveDir)%(Filename)%(Extension) diff --git a/src/libraries/System.IO.Packaging/tests/System.IO.Packaging.Tests.csproj b/src/libraries/System.IO.Packaging/tests/System.IO.Packaging.Tests.csproj index 0123dd7..bb45dae 100644 --- a/src/libraries/System.IO.Packaging/tests/System.IO.Packaging.Tests.csproj +++ b/src/libraries/System.IO.Packaging/tests/System.IO.Packaging.Tests.csproj @@ -7,6 +7,6 @@ - + \ No newline at end of file diff --git a/src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj b/src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj index e7b2d9f..80be752 100644 --- a/src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj +++ b/src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj @@ -172,7 +172,7 @@ - + diff --git a/src/libraries/System.Net.Security/tests/FunctionalTests/System.Net.Security.Tests.csproj b/src/libraries/System.Net.Security/tests/FunctionalTests/System.Net.Security.Tests.csproj index d60b476..fed636e 100644 --- a/src/libraries/System.Net.Security/tests/FunctionalTests/System.Net.Security.Tests.csproj +++ b/src/libraries/System.Net.Security/tests/FunctionalTests/System.Net.Security.Tests.csproj @@ -158,6 +158,6 @@ - + diff --git a/src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj b/src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj index 65f1f0f..1717d27 100644 --- a/src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj +++ b/src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj @@ -61,6 +61,6 @@ - + diff --git a/src/libraries/System.Resources.Extensions/tests/System.Resources.Extensions.Tests.csproj b/src/libraries/System.Resources.Extensions/tests/System.Resources.Extensions.Tests.csproj index e774f0d..922f23b 100644 --- a/src/libraries/System.Resources.Extensions/tests/System.Resources.Extensions.Tests.csproj +++ b/src/libraries/System.Resources.Extensions/tests/System.Resources.Extensions.Tests.csproj @@ -11,7 +11,7 @@ - + diff --git a/src/libraries/System.Runtime.WindowsRuntime/pkg/System.Runtime.WindowsRuntime.pkgproj b/src/libraries/System.Runtime.WindowsRuntime/pkg/System.Runtime.WindowsRuntime.pkgproj index 8a189e7..c20ee76 100644 --- a/src/libraries/System.Runtime.WindowsRuntime/pkg/System.Runtime.WindowsRuntime.pkgproj +++ b/src/libraries/System.Runtime.WindowsRuntime/pkg/System.Runtime.WindowsRuntime.pkgproj @@ -22,7 +22,7 @@ diff --git a/src/libraries/System.Security.Cryptography.X509Certificates/tests/System.Security.Cryptography.X509Certificates.Tests.csproj b/src/libraries/System.Security.Cryptography.X509Certificates/tests/System.Security.Cryptography.X509Certificates.Tests.csproj index aa37d9c..e132f60 100644 --- a/src/libraries/System.Security.Cryptography.X509Certificates/tests/System.Security.Cryptography.X509Certificates.Tests.csproj +++ b/src/libraries/System.Security.Cryptography.X509Certificates/tests/System.Security.Cryptography.X509Certificates.Tests.csproj @@ -128,6 +128,6 @@ - + diff --git a/src/libraries/System.Windows.Extensions/tests/System.Windows.Extensions.Tests.csproj b/src/libraries/System.Windows.Extensions/tests/System.Windows.Extensions.Tests.csproj index c400b12..93712ea 100644 --- a/src/libraries/System.Windows.Extensions/tests/System.Windows.Extensions.Tests.csproj +++ b/src/libraries/System.Windows.Extensions/tests/System.Windows.Extensions.Tests.csproj @@ -25,10 +25,10 @@ - + %(RecursiveDir)%(Filename)%(Extension) - + %(RecursiveDir)%(Filename)%(Extension) diff --git a/src/libraries/external/ILLink/ILLink.depproj b/src/libraries/external/ILLink/ILLink.depproj index 5049897..7f13db5 100644 --- a/src/libraries/external/ILLink/ILLink.depproj +++ b/src/libraries/external/ILLink/ILLink.depproj @@ -14,14 +14,14 @@ - + $(ILLinkTasksPackageId) $(ILLinkTasksPackageVersion) /netcoreapp2.0/ - + $(ILLinkTasksPackageId) $(ILLinkTasksPackageVersion) /net46/ diff --git a/src/libraries/external/netfx/netfx.depproj b/src/libraries/external/netfx/netfx.depproj index ccf87f9..cba9208 100644 --- a/src/libraries/external/netfx/netfx.depproj +++ b/src/libraries/external/netfx/netfx.depproj @@ -6,7 +6,7 @@ Reference NETStandard.Library.NETFramework 2.0.1-servicing-26011-01 - $(PackagesDir)$(NETStandardSupportPackageId.ToLower())\$(NETStandardSupportPackageVersion)\build + $(NuGetPackageRoot)$(NETStandardSupportPackageId.ToLower())\$(NETStandardSupportPackageVersion)\build true diff --git a/src/libraries/external/netstandard/netstandard.depproj b/src/libraries/external/netstandard/netstandard.depproj index 7e474bb..6c139d2 100644 --- a/src/libraries/external/netstandard/netstandard.depproj +++ b/src/libraries/external/netstandard/netstandard.depproj @@ -77,7 +77,7 @@ - <_NETStandard21RefFolder>$(PackagesDir)$(NETStandardLibraryPackageId.ToLower())\$(NETStandardLibraryPackageVersion)\build\netstandard2.1\ref + <_NETStandard21RefFolder>$(NuGetPackageRoot)$(NETStandardLibraryPackageId.ToLower())\$(NETStandardLibraryPackageVersion)\build\netstandard2.1\ref @@ -94,7 +94,7 @@ - <_NETStandardRefFolder>$(PackagesDir)$(NETStandardLibraryPackageId.ToLower())\$(NETStandardLibraryPackageVersion)\build\$(_NETStandardTFMFolder)\ref + <_NETStandardRefFolder>$(NuGetPackageRoot)$(NETStandardLibraryPackageId.ToLower())\$(NETStandardLibraryPackageVersion)\build\$(_NETStandardTFMFolder)\ref diff --git a/src/libraries/external/test-runtime/XUnit.Runtime.depproj b/src/libraries/external/test-runtime/XUnit.Runtime.depproj index 99ace03..817daa2 100644 --- a/src/libraries/external/test-runtime/XUnit.Runtime.depproj +++ b/src/libraries/external/test-runtime/XUnit.Runtime.depproj @@ -98,7 +98,7 @@ AfterTargets="AfterResolveReferences"> - + @@ -127,7 +127,7 @@ AfterTargets="AfterResolveReferences"> - $(PackagesDir)$(MicrosoftDotNetUapTestToolsPackageName)\$(MicrosoftDotNetUapTestToolsPackageVersion)\Tools\$(ArchGroup) + $(NuGetPackageRoot)$(MicrosoftDotNetUapTestToolsPackageName)\$(MicrosoftDotNetUapTestToolsPackageVersion)\Tools\$(ArchGroup) $(UAPToolsFolder.Replace('/', '\')) @@ -162,7 +162,7 @@ - <_microsoftNetTestSdkAssets Include="$(PackagesDir)$(MicrosoftNetTestSdkPackageName)\$(MicrosoftNETTestSdkPackageVersion)\build\$(TestSdkTFM)\*.*" /> + <_microsoftNetTestSdkAssets Include="$(NuGetPackageRoot)$(MicrosoftNetTestSdkPackageName)\$(MicrosoftNETTestSdkPackageVersion)\build\$(TestSdkTFM)\*.*" /> false $(MicrosoftNetTestSdkPackageName) @@ -171,7 +171,7 @@ + Text="Error: no assets for test sdk package were found under: $(NuGetPackageRoot)$(MicrosoftNetTestSdkPackageName)\$(MicrosoftNETTestSdkPackageVersion)\build\$(TestSdkTFM)\*.*" /> @@ -179,25 +179,25 @@ Condition="'$(TargetGroup)' == 'netcoreapp'" BeforeTargets="ResolveReferences"> - - - + + + - + false $(MicrosoftDotNetXUnitConsoleRunnerPackage) $(MicrosoftDotNetXUnitConsoleRunnerPackageVersion) - + false $(XUnitTestAdapterPackageId) $(XUnitPackageVersion) - + false $(TestPlatformHostPackageId) $(MicrosoftNETTestSdkPackageVersion) @@ -210,18 +210,18 @@ Condition="'$(TargetsUap)' == 'true'" BeforeTargets="ResolveReferences"> - - + + - + false $(XUnitTestAdapterPackageId) $(XUnitPackageVersion) - + false $(TestPlatformHostPackageId) $(MicrosoftNETTestSdkPackageVersion) @@ -234,18 +234,18 @@ Condition="'$(TargetsAot)' == 'true'" BeforeTargets="ResolveReferences"> - - + + - + false $(MicrosoftDotNetUapTestToolsPackageName) $(MicrosoftDotNetUapTestToolsPackageVersion) - + false xunit.runner.utility $(XUnitPackageVersion) @@ -258,19 +258,19 @@ Condition="'$(TargetGroup)' == 'netfx'" BeforeTargets="ResolveReferences"> - - + + - + false $(XUnitRunnerConsolePackageName) $(XUnitPackageVersion) - + false $(XUnitTestAdapterPackageId) $(XUnitPackageVersion) @@ -282,11 +282,11 @@ - + - + false $(MicrosoftDotNetRemoteExecutorPackage) $(MicrosoftDotNetRemoteExecutorPackageVersion) diff --git a/src/libraries/pkg/Microsoft.Private.PackageBaseline/Microsoft.Private.PackageBaseline.pkgproj b/src/libraries/pkg/Microsoft.Private.PackageBaseline/Microsoft.Private.PackageBaseline.pkgproj index b9bd433..52b3b65 100644 --- a/src/libraries/pkg/Microsoft.Private.PackageBaseline/Microsoft.Private.PackageBaseline.pkgproj +++ b/src/libraries/pkg/Microsoft.Private.PackageBaseline/Microsoft.Private.PackageBaseline.pkgproj @@ -30,10 +30,10 @@ $(UAPvNextTFM) - + netstandard2.0 - + net461 diff --git a/src/libraries/pkg/frameworkPackage.targets b/src/libraries/pkg/frameworkPackage.targets index 1c0abf1..c91d1eb 100644 --- a/src/libraries/pkg/frameworkPackage.targets +++ b/src/libraries/pkg/frameworkPackage.targets @@ -5,7 +5,7 @@ true 2.0 - $(PackagesDir)$(NETStandardLibraryPackageId.ToLower())\$(NETStandardLibraryPackageVersion)\build\netstandard$(NETStandardVersion)\ref + $(NuGetPackageRoot)$(NETStandardLibraryPackageId.ToLower())\$(NETStandardLibraryPackageVersion)\build\netstandard$(NETStandardVersion)\ref true true diff --git a/src/libraries/pkg/test/testPackages.proj b/src/libraries/pkg/test/testPackages.proj index 1937622..da1e0ec 100644 --- a/src/libraries/pkg/test/testPackages.proj +++ b/src/libraries/pkg/test/testPackages.proj @@ -40,7 +40,7 @@ - + $(TestToolsDir)%(RecursiveDir) -- 2.7.4