From b9fc4727cce8085d134b647eae1539fc3092f07e Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Mon, 31 Oct 2016 22:31:07 +0000 Subject: [PATCH] [CMake] Populate the build directory's framework This ensures that the Resources and clang headers are properly symlinked in LLDB's framework. This should fix the modules-related tests when building on Darwin with CMake if you are building a framework. I have another fix coming which gets them working on Darwin if you're building liblldb instead of a framework. llvm-svn: 285651 --- lldb/source/API/CMakeLists.txt | 12 +++++++++--- lldb/test/CMakeLists.txt | 5 +++++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/lldb/source/API/CMakeLists.txt b/lldb/source/API/CMakeLists.txt index 8b47495..b9e4fe9 100644 --- a/lldb/source/API/CMakeLists.txt +++ b/lldb/source/API/CMakeLists.txt @@ -140,16 +140,22 @@ if(LLDB_BUILD_FRAMEWORK) LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/${LLDB_FRAMEWORK_INSTALL_DIR} PUBLIC_HEADER "${public_headers}") + set(symlink_commands + COMMAND ${CMAKE_COMMAND} -E make_directory $ + COMMAND ${CMAKE_COMMAND} -E create_symlink ${LLDB_SOURCE_DIR}/include/lldb/API $/Headers + COMMAND ${CMAKE_COMMAND} -E create_symlink Versions/Current/Headers ${CMAKE_BINARY_DIR}/${LLDB_FRAMEWORK_INSTALL_DIR}/LLDB.framework/Headers + COMMAND ${CMAKE_COMMAND} -E create_symlink ${CMAKE_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX}/clang/${LLDB_VERSION} $/Resources/Clang + ) + # This works around a CMake bug where POST_BUILD steps are not applied to # framework targets. This fix is merged into the CMake release branch and # should be available with CMake 3.7 rc2: # https://gitlab.kitware.com/cmake/cmake/issues/16363 if(CMAKE_VERSION VERSION_GREATER 3.6.99) - add_custom_command(TARGET liblldb POST_BUILD - COMMAND ${CMAKE_COMMAND} -E create_symlink ${LLDB_SOURCE_DIR}/include/lldb/API $/Headers) + add_custom_command(TARGET liblldb POST_BUILD ${symlink_commands}) else() add_custom_command(OUTPUT ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/${LLDB_FRAMEWORK_INSTALL_DIR}/LLDB.framework/Versions/${LLDB_FRAMEWORK_VERSION}/Headers - COMMAND ${CMAKE_COMMAND} -E create_symlink ${LLDB_SOURCE_DIR}/include/lldb/API $/Headers) + ${symlink_commands}) add_custom_target(lldb_header_symlink DEPENDS ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/${LLDB_FRAMEWORK_INSTALL_DIR}/LLDB.framework/Versions/${LLDB_FRAMEWORK_VERSION}/Headers) endif() diff --git a/lldb/test/CMakeLists.txt b/lldb/test/CMakeLists.txt index 142df66..4904404 100644 --- a/lldb/test/CMakeLists.txt +++ b/lldb/test/CMakeLists.txt @@ -27,6 +27,11 @@ if(TARGET lldb-mi) list(APPEND LLDB_TEST_DEPS lldb-mi) endif() +# This target will only exist if the user is using a CMake older than 3.7 +if(TARGET lldb_header_symlink) + list(APPEND LLDB_TEST_DEPS lldb_header_symlink) +endif() + if ("${LLDB_TEST_COMPILER}" STREQUAL "") string(REGEX REPLACE ".*ccache\ +" "" LLDB_TEST_COMPILER ${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}) endif() -- 2.7.4