From b9883beaba332d7e77969f31c98ceeb9f2c145cc Mon Sep 17 00:00:00 2001 From: "rafaelw@chromium.org" Date: Tue, 5 Nov 2013 15:33:14 +0000 Subject: [PATCH] Remove SetLocalPropertiesIgnoreAttributesTrampoline BUG=v8:2877 R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/59343003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17496 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/objects.cc | 23 ----------------------- src/objects.h | 9 --------- 2 files changed, 32 deletions(-) diff --git a/src/objects.cc b/src/objects.cc index fb7f1ba..2084abb 100644 --- a/src/objects.cc +++ b/src/objects.cc @@ -4122,29 +4122,6 @@ Handle JSObject::SetPropertyForResult(Handle object, } -MaybeObject* JSObject::SetLocalPropertyIgnoreAttributesTrampoline( - Name* key, - Object* value, - PropertyAttributes attributes, - ValueType value_type, - StoreMode mode, - ExtensibilityCheck extensibility_check) { - // TODO(mstarzinger): The trampoline is a giant hack, don't use it anywhere - // else or handlification people will start hating you for all eternity. - HandleScope scope(GetIsolate()); - IdempotentPointerToHandleCodeTrampoline trampoline(GetIsolate()); - return trampoline.CallWithReturnValue( - &JSObject::SetLocalPropertyIgnoreAttributes, - Handle(this), - Handle(key), - Handle(value, GetIsolate()), - attributes, - value_type, - mode, - extensibility_check); -} - - // Set a real local property, even if it is READ_ONLY. If the property is not // present, add it with attributes NONE. This code is an exact clone of // SetProperty, with the check for IsReadOnly and the check for a diff --git a/src/objects.h b/src/objects.h index a9316f2..7f8594a 100644 --- a/src/objects.h +++ b/src/objects.h @@ -2193,15 +2193,6 @@ class JSObject: public JSReceiver { // or returns an empty handle if such a map is not yet available. static Handle TryMigrateInstance(Handle instance); - // Can cause GC. - MUST_USE_RESULT MaybeObject* SetLocalPropertyIgnoreAttributesTrampoline( - Name* key, - Object* value, - PropertyAttributes attributes, - ValueType value_type = OPTIMAL_REPRESENTATION, - StoreMode mode = ALLOW_AS_CONSTANT, - ExtensibilityCheck extensibility_check = PERFORM_EXTENSIBILITY_CHECK); - // Retrieve a value in a normalized object given a lookup result. // Handles the special representation of JS global objects. Object* GetNormalizedProperty(LookupResult* result); -- 2.7.4