From b9860d3af83e905accb58829b4801813efbe3492 Mon Sep 17 00:00:00 2001 From: "sgjesse@chromium.org" Date: Tue, 2 Nov 2010 12:08:58 +0000 Subject: [PATCH] Remove all remaining code related to exposing C-frames to the JavaScript debugger BUG=906 Review URL: http://codereview.chromium.org/4104009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5754 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/debug-debugger.js | 32 -------------------------------- src/runtime.cc | 6 ------ src/runtime.h | 1 - 3 files changed, 39 deletions(-) diff --git a/src/debug-debugger.js b/src/debug-debugger.js index 0eab8d1..d091991 100644 --- a/src/debug-debugger.js +++ b/src/debug-debugger.js @@ -897,10 +897,6 @@ ExecutionState.prototype.frame = function(opt_index) { return new FrameMirror(this.break_id, opt_index); }; -ExecutionState.prototype.cframesValue = function(opt_from_index, opt_to_index) { - return %GetCFrames(this.break_id); -}; - ExecutionState.prototype.setSelectedFrame = function(index) { var i = %ToNumber(index); if (i < 0 || i >= this.frameCount()) throw new Error('Illegal frame index.'); @@ -1751,11 +1747,6 @@ DebugCommandProcessor.prototype.backtraceRequest_ = function(request, response) }; -DebugCommandProcessor.prototype.backtracec = function(cmd, args) { - return this.exec_state_.cframesValue(); -}; - - DebugCommandProcessor.prototype.frameRequest_ = function(request, response) { // No frames no source. if (this.exec_state_.frameCount() == 0) { @@ -2205,29 +2196,6 @@ function NumberToHex8Str(n) { return r; }; -DebugCommandProcessor.prototype.formatCFrames = function(cframes_value) { - var result = ""; - if (cframes_value == null || cframes_value.length == 0) { - result += "(stack empty)"; - } else { - for (var i = 0; i < cframes_value.length; ++i) { - if (i != 0) result += "\n"; - result += this.formatCFrame(cframes_value[i]); - } - } - return result; -}; - - -DebugCommandProcessor.prototype.formatCFrame = function(cframe_value) { - var result = ""; - result += "0x" + NumberToHex8Str(cframe_value.address); - if (!IS_UNDEFINED(cframe_value.text)) { - result += " " + cframe_value.text; - } - return result; -} - /** * Convert an Object to its debugger protocol representation. The representation diff --git a/src/runtime.cc b/src/runtime.cc index fc1a023..6392ef1 100644 --- a/src/runtime.cc +++ b/src/runtime.cc @@ -8891,12 +8891,6 @@ static MaybeObject* Runtime_DebugPrintScopes(Arguments args) { } -static MaybeObject* Runtime_GetCFrames(Arguments args) { - // See bug 906. - return Heap::undefined_value(); -} - - static MaybeObject* Runtime_GetThreadCount(Arguments args) { HandleScope scope; ASSERT(args.length() == 1); diff --git a/src/runtime.h b/src/runtime.h index 72a8037..2436ac8 100644 --- a/src/runtime.h +++ b/src/runtime.h @@ -325,7 +325,6 @@ namespace internal { F(GetScopeCount, 2, 1) \ F(GetScopeDetails, 3, 1) \ F(DebugPrintScopes, 0, 1) \ - F(GetCFrames, 1, 1) \ F(GetThreadCount, 1, 1) \ F(GetThreadDetails, 2, 1) \ F(SetDisableBreak, 1, 1) \ -- 2.7.4