From b985c8eadd20a7612e95060c4096311263d9acf7 Mon Sep 17 00:00:00 2001 From: Nicolas Dufresne Date: Fri, 25 Nov 2022 10:01:06 -0500 Subject: [PATCH] glimagesink: Fix render rect assertion Whenever the surface is resized before the stream is negotiated, we endup with an assertion in libgstvideo. gst_video_center_rect: assertion 'src->h != 0' failed This fixes it, by following the style aready in place, which is to ensure surfaces have a minimum size of 1x1. Fixes #1139 Part-of: --- subprojects/gst-plugins-base/ext/gl/gstglimagesink.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/subprojects/gst-plugins-base/ext/gl/gstglimagesink.c b/subprojects/gst-plugins-base/ext/gl/gstglimagesink.c index b6ee5de713..bf0ee8b14b 100644 --- a/subprojects/gst-plugins-base/ext/gl/gstglimagesink.c +++ b/subprojects/gst-plugins-base/ext/gl/gstglimagesink.c @@ -2298,6 +2298,10 @@ gst_glimage_sink_on_resize (GstGLImageSink * gl_sink, gint width, gint height) src.h = GST_VIDEO_SINK_HEIGHT (gl_sink); } + /* The stream may not be negotiated yet */ + src.w = MAX (1, src.w); + src.h = MAX (1, src.h); + dst.x = 0; dst.y = 0; dst.w = width; -- 2.34.1