From b95938117cb2bd9b020305a58bd748a48e58d30a Mon Sep 17 00:00:00 2001 From: Martin Fuzzey Date: Fri, 23 Nov 2018 10:53:06 +0100 Subject: [PATCH] w1: fix occasional enumeration failure Sometimes enumeration fails (about 1 in 50 times on my custom board). The underlying reason is probably electrical but Linux does not have the problem. Comparing the Linux / u-boot implementations shows that Linux retries the error case whereas u-boot aborts early. Removing the early abort in u-boot fixes the problem. Signed-off-by: Martin Fuzzey --- drivers/w1/w1-uclass.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/w1/w1-uclass.c b/drivers/w1/w1-uclass.c index cb41b68..042b3b5 100644 --- a/drivers/w1/w1-uclass.c +++ b/drivers/w1/w1-uclass.c @@ -84,10 +84,6 @@ static int w1_enumerate(struct udevice *bus) rn |= (tmp64 << i); } - /* last device or error, aborting here */ - if ((triplet_ret & 0x03) == 0x03) - last_device = true; - if ((triplet_ret & 0x03) != 0x03) { if (desc_bit == last_zero || last_zero < 0) { last_device = 1; -- 2.7.4