From b910f4317e9186e723784e05d8088bfdc32d69ce Mon Sep 17 00:00:00 2001 From: "yangguo@chromium.org" Date: Wed, 14 Sep 2011 11:27:14 +0000 Subject: [PATCH] Reverting r9272. Review URL: http://codereview.chromium.org/7889033 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9274 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/d8.cc | 14 ++++++-------- src/d8.h | 47 +++++++++++++++++++++++------------------------ 2 files changed, 29 insertions(+), 32 deletions(-) diff --git a/src/d8.cc b/src/d8.cc index 87fa50f..a025299 100644 --- a/src/d8.cc +++ b/src/d8.cc @@ -117,7 +117,6 @@ CounterCollection Shell::local_counters_; CounterCollection* Shell::counters_ = &local_counters_; i::Mutex* Shell::context_mutex_(i::OS::CreateMutex()); Persistent Shell::utility_context_; -LineEditor* Shell::console = NULL; #endif // V8_SHARED Persistent Shell::evaluation_context_; @@ -792,7 +791,6 @@ void Shell::Exit(int exit_code) { #ifndef V8_SHARED void Shell::OnExit() { - console->Close(); if (i::FLAG_dump_counters) { printf("+----------------------------------------+-------------+\n"); printf("| Name | Value |\n"); @@ -897,20 +895,20 @@ void Shell::RunShell() { HandleScope outer_scope; Handle name = String::New("(d8)"); #ifndef V8_SHARED - console = LineEditor::Get(); - printf("V8 version %s [console: %s]\n", V8::GetVersion(), console->name()); + LineEditor* editor = LineEditor::Get(); + printf("V8 version %s [console: %s]\n", V8::GetVersion(), editor->name()); if (i::FLAG_debugger) { printf("JavaScript debugger enabled\n"); } - console->Open(); + editor->Open(); while (true) { - i::SmartArrayPointer input = console->Prompt(Shell::kPrompt); + i::SmartArrayPointer input = editor->Prompt(Shell::kPrompt); if (input.is_empty()) break; - console->AddHistory(*input); + editor->AddHistory(*input); HandleScope inner_scope; ExecuteString(String::New(*input), name, true, true); } - console->Close(); + editor->Close(); #else printf("V8 version %s [D8 light using shared library]\n", V8::GetVersion()); static const int kBufferSize = 256; diff --git a/src/d8.h b/src/d8.h index 2d96d34..e193f10 100644 --- a/src/d8.h +++ b/src/d8.h @@ -116,29 +116,6 @@ class CounterMap { #endif // V8_SHARED -#ifndef V8_SHARED -class LineEditor { - public: - enum Type { DUMB = 0, READLINE = 1 }; - LineEditor(Type type, const char* name); - virtual ~LineEditor() { } - - virtual i::SmartArrayPointer Prompt(const char* prompt) = 0; - virtual bool Open() { return true; } - virtual bool Close() { return true; } - virtual void AddHistory(const char* str) { } - - const char* name() { return name_; } - static LineEditor* Get(); - private: - Type type_; - const char* name_; - LineEditor* next_; - static LineEditor* first_; -}; -#endif // V8_SHARED - - class SourceGroup { public: SourceGroup() : @@ -336,7 +313,6 @@ class Shell : public i::AllStatic { static void AddOSMethods(Handle os_template); #ifndef V8_SHARED static const char* kHistoryFileName; - static LineEditor* console; #endif // V8_SHARED static const char* kPrompt; static ShellOptions options; @@ -367,6 +343,29 @@ class Shell : public i::AllStatic { }; +#ifndef V8_SHARED +class LineEditor { + public: + enum Type { DUMB = 0, READLINE = 1 }; + LineEditor(Type type, const char* name); + virtual ~LineEditor() { } + + virtual i::SmartArrayPointer Prompt(const char* prompt) = 0; + virtual bool Open() { return true; } + virtual bool Close() { return true; } + virtual void AddHistory(const char* str) { } + + const char* name() { return name_; } + static LineEditor* Get(); + private: + Type type_; + const char* name_; + LineEditor* next_; + static LineEditor* first_; +}; +#endif // V8_SHARED + + } // namespace v8 -- 2.7.4