From b8cbe08fcce6f73c29151482c03ef2e2131712b5 Mon Sep 17 00:00:00 2001 From: "ricow@chromium.org" Date: Thu, 8 Sep 2011 19:57:14 +0000 Subject: [PATCH] Fix presubmit errors caused by updated depot tools This is all blank line before/after linting errors. Review URL: http://codereview.chromium.org/7754022 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9204 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- samples/process.cc | 2 -- src/accessors.cc | 1 + src/arguments.h | 1 + src/arm/lithium-gap-resolver-arm.h | 1 - src/arm/regexp-macro-assembler-arm.h | 1 + src/bignum.h | 1 + src/cached-powers.h | 1 - src/compilation-cache.h | 1 + src/d8-posix.cc | 1 + src/d8.h | 1 + src/dateparser.h | 4 +++- src/debug.h | 1 + src/frames.h | 1 + src/ia32/assembler-ia32.h | 3 +++ src/inspector.h | 2 -- src/jsregexp.h | 8 ++++++++ src/list.h | 1 - src/liveobjectlist.h | 3 --- src/log-utils.h | 1 - src/mips/assembler-mips.h | 1 + src/mips/regexp-macro-assembler-mips.h | 1 + src/objects.h | 2 -- src/platform-cygwin.cc | 1 - src/platform-freebsd.cc | 1 - src/platform-macos.cc | 1 - src/platform-solaris.cc | 1 - src/regexp-macro-assembler-irregexp.h | 1 + src/regexp-macro-assembler-tracer.h | 1 + src/regexp-stack.h | 1 + src/scanner.h | 2 +- src/scopeinfo.h | 2 +- src/spaces.h | 3 +-- src/splay-tree.h | 5 ++--- src/string-stream.h | 1 + src/utils.h | 1 + src/v8threads.h | 1 + src/x64/assembler-x64.h | 3 +++ test/cctest/cctest.h | 1 + test/cctest/test-debug.cc | 1 + test/cctest/test-lockers.cc | 4 ++++ test/cctest/test-threads.cc | 1 + 41 files changed, 46 insertions(+), 25 deletions(-) diff --git a/samples/process.cc b/samples/process.cc index 07c4805..c0cee4c 100644 --- a/samples/process.cc +++ b/samples/process.cc @@ -77,7 +77,6 @@ class HttpRequestProcessor { */ class JsHttpRequestProcessor : public HttpRequestProcessor { public: - // Creates a new processor that processes requests by invoking the // Process function of the JavaScript script given as an argument. explicit JsHttpRequestProcessor(Handle script) : script_(script) { } @@ -88,7 +87,6 @@ class JsHttpRequestProcessor : public HttpRequestProcessor { virtual bool Process(HttpRequest* req); private: - // Execute the script associated with this processor and extract the // Process function. Returns true if this succeeded, otherwise false. bool ExecuteScript(Handle script); diff --git a/src/accessors.cc b/src/accessors.cc index f02efa5..951209d 100644 --- a/src/accessors.cc +++ b/src/accessors.cc @@ -710,6 +710,7 @@ class FrameFunctionIterator { } while (next_function != NULL); return false; } + private: void GetFunctions() { functions_.Rewind(0); diff --git a/src/arguments.h b/src/arguments.h index 72bbe1d..e9a3270 100644 --- a/src/arguments.h +++ b/src/arguments.h @@ -75,6 +75,7 @@ class Arguments BASE_EMBEDDED { int length() const { return length_; } Object** arguments() { return arguments_; } + private: int length_; Object** arguments_; diff --git a/src/arm/lithium-gap-resolver-arm.h b/src/arm/lithium-gap-resolver-arm.h index 334d292..9dd09c8 100644 --- a/src/arm/lithium-gap-resolver-arm.h +++ b/src/arm/lithium-gap-resolver-arm.h @@ -40,7 +40,6 @@ class LGapResolver; class LGapResolver BASE_EMBEDDED { public: - explicit LGapResolver(LCodeGen* owner); // Resolve a set of parallel moves, emitting assembler instructions. diff --git a/src/arm/regexp-macro-assembler-arm.h b/src/arm/regexp-macro-assembler-arm.h index 0e65386..5c8ed06 100644 --- a/src/arm/regexp-macro-assembler-arm.h +++ b/src/arm/regexp-macro-assembler-arm.h @@ -116,6 +116,7 @@ class RegExpMacroAssemblerARM: public NativeRegExpMacroAssembler { static int CheckStackGuardState(Address* return_address, Code* re_code, Address re_frame); + private: // Offsets from frame_pointer() of function parameters and stored registers. static const int kFramePointer = 0; diff --git a/src/bignum.h b/src/bignum.h index 1d2bff6..dcc4fa7 100644 --- a/src/bignum.h +++ b/src/bignum.h @@ -92,6 +92,7 @@ class Bignum { static bool PlusLess(const Bignum& a, const Bignum& b, const Bignum& c) { return PlusCompare(a, b, c) < 0; } + private: typedef uint32_t Chunk; typedef uint64_t DoubleChunk; diff --git a/src/cached-powers.h b/src/cached-powers.h index 2ae5619..88df222 100644 --- a/src/cached-powers.h +++ b/src/cached-powers.h @@ -35,7 +35,6 @@ namespace internal { class PowersOfTenCache { public: - // Not all powers of ten are cached. The decimal exponent of two neighboring // cached numbers will differ by kDecimalExponentDistance. static const int kDecimalExponentDistance; diff --git a/src/compilation-cache.h b/src/compilation-cache.h index 1fcf753..4339d22 100644 --- a/src/compilation-cache.h +++ b/src/compilation-cache.h @@ -242,6 +242,7 @@ class CompilationCache { // cache during debugging to make sure new scripts are always compiled. void Enable(); void Disable(); + private: explicit CompilationCache(Isolate* isolate); ~CompilationCache(); diff --git a/src/d8-posix.cc b/src/d8-posix.cc index 658fd4f..289c3b0 100644 --- a/src/d8-posix.cc +++ b/src/d8-posix.cc @@ -231,6 +231,7 @@ class ExecArgs { static const unsigned kMaxArgs = 1000; char** arg_array() { return exec_args_; } char* arg0() { return exec_args_[0]; } + private: char* exec_args_[kMaxArgs + 1]; }; diff --git a/src/d8.h b/src/d8.h index 3ec0390..756e0ce 100644 --- a/src/d8.h +++ b/src/d8.h @@ -208,6 +208,7 @@ class Shell { #else class Shell : public i::AllStatic { #endif // V8_SHARED + public: static bool ExecuteString(Handle source, Handle name, diff --git a/src/dateparser.h b/src/dateparser.h index 4777e35..27584ce 100644 --- a/src/dateparser.h +++ b/src/dateparser.h @@ -36,7 +36,6 @@ namespace internal { class DateParser : public AllStatic { public: - // Parse the string as a date. If parsing succeeds, return true after // filling out the output array as follows (all integers are Smis): // [0]: year @@ -234,6 +233,7 @@ class DateParser : public AllStatic { static DateToken Invalid() { return DateToken(kInvalidTokenTag, 0, -1); } + private: enum TagType { kInvalidTokenTag = -6, @@ -275,6 +275,7 @@ class DateParser : public AllStatic { } return false; } + private: DateToken Scan(); @@ -351,6 +352,7 @@ class DateParser : public AllStatic { static bool IsMinute(int x) { return Between(x, 0, 59); } static bool IsHour(int x) { return Between(x, 0, 23); } static bool IsSecond(int x) { return Between(x, 0, 59); } + private: static bool IsHour12(int x) { return Between(x, 0, 12); } static bool IsMillisecond(int x) { return Between(x, 0, 999); } diff --git a/src/debug.h b/src/debug.h index c614844..d39ea4e 100644 --- a/src/debug.h +++ b/src/debug.h @@ -1026,6 +1026,7 @@ class Debug_Address { return NULL; } } + private: Debug::AddressId id_; }; diff --git a/src/frames.h b/src/frames.h index 4f94ebc..fed11c4 100644 --- a/src/frames.h +++ b/src/frames.h @@ -579,6 +579,7 @@ class ArgumentsAdaptorFrame: public JavaScriptFrame { virtual void Print(StringStream* accumulator, PrintMode mode, int index) const; + protected: explicit ArgumentsAdaptorFrame(StackFrameIterator* iterator) : JavaScriptFrame(iterator) { } diff --git a/src/ia32/assembler-ia32.h b/src/ia32/assembler-ia32.h index c186094..4698e3e 100644 --- a/src/ia32/assembler-ia32.h +++ b/src/ia32/assembler-ia32.h @@ -465,6 +465,7 @@ class CpuFeatures : public AllStatic { // Enable a specified feature within a scope. class Scope BASE_EMBEDDED { #ifdef DEBUG + public: explicit Scope(CpuFeature f) { uint64_t mask = static_cast(1) << f; @@ -484,10 +485,12 @@ class CpuFeatures : public AllStatic { isolate_->set_enabled_cpu_features(old_enabled_); } } + private: Isolate* isolate_; uint64_t old_enabled_; #else + public: explicit Scope(CpuFeature f) {} #endif diff --git a/src/inspector.h b/src/inspector.h index f8b3042..e328bcd 100644 --- a/src/inspector.h +++ b/src/inspector.h @@ -41,7 +41,6 @@ namespace internal { class Inspector { public: - static void DumpObjectType(FILE* out, Object *obj, bool print_more); static void DumpObjectType(FILE* out, Object *obj) { DumpObjectType(out, obj, false); @@ -59,4 +58,3 @@ class Inspector { #endif // INSPECTOR #endif // V8_INSPECTOR_H_ - diff --git a/src/jsregexp.h b/src/jsregexp.h index 3bd5e00..54297a4 100644 --- a/src/jsregexp.h +++ b/src/jsregexp.h @@ -255,6 +255,7 @@ class SetRelation BASE_EMBEDDED { return (bits_ == (kInFirst | kInSecond | kInBoth)); } int value() { return bits_; } + private: int bits_; }; @@ -404,6 +405,7 @@ class DispatchTable : public ZoneObject { template void ForEach(Callback* callback) { return tree()->ForEach(callback); } + private: // There can't be a static empty set since it allocates its // successors in a zone and caches them. @@ -793,6 +795,7 @@ class ActionNode: public SeqRegExpNode { virtual int GreedyLoopTextLength() { return kNodeIsTooComplexForGreedyLoops; } virtual ActionNode* Clone() { return new ActionNode(*this); } virtual int ComputeFirstCharacterSet(int budget); + private: union { struct { @@ -861,6 +864,7 @@ class TextNode: public SeqRegExpNode { } void CalculateOffsets(); virtual int ComputeFirstCharacterSet(int budget); + private: enum TextEmitPassType { NON_ASCII_MATCH, // Check for characters that can't match. @@ -925,6 +929,7 @@ class AssertionNode: public SeqRegExpNode { virtual AssertionNode* Clone() { return new AssertionNode(*this); } AssertionNodeType type() { return type_; } void set_type(AssertionNodeType type) { type_ = type; } + private: AssertionNode(AssertionNodeType t, RegExpNode* on_success) : SeqRegExpNode(on_success), type_(t) { } @@ -955,6 +960,7 @@ class BackReferenceNode: public SeqRegExpNode { } virtual BackReferenceNode* Clone() { return new BackReferenceNode(*this); } virtual int ComputeFirstCharacterSet(int budget); + private: int start_reg_; int end_reg_; @@ -1301,6 +1307,7 @@ class Trace { } void InvalidateCurrentCharacter(); void AdvanceCurrentPositionInTrace(int by, RegExpCompiler* compiler); + private: int FindAffectedRegisters(OutSet* affected_registers); void PerformDeferredActions(RegExpMacroAssembler* macro, @@ -1402,6 +1409,7 @@ FOR_EACH_NODE_TYPE(DECLARE_VISIT) void fail(const char* error_message) { error_message_ = error_message; } + private: bool ignore_case_; bool is_ascii_; diff --git a/src/list.h b/src/list.h index ca2b7bc..33267bd 100644 --- a/src/list.h +++ b/src/list.h @@ -49,7 +49,6 @@ namespace internal { template class List { public: - List() { Initialize(0); } INLINE(explicit List(int capacity)) { Initialize(capacity); } INLINE(~List()) { DeleteData(data_); } diff --git a/src/liveobjectlist.h b/src/liveobjectlist.h index 542482d..65470d7 100644 --- a/src/liveobjectlist.h +++ b/src/liveobjectlist.h @@ -114,7 +114,6 @@ class LiveObjectList { static Object* PrintObj(int obj_id); private: - struct Element { int id_; HeapObject* obj_; @@ -224,7 +223,6 @@ class LiveObjectList { // Helper class for updating the LiveObjectList HeapObject pointers. class UpdateLiveObjectListVisitor: public ObjectVisitor { public: - void VisitPointer(Object** p) { UpdatePointer(p); } void VisitPointers(Object** start, Object** end) { @@ -319,4 +317,3 @@ class LiveObjectList { } } // namespace v8::internal #endif // V8_LIVEOBJECTLIST_H_ - diff --git a/src/log-utils.h b/src/log-utils.h index 2b20a01..d0cb828 100644 --- a/src/log-utils.h +++ b/src/log-utils.h @@ -141,7 +141,6 @@ class LogMessageBuilder BASE_EMBEDDED { void WriteToLogFile(); private: - Log* log_; ScopedLock sl; int pos_; diff --git a/src/mips/assembler-mips.h b/src/mips/assembler-mips.h index e5077be..2c0633f 100644 --- a/src/mips/assembler-mips.h +++ b/src/mips/assembler-mips.h @@ -1159,6 +1159,7 @@ class Assembler : public AssemblerBase { } return trampoline_slot; } + private: int start_; int end_; diff --git a/src/mips/regexp-macro-assembler-mips.h b/src/mips/regexp-macro-assembler-mips.h index 7fe0c88..d42d4cf 100644 --- a/src/mips/regexp-macro-assembler-mips.h +++ b/src/mips/regexp-macro-assembler-mips.h @@ -118,6 +118,7 @@ class RegExpMacroAssemblerMIPS: public NativeRegExpMacroAssembler { static int CheckStackGuardState(Address* return_address, Code* re_code, Address re_frame); + private: // Offsets from frame_pointer() of function parameters and stored registers. static const int kFramePointer = 0; diff --git a/src/objects.h b/src/objects.h index 53ba981..486303d 100644 --- a/src/objects.h +++ b/src/objects.h @@ -3154,7 +3154,6 @@ class ByteArray: public FixedArrayBase { // raised rather than being silently ignored. class ExternalArray: public FixedArrayBase { public: - inline bool is_the_hole(int index) { return false; } // [external_pointer]: The pointer to the external memory area backing this @@ -6409,7 +6408,6 @@ class ConsString: public String { // - truncating sliced string to enable otherwise unneeded parent to be GC'ed. class SlicedString: public String { public: - inline String* parent(); inline void set_parent(String* parent); inline int offset(); diff --git a/src/platform-cygwin.cc b/src/platform-cygwin.cc index 85a5e4f..a72f5da 100644 --- a/src/platform-cygwin.cc +++ b/src/platform-cygwin.cc @@ -474,7 +474,6 @@ void Thread::YieldCPU() { class CygwinMutex : public Mutex { public: - CygwinMutex() { pthread_mutexattr_t attrs; memset(&attrs, 0, sizeof(attrs)); diff --git a/src/platform-freebsd.cc b/src/platform-freebsd.cc index 9d9f1b7..685ec3c 100644 --- a/src/platform-freebsd.cc +++ b/src/platform-freebsd.cc @@ -471,7 +471,6 @@ void Thread::YieldCPU() { class FreeBSDMutex : public Mutex { public: - FreeBSDMutex() { pthread_mutexattr_t attrs; int result = pthread_mutexattr_init(&attrs); diff --git a/src/platform-macos.cc b/src/platform-macos.cc index be6e157..6be941a 100644 --- a/src/platform-macos.cc +++ b/src/platform-macos.cc @@ -558,7 +558,6 @@ void Thread::YieldCPU() { class MacOSMutex : public Mutex { public: - MacOSMutex() { pthread_mutexattr_t attr; pthread_mutexattr_init(&attr); diff --git a/src/platform-solaris.cc b/src/platform-solaris.cc index 1e79f10..035d394 100644 --- a/src/platform-solaris.cc +++ b/src/platform-solaris.cc @@ -460,7 +460,6 @@ void Thread::YieldCPU() { class SolarisMutex : public Mutex { public: - SolarisMutex() { pthread_mutexattr_t attr; pthread_mutexattr_init(&attr); diff --git a/src/regexp-macro-assembler-irregexp.h b/src/regexp-macro-assembler-irregexp.h index 75cf8bf..262ead2 100644 --- a/src/regexp-macro-assembler-irregexp.h +++ b/src/regexp-macro-assembler-irregexp.h @@ -107,6 +107,7 @@ class RegExpMacroAssemblerIrregexp: public RegExpMacroAssembler { virtual IrregexpImplementation Implementation(); virtual Handle GetCode(Handle source); + private: void Expand(); // Code and bitmap emission. diff --git a/src/regexp-macro-assembler-tracer.h b/src/regexp-macro-assembler-tracer.h index 8c6cf3a..1cf0349 100644 --- a/src/regexp-macro-assembler-tracer.h +++ b/src/regexp-macro-assembler-tracer.h @@ -95,6 +95,7 @@ class RegExpMacroAssemblerTracer: public RegExpMacroAssembler { virtual void WriteCurrentPositionToRegister(int reg, int cp_offset); virtual void ClearRegisters(int reg_from, int reg_to); virtual void WriteStackPointerToRegister(int reg); + private: RegExpMacroAssembler* assembler_; }; diff --git a/src/regexp-stack.h b/src/regexp-stack.h index 5943206..5684239 100644 --- a/src/regexp-stack.h +++ b/src/regexp-stack.h @@ -89,6 +89,7 @@ class RegExpStack { char* ArchiveStack(char* to); char* RestoreStack(char* from); void FreeThreadResources() { thread_local_.Free(); } + private: RegExpStack(); ~RegExpStack(); diff --git a/src/scanner.h b/src/scanner.h index 73a4e21..16c3a42 100644 --- a/src/scanner.h +++ b/src/scanner.h @@ -135,7 +135,6 @@ class UnicodeCache { bool IsWhiteSpace(unibrow::uchar c) { return kIsWhiteSpace.get(c); } private: - unibrow::Predicate kIsIdentifierStart; unibrow::Predicate kIsIdentifierPart; unibrow::Predicate kIsLineTerminator; @@ -198,6 +197,7 @@ class LiteralBuffer { position_ = 0; is_ascii_ = true; } + private: static const int kInitialCapacity = 16; static const int kGrowthFactory = 4; diff --git a/src/scopeinfo.h b/src/scopeinfo.h index 1c61f11..40c5c8a 100644 --- a/src/scopeinfo.h +++ b/src/scopeinfo.h @@ -156,7 +156,6 @@ class SerializedScopeInfo : public FixedArray { static SerializedScopeInfo* Empty(); private: - inline Object** ContextEntriesAddr(); inline Object** ParameterEntriesAddr(); @@ -187,6 +186,7 @@ class ContextSlotCache { void Clear(); static const int kNotFound = -2; + private: ContextSlotCache() { for (int i = 0; i < kLength; ++i) { diff --git a/src/spaces.h b/src/spaces.h index 908cd30..f156496 100644 --- a/src/spaces.h +++ b/src/spaces.h @@ -1232,8 +1232,8 @@ class PagedSpace : public Space { // Returns the number of total pages in this space. int CountTotalPages(); #endif - private: + private: // Returns a pointer to the page of the relocation pointer. Page* MCRelocationTopPage() { return TopPageOf(mc_forwarding_info_); } @@ -1816,7 +1816,6 @@ class FixedSizeFreeList BASE_EMBEDDED { void MarkNodes(); private: - Heap* heap_; // Available bytes on the free list. diff --git a/src/splay-tree.h b/src/splay-tree.h index 0cb9ea8..72231e4 100644 --- a/src/splay-tree.h +++ b/src/splay-tree.h @@ -123,8 +123,8 @@ class SplayTree { Value value() { return value_; } Node* left() { return left_; } Node* right() { return right_; } - private: + private: friend class SplayTree; friend class Locator; Key key_; @@ -143,6 +143,7 @@ class SplayTree { Value& value() { return node_->value_; } void set_value(const Value& value) { node_->value_ = value; } inline void bind(Node* node) { node_ = node; } + private: Node* node_; }; @@ -151,7 +152,6 @@ class SplayTree { void ForEach(Callback* callback); protected: - // Resets tree root. Existing nodes become unreachable. void ResetRoot() { root_ = NULL; } @@ -187,7 +187,6 @@ class SplayTree { void Call(Node* node) { delete node; } private: - DISALLOW_COPY_AND_ASSIGN(NodeDeleter); }; diff --git a/src/string-stream.h b/src/string-stream.h index b3f2e0d..9e5083e 100644 --- a/src/string-stream.h +++ b/src/string-stream.h @@ -93,6 +93,7 @@ class FmtElm { FmtElm(void* value) : type_(POINTER) { // NOLINT data_.u_pointer_ = value; } + private: friend class StringStream; enum Type { INT, DOUBLE, C_STR, LC_STR, OBJ, HANDLE, POINTER }; diff --git a/src/utils.h b/src/utils.h index 5a875d8..edbace0 100644 --- a/src/utils.h +++ b/src/utils.h @@ -890,6 +890,7 @@ class SimpleStringBuilder { int position_; bool is_finalized() const { return position_ < 0; } + private: DISALLOW_IMPLICIT_CONSTRUCTORS(SimpleStringBuilder); }; diff --git a/src/v8threads.h b/src/v8threads.h index 3ba823a..4002bb3 100644 --- a/src/v8threads.h +++ b/src/v8threads.h @@ -54,6 +54,7 @@ class ThreadState { // Get data area for archiving a thread. char* data() { return data_; } + private: explicit ThreadState(ThreadManager* thread_manager); diff --git a/src/x64/assembler-x64.h b/src/x64/assembler-x64.h index c23eb16..2e373fa 100644 --- a/src/x64/assembler-x64.h +++ b/src/x64/assembler-x64.h @@ -453,6 +453,7 @@ class CpuFeatures : public AllStatic { // Enable a specified feature within a scope. class Scope BASE_EMBEDDED { #ifdef DEBUG + public: explicit Scope(CpuFeature f) { uint64_t mask = V8_UINT64_C(1) << f; @@ -472,10 +473,12 @@ class CpuFeatures : public AllStatic { isolate_->set_enabled_cpu_features(old_enabled_); } } + private: Isolate* isolate_; uint64_t old_enabled_; #else + public: explicit Scope(CpuFeature f) {} #endif diff --git a/test/cctest/cctest.h b/test/cctest/cctest.h index b0b8eb7..c04d893 100644 --- a/test/cctest/cctest.h +++ b/test/cctest/cctest.h @@ -110,6 +110,7 @@ class ApiTestFuzzer: public v8::internal::Thread { // This method switches threads if we are running the Threading test. // Otherwise it does nothing. static void Fuzz(); + private: static bool fuzzing_; static int tests_being_run_; diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc index b7962de..ee63453 100644 --- a/test/cctest/test-debug.cc +++ b/test/cctest/test-debug.cc @@ -157,6 +157,7 @@ class DebugLocalContext { Handle(debug->debug_context()->global_proxy()), DONT_ENUM, ::v8::internal::kNonStrictMode); } + private: v8::Persistent context_; }; diff --git a/test/cctest/test-lockers.cc b/test/cctest/test-lockers.cc index d61fde2..7360da5 100644 --- a/test/cctest/test-lockers.cc +++ b/test/cctest/test-lockers.cc @@ -142,6 +142,7 @@ class JoinableThread { } virtual void Run() = 0; + private: class ThreadWithSemaphore : public i::Thread { public: @@ -377,6 +378,7 @@ class LockerUnlockerThread : public JoinableThread { CalcFibAndCheck(); } } + private: v8::Isolate* isolate_; }; @@ -429,6 +431,7 @@ class LockTwiceAndUnlockThread : public JoinableThread { CalcFibAndCheck(); } } + private: v8::Isolate* isolate_; }; @@ -498,6 +501,7 @@ class LockAndUnlockDifferentIsolatesThread : public JoinableThread { thread.Join(); } } + private: v8::Isolate* isolate1_; v8::Isolate* isolate2_; diff --git a/test/cctest/test-threads.cc b/test/cctest/test-threads.cc index 59d27ab..985b9e5 100644 --- a/test/cctest/test-threads.cc +++ b/test/cctest/test-threads.cc @@ -161,6 +161,7 @@ class ThreadIdValidationThread : public v8::internal::Thread { } semaphore_->Signal(); } + private: i::List* refs_; int thread_no_; -- 2.7.4