From b85a0b1bfd4bbe9a6f65403c161e21794955f5b4 Mon Sep 17 00:00:00 2001 From: "Eunki, Hong" Date: Fri, 3 Jun 2022 21:30:57 +0900 Subject: [PATCH] Minor optimize during iterate of uniform map Dali::Vector.End() operation is heavy. We don't need to calculate this value every iteration. So just precalculate the end-of-iterate. It will increase performance. Change-Id: I475d01367348943f0f4b12a6aeb870c413db0dfc Signed-off-by: Eunki, Hong --- dali/internal/update/common/uniform-map.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dali/internal/update/common/uniform-map.cpp b/dali/internal/update/common/uniform-map.cpp index 2caba5e..76e6081 100644 --- a/dali/internal/update/common/uniform-map.cpp +++ b/dali/internal/update/common/uniform-map.cpp @@ -28,7 +28,7 @@ namespace SceneGraph void UniformMap::AddObserver(Observer& observer) { bool foundObserver = false; - for(ObserversIter iter = mObservers.Begin(); iter != mObservers.End(); ++iter) + for(ObserversIter iter = mObservers.Begin(), endIter = mObservers.End(); iter != endIter; ++iter) { if(*iter == &observer) { @@ -44,7 +44,7 @@ void UniformMap::AddObserver(Observer& observer) void UniformMap::RemoveObserver(Observer& observer) { - for(ObserversIter iter = mObservers.Begin(); iter != mObservers.End(); ++iter) + for(ObserversIter iter = mObservers.Begin(), endIter = mObservers.End(); iter != endIter; ++iter) { if(*iter == &observer) { @@ -57,7 +57,7 @@ void UniformMap::RemoveObserver(Observer& observer) void UniformMap::MappingChanged() { ++mChangeCounter; - for(ObserversIter iter = mObservers.Begin(); iter != mObservers.End(); ++iter) + for(ObserversIter iter = mObservers.Begin(), endIter = mObservers.End(); iter != endIter; ++iter) { Observer* observer = (*iter); observer->UniformMappingsChanged(*this); -- 2.7.4