From b7fab0736dfc4349cc665f15c2640f6f353a5bc9 Mon Sep 17 00:00:00 2001
From: Luis de Bethencourt <luis.bg@samsung.com>
Date: Mon, 12 Jan 2015 15:33:09 +0000
Subject: [PATCH] visual: use unused value

ret is assigned but not used and in the next cycle of the loop it is overwritten
with default_prepare_output_buffer (). If there is a flow error the function
should return instead.

CID #1226475
---
 gst/audiovisualizers/gstaudiovisualizer.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gst/audiovisualizers/gstaudiovisualizer.c b/gst/audiovisualizers/gstaudiovisualizer.c
index 458819c..954db14 100644
--- a/gst/audiovisualizers/gstaudiovisualizer.c
+++ b/gst/audiovisualizers/gstaudiovisualizer.c
@@ -1179,6 +1179,8 @@ gst_audio_visualizer_chain (GstPad * pad, GstObject * parent,
     if (klass->render) {
       if (!klass->render (scope, inbuf, &outframe)) {
         ret = GST_FLOW_ERROR;
+        gst_video_frame_unmap (&outframe);
+        goto beach;
       } else {
         /* run various post processing (shading and geometric transformation) */
         /* FIXME: SHADER assumes 32bpp */
-- 
2.7.4