From b765d3cdb90a121520e220f29d6a2b4902a2efcb Mon Sep 17 00:00:00 2001 From: "jarin@chromium.org" Date: Mon, 24 Mar 2014 21:32:19 +0000 Subject: [PATCH] Revert the (wrong) fix of the argument index check asserion. R=ishell@chromium.org BUG= Review URL: https://codereview.chromium.org/208423017 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20219 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/x64/lithium-codegen-x64.cc | 11 +++-------- test/mjsunit/regress/regress-355486.js | 13 ------------- 2 files changed, 3 insertions(+), 21 deletions(-) delete mode 100644 test/mjsunit/regress/regress-355486.js diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc index 401a49e..a6be271 100644 --- a/src/x64/lithium-codegen-x64.cc +++ b/src/x64/lithium-codegen-x64.cc @@ -2910,14 +2910,9 @@ void LCodeGen::DoAccessArgumentsAt(LAccessArgumentsAt* instr) { instr->index()->IsConstantOperand()) { int32_t const_index = ToInteger32(LConstantOperand::cast(instr->index())); int32_t const_length = ToInteger32(LConstantOperand::cast(instr->length())); - if (const_index < const_length) { - StackArgumentsAccessor args(arguments, const_length, - ARGUMENTS_DONT_CONTAIN_RECEIVER); - __ movp(result, args.GetArgumentOperand(const_index)); - } else { - // This code should never be executed; just stop here. - __ int3(); - } + StackArgumentsAccessor args(arguments, const_length, + ARGUMENTS_DONT_CONTAIN_RECEIVER); + __ movp(result, args.GetArgumentOperand(const_index)); } else { Register length = ToRegister(instr->length()); // There are two words between the frame pointer and the last argument. diff --git a/test/mjsunit/regress/regress-355486.js b/test/mjsunit/regress/regress-355486.js deleted file mode 100644 index 55362a1..0000000 --- a/test/mjsunit/regress/regress-355486.js +++ /dev/null @@ -1,13 +0,0 @@ -// Copyright 2014 the V8 project authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -// Flags: --allow-natives-syntax - -function f() { var v = arguments[0]; } -function g() { f(); } - -g(); -g(); -%OptimizeFunctionOnNextCall(g); -g(); -- 2.7.4