From b6e8192a85cce603066294a78ea57dbb00336da8 Mon Sep 17 00:00:00 2001 From: Stephane Sezer Date: Thu, 20 Nov 2014 18:50:46 +0000 Subject: [PATCH] Properly specify a few checksum values for llgs tests. Summary: In noack mode, these checksums are ignored by llgs, but some implementations need them still. Specify these checksums to ease integration. Test Plan: Run the tests before and after the change and make sure nothing breaks. Reviewers: clayborg, tfiala Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D6343 llvm-svn: 222441 --- lldb/test/tools/lldb-gdbserver/TestLldbGdbServer.py | 8 ++++---- lldb/test/tools/lldb-gdbserver/gdbremote_testcase.py | 2 +- .../tools/lldb-gdbserver/inferior-crash/TestGdbRemoteAbort.py | 2 +- .../tools/lldb-gdbserver/inferior-crash/TestGdbRemoteSegFault.py | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lldb/test/tools/lldb-gdbserver/TestLldbGdbServer.py b/lldb/test/tools/lldb-gdbserver/TestLldbGdbServer.py index 6a3c56c..94ada4f 100644 --- a/lldb/test/tools/lldb-gdbserver/TestLldbGdbServer.py +++ b/lldb/test/tools/lldb-gdbserver/TestLldbGdbServer.py @@ -127,7 +127,7 @@ class LldbGdbServerTestCase(gdbremote_testcase.GdbRemoteTestCaseBase): self.add_no_ack_remote_stream() self.add_verified_launch_packets(launch_args) self.test_sequence.add_log_lines( - ["read packet: $vCont;c#00", + ["read packet: $vCont;c#a8", "send packet: $W00#00"], True) @@ -159,7 +159,7 @@ class LldbGdbServerTestCase(gdbremote_testcase.GdbRemoteTestCaseBase): self.add_no_ack_remote_stream() self.add_verified_launch_packets(launch_args) self.test_sequence.add_log_lines( - ["read packet: $vCont;c#00", + ["read packet: $vCont;c#a8", "send packet: $W{0:02x}#00".format(RETVAL)], True) @@ -219,7 +219,7 @@ class LldbGdbServerTestCase(gdbremote_testcase.GdbRemoteTestCaseBase): self.add_no_ack_remote_stream() self.add_verified_launch_packets(launch_args) self.test_sequence.add_log_lines( - ["read packet: $vCont;c#00", + ["read packet: $vCont;c#a8", {"type":"output_match", "regex":r"^hello, world\r\n$" }, "send packet: $W00#00"], True) @@ -275,7 +275,7 @@ class LldbGdbServerTestCase(gdbremote_testcase.GdbRemoteTestCaseBase): def attach_commandline_continue_app_exits(self): procs = self.prep_debug_monitor_and_inferior() self.test_sequence.add_log_lines( - ["read packet: $vCont;c#00", + ["read packet: $vCont;c#a8", "send packet: $W00#00"], True) self.expect_gdbremote_sequence() diff --git a/lldb/test/tools/lldb-gdbserver/gdbremote_testcase.py b/lldb/test/tools/lldb-gdbserver/gdbremote_testcase.py index 5430890..fdd133c 100644 --- a/lldb/test/tools/lldb-gdbserver/gdbremote_testcase.py +++ b/lldb/test/tools/lldb-gdbserver/gdbremote_testcase.py @@ -689,7 +689,7 @@ class GdbRemoteTestCaseBase(TestBase): def run_process_then_stop(self, run_seconds=1): # Tell the stub to continue. self.test_sequence.add_log_lines( - ["read packet: $vCont;c#00"], + ["read packet: $vCont;c#a8"], True) context = self.expect_gdbremote_sequence() diff --git a/lldb/test/tools/lldb-gdbserver/inferior-crash/TestGdbRemoteAbort.py b/lldb/test/tools/lldb-gdbserver/inferior-crash/TestGdbRemoteAbort.py index 1d1f73f..16ca370 100644 --- a/lldb/test/tools/lldb-gdbserver/inferior-crash/TestGdbRemoteAbort.py +++ b/lldb/test/tools/lldb-gdbserver/inferior-crash/TestGdbRemoteAbort.py @@ -18,7 +18,7 @@ class TestGdbRemoteAbort(gdbremote_testcase.GdbRemoteTestCaseBase): self.assertIsNotNone(procs) self.test_sequence.add_log_lines([ - "read packet: $vCont;c#00", + "read packet: $vCont;c#a8", {"direction":"send", "regex":r"^\$T([0-9a-fA-F]{2}).*#[0-9a-fA-F]{2}$", "capture":{ 1:"hex_exit_code"} }, ], True) diff --git a/lldb/test/tools/lldb-gdbserver/inferior-crash/TestGdbRemoteSegFault.py b/lldb/test/tools/lldb-gdbserver/inferior-crash/TestGdbRemoteSegFault.py index 21489f9..c7494bd 100644 --- a/lldb/test/tools/lldb-gdbserver/inferior-crash/TestGdbRemoteSegFault.py +++ b/lldb/test/tools/lldb-gdbserver/inferior-crash/TestGdbRemoteSegFault.py @@ -20,7 +20,7 @@ class TestGdbRemoteSegFault(gdbremote_testcase.GdbRemoteTestCaseBase): self.assertIsNotNone(procs) self.test_sequence.add_log_lines([ - "read packet: $vCont;c#00", + "read packet: $vCont;c#a8", {"direction":"send", "regex":r"^\$T([0-9a-fA-F]{2}).*#[0-9a-fA-F]{2}$", "capture":{ 1:"hex_exit_code"} }, ], True) -- 2.7.4