From b697da432aada697f2485734827b7bed5dbf2599 Mon Sep 17 00:00:00 2001 From: Terry Koo Date: Tue, 20 Mar 2018 13:39:42 -0700 Subject: [PATCH] Makes protobuf dep in tf.contrib.data conditional using if_static(). In non-monolithic builds, adding it unconditionally would duplicate of protobuf symbols among tf.contrib op libraries. Guarding it with if_static() restricts the dep to monolithic builds, which should be able to dedupe the symbols at link time. PiperOrigin-RevId: 189800612 --- tensorflow/contrib/data/BUILD | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/tensorflow/contrib/data/BUILD b/tensorflow/contrib/data/BUILD index 5ba2297..d787ed8 100644 --- a/tensorflow/contrib/data/BUILD +++ b/tensorflow/contrib/data/BUILD @@ -9,6 +9,10 @@ load( "tf_custom_op_library", "tf_gen_op_libs", ) +load( + "//tensorflow/core:platform/default/build_config_root.bzl", + "if_static", +) py_library( name = "data", @@ -29,10 +33,11 @@ py_library( tf_custom_op_library( name = "_dataset_ops.so", srcs = ["ops/dataset_ops.cc"], - deps = [ - "//tensorflow/contrib/data/kernels:dataset_kernels", - "//tensorflow/core:lib_proto_parsing", - ], + deps = ["//tensorflow/contrib/data/kernels:dataset_kernels"] + + if_static( + extra_deps = ["//tensorflow/core:lib_proto_parsing"], + otherwise = [], + ), ) tf_gen_op_libs( -- 2.7.4