From b57f2f6108fbf9ce33191fb574fe94b1f3ccbff3 Mon Sep 17 00:00:00 2001 From: Philip Rakity Date: Fri, 2 Sep 2011 04:20:01 +0200 Subject: [PATCH] max8925_power: Do not read random data from chip registers Reading the voltage, charge etc requires that we tell the chip what property we want to read before reading it according to maxim. Signed-off-by: Philip Rakity Signed-off-by: Thomas Liu Tested-by: Ted Bennett Signed-off-by: Anton Vorontsov --- drivers/power/max8925_power.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/power/max8925_power.c b/drivers/power/max8925_power.c index 377d1e6..d87032a 100644 --- a/drivers/power/max8925_power.c +++ b/drivers/power/max8925_power.c @@ -160,25 +160,31 @@ static irqreturn_t max8925_charger_handler(int irq, void *data) static int start_measure(struct max8925_power_info *info, int type) { unsigned char buf[2] = {0, 0}; + int meas_cmd; int meas_reg = 0, ret; switch (type) { case MEASURE_VCHG: + meas_cmd = MAX8925_CMD_VCHG; meas_reg = MAX8925_ADC_VCHG; break; case MEASURE_VBBATT: + meas_cmd = MAX8925_CMD_VBBATT; meas_reg = MAX8925_ADC_VBBATT; break; case MEASURE_VMBATT: + meas_cmd = MAX8925_CMD_VMBATT; meas_reg = MAX8925_ADC_VMBATT; break; case MEASURE_ISNS: + meas_cmd = MAX8925_CMD_ISNS; meas_reg = MAX8925_ADC_ISNS; break; default: return -EINVAL; } + max8925_reg_write(info->adc, meas_cmd, 0); max8925_bulk_read(info->adc, meas_reg, 2, buf); ret = ((buf[0]<<8) | buf[1]) >> 4; -- 2.7.4