From b57e264257f3402c1dee3fbfe9df250952e86070 Mon Sep 17 00:00:00 2001 From: Gabor Horvath Date: Wed, 9 Aug 2017 12:34:58 +0000 Subject: [PATCH] [Sema] -Wenum-compare no longer warn on anonymous enums in switch statements Patch by: Reka Nikolett Kovacs llvm-svn: 310468 --- clang/lib/Sema/SemaStmt.cpp | 6 ++++++ clang/test/SemaCXX/warn-enum-compare.cpp | 7 +++++++ 2 files changed, 13 insertions(+) diff --git a/clang/lib/Sema/SemaStmt.cpp b/clang/lib/Sema/SemaStmt.cpp index 6bdc71b..1b6aed6 100644 --- a/clang/lib/Sema/SemaStmt.cpp +++ b/clang/lib/Sema/SemaStmt.cpp @@ -753,6 +753,12 @@ static void checkEnumTypesInSwitchStmt(Sema &S, const Expr *Cond, if (!CondEnumType || !CaseEnumType) return; + // Ignore anonymous enums. + if (!CondEnumType->getDecl()->getIdentifier()) + return; + if (!CaseEnumType->getDecl()->getIdentifier()) + return; + if (S.Context.hasSameUnqualifiedType(CondType, CaseType)) return; diff --git a/clang/test/SemaCXX/warn-enum-compare.cpp b/clang/test/SemaCXX/warn-enum-compare.cpp index d1f6beb..f82f775 100644 --- a/clang/test/SemaCXX/warn-enum-compare.cpp +++ b/clang/test/SemaCXX/warn-enum-compare.cpp @@ -226,4 +226,11 @@ void test () { case BarF: break; case FooA: break; // expected-warning {{comparison of two values with different enumeration types ('Bar' and 'Foo')}} } + + switch(x) { + case AnonAA: break; // expected-warning {{case value not in enumerated type 'Foo'}} + case FooA: break; + case FooB: break; + case FooC: break; + } } -- 2.7.4