From b4ed936d5261126655ea19d07e21712dec99f06f Mon Sep 17 00:00:00 2001 From: seoz Date: Wed, 15 Feb 2012 12:24:15 +0000 Subject: [PATCH] elm cursor: Reviewed elm_cursor APIs. But the review was not finished yet. git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/elementary@67981 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33 --- src/bin/test_cursor.c | 2 ++ src/lib/Elementary.h.in | 2 +- src/lib/elm_cursor.h | 13 +++++++++---- 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/src/bin/test_cursor.c b/src/bin/test_cursor.c index 077ef2f..68d9ec8 100644 --- a/src/bin/test_cursor.c +++ b/src/bin/test_cursor.c @@ -5,6 +5,8 @@ #endif #ifndef ELM_LIB_QUICKLAUNCH +// XXX: show all type of cursors in the elementary_test. this needs to be the first test + typedef struct _Testitem { Elm_Object_Item *item; diff --git a/src/lib/Elementary.h.in b/src/lib/Elementary.h.in index 10af1f1..bb9b0e0 100644 --- a/src/lib/Elementary.h.in +++ b/src/lib/Elementary.h.in @@ -188,7 +188,7 @@ EAPI extern Elm_Version *elm_version; #include #include #include -#include +#include // comments in elm_cursor.h. review was not finished. #include // OK #include diff --git a/src/lib/elm_cursor.h b/src/lib/elm_cursor.h index 3d1f39d..1df760e 100644 --- a/src/lib/elm_cursor.h +++ b/src/lib/elm_cursor.h @@ -9,8 +9,9 @@ * and Elementary provides functions to choose them (think of X11 * cursors, as an example). * + * By default, Elementary searches cursors only from engine. * There's also the possibility of, besides using engine provided - * cursors, also use ones coming from Edje theming files. Both + * cursors, also use ones coming from Edje theme files. Both * globally and per widget, Elementary makes it possible for one to * make the cursors lookup to be held on engines only or on * Elementary's theme file, too. To set cursor's hot spot, @@ -90,16 +91,17 @@ EAPI const char *elm_object_cursor_style_get(const Evas_Object *obj); * Set if the cursor set should be searched on the theme or should use * the provided by the engine, only. * - * @note before you set if should look on theme you should define a cursor - * with elm_object_cursor_set(). By default it will only look for cursors + * @note before you set engine_only you should define a cursor with + * elm_object_cursor_set(). By default it will only look for cursors * provided by the engine. * * @param obj an object with cursor already set. - * @param engine_only boolean to define it cursors should be looked only + * @param engine_only boolean to define if cursors should be looked only * between the provided by the engine or searched on widget's theme as well. * * @ingroup Cursors */ +// XXX: EAPI void elm_object_cursor_theme_search_enabled_set(Evas_Object *obj, Eina_Bool theme_search) or xxx_search_theme_xxx EAPI void elm_object_cursor_engine_only_set(Evas_Object *obj, Eina_Bool engine_only); /** @@ -113,6 +115,7 @@ EAPI void elm_object_cursor_engine_only_set(Evas_Object *obj, Eina_Bool e * * @ingroup Cursors */ +// XXX: EAPI Eina_Bool elm_object_cursor_theme_search_enabled_get(const Evas_Object *obj) or xxx_search_theme_xxx EAPI Eina_Bool elm_object_cursor_engine_only_get(const Evas_Object *obj); /** @@ -123,6 +126,7 @@ EAPI Eina_Bool elm_object_cursor_engine_only_get(const Evas_Object *obj); * @return 1 if only engine cursors should be used * @ingroup Cursors */ +// XXX: need to review EAPI int elm_cursor_engine_only_get(void); /** @@ -136,6 +140,7 @@ EAPI int elm_cursor_engine_only_get(void); * @return EINA_TRUE if value is valid and set (0 or 1) * @ingroup Cursors */ +// XXX: need to review EAPI Eina_Bool elm_cursor_engine_only_set(int engine_only); /** -- 2.7.4