From b4a35fe7e592c6341db420c8ab4b17b7161f3363 Mon Sep 17 00:00:00 2001 From: "yangguo@chromium.org" Date: Wed, 20 Aug 2014 09:43:00 +0000 Subject: [PATCH] Remove RegExp.$input. R=arv@chromium.org, mathiasb@opera.com BUG=v8:3486 LOG=Y Review URL: https://codereview.chromium.org/465273002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23223 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/regexp.js | 2 -- test/mjsunit/string-match.js | 1 - test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt | 2 +- 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/regexp.js b/src/regexp.js index d7883fb..1a2a4f0 100644 --- a/src/regexp.js +++ b/src/regexp.js @@ -410,8 +410,6 @@ function SetUpRegExp() { RegExpSetInput, DONT_DELETE); %DefineAccessorPropertyUnchecked($RegExp, '$_', RegExpGetInput, RegExpSetInput, DONT_ENUM | DONT_DELETE); - %DefineAccessorPropertyUnchecked($RegExp, '$input', RegExpGetInput, - RegExpSetInput, DONT_ENUM | DONT_DELETE); // The properties multiline and $* are aliases for each other. When this // value is set in SpiderMonkey, the value it is set to is coerced to a diff --git a/test/mjsunit/string-match.js b/test/mjsunit/string-match.js index 202396d..7689652 100644 --- a/test/mjsunit/string-match.js +++ b/test/mjsunit/string-match.js @@ -66,7 +66,6 @@ function testMatch(name, input, regexp, result, captures, from, to) { assertEquals(undefined, RegExp.$10, name + "-nocapture-10"); assertEquals(input, RegExp.input, name + "-input"); - assertEquals(input, RegExp.$input, name + "-$input"); assertEquals(input, RegExp.$_, name + "-$_"); assertEquals(preMatch, RegExp["$`"], name + "-$`"); diff --git a/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt b/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt index 4b8eb14..4fe6742 100644 --- a/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt +++ b/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt @@ -77,7 +77,7 @@ PASS getSortedOwnPropertyNames(Number) is ['EPSILON', 'MAX_SAFE_INTEGER', 'MAX_V PASS getSortedOwnPropertyNames(Number.prototype) is ['constructor', 'toExponential', 'toFixed', 'toLocaleString', 'toPrecision', 'toString', 'valueOf'] PASS getSortedOwnPropertyNames(Date) is ['UTC', 'arguments', 'caller', 'length', 'name', 'now', 'parse', 'prototype'] PASS getSortedOwnPropertyNames(Date.prototype) is ['constructor', 'getDate', 'getDay', 'getFullYear', 'getHours', 'getMilliseconds', 'getMinutes', 'getMonth', 'getSeconds', 'getTime', 'getTimezoneOffset', 'getUTCDate', 'getUTCDay', 'getUTCFullYear', 'getUTCHours', 'getUTCMilliseconds', 'getUTCMinutes', 'getUTCMonth', 'getUTCSeconds', 'getYear', 'setDate', 'setFullYear', 'setHours', 'setMilliseconds', 'setMinutes', 'setMonth', 'setSeconds', 'setTime', 'setUTCDate', 'setUTCFullYear', 'setUTCHours', 'setUTCMilliseconds', 'setUTCMinutes', 'setUTCMonth', 'setUTCSeconds', 'setYear', 'toDateString', 'toGMTString', 'toISOString', 'toJSON', 'toLocaleDateString', 'toLocaleString', 'toLocaleTimeString', 'toString', 'toTimeString', 'toUTCString', 'valueOf'] -FAIL getSortedOwnPropertyNames(RegExp) should be $&,$',$*,$+,$1,$2,$3,$4,$5,$6,$7,$8,$9,$_,$`,arguments,caller,input,lastMatch,lastParen,leftContext,length,multiline,name,prototype,rightContext. Was $&,$',$*,$+,$1,$2,$3,$4,$5,$6,$7,$8,$9,$_,$`,$input,arguments,caller,input,lastMatch,lastParen,leftContext,length,multiline,name,prototype,rightContext. +PASS getSortedOwnPropertyNames(RegExp) is ['$&', "$'", '$*', '$+', '$1', '$2', '$3', '$4', '$5', '$6', '$7', '$8', '$9', '$_', '$`', 'arguments', 'caller', 'input', 'lastMatch', 'lastParen', 'leftContext', 'length', 'multiline', 'name', 'prototype', 'rightContext'] PASS getSortedOwnPropertyNames(RegExp.prototype) is ['compile', 'constructor', 'exec', 'global', 'ignoreCase', 'lastIndex', 'multiline', 'source', 'test', 'toString'] PASS getSortedOwnPropertyNames(Error) is ['arguments', 'caller', 'captureStackTrace', 'length', 'name', 'prototype', 'stackTraceLimit'] PASS getSortedOwnPropertyNames(Error.prototype) is ['constructor', 'message', 'name', 'toString'] -- 2.7.4