From b4855619d1c8aa65c0a81df96012709d771f4051 Mon Sep 17 00:00:00 2001 From: Jane Xu Date: Fri, 10 Sep 2021 15:17:07 -0700 Subject: [PATCH] Always upload stats to S3 (#64853) Summary: It's not very useful when stats are only uploaded when the tests all pass. Like for this failing run, the stats were not uploaded to Scribe or S3: https://github.com/pytorch/pytorch/runs/3568714658 Pull Request resolved: https://github.com/pytorch/pytorch/pull/64853 Reviewed By: seemethere Differential Revision: D30878361 Pulled By: janeyx99 fbshipit-source-id: 19a4c520efdd5575785a3ffbc60e6c09456b9e0d --- .github/templates/common.yml.j2 | 1 + .github/workflows/generated-linux-bionic-cuda10.2-py3.9-gcc7.yml | 1 + .github/workflows/generated-linux-bionic-py3.6-clang9.yml | 1 + .github/workflows/generated-linux-bionic-py3.8-gcc9-coverage.yml | 1 + .github/workflows/generated-linux-xenial-cuda10.2-py3.6-gcc7.yml | 1 + .github/workflows/generated-linux-xenial-cuda11.3-py3.6-gcc7.yml | 1 + .github/workflows/generated-linux-xenial-py3.6-gcc5.4.yml | 1 + .github/workflows/generated-linux-xenial-py3.6-gcc7-bazel-test.yml | 1 + .github/workflows/generated-parallelnative-linux-xenial-py3.6-gcc5.4.yml | 1 + .github/workflows/generated-paralleltbb-linux-xenial-py3.6-gcc5.4.yml | 1 + .../workflows/generated-periodic-linux-xenial-cuda11.1-py3.6-gcc7.yml | 1 + .github/workflows/generated-periodic-win-vs2019-cuda11.1-py3.yml | 1 + .github/workflows/generated-win-vs2019-cpu-py3.yml | 1 + .github/workflows/generated-win-vs2019-cuda10.2-py3.yml | 1 + .github/workflows/generated-win-vs2019-cuda11.3-py3.yml | 1 + 15 files changed, 15 insertions(+) diff --git a/.github/templates/common.yml.j2 b/.github/templates/common.yml.j2 index aff0137..503ea9a 100644 --- a/.github/templates/common.yml.j2 +++ b/.github/templates/common.yml.j2 @@ -35,6 +35,7 @@ concurrency: {%- macro upload_test_statistics(build_environment) -%} - name: Display and upload test statistics (Click Me) + if: always() # temporary hack: set CIRCLE_* vars, until we update # tools/stats/print_test_stats.py to natively support GitHub Actions env: diff --git a/.github/workflows/generated-linux-bionic-cuda10.2-py3.9-gcc7.yml b/.github/workflows/generated-linux-bionic-cuda10.2-py3.9-gcc7.yml index b409bc1..057c6b0 100644 --- a/.github/workflows/generated-linux-bionic-cuda10.2-py3.9-gcc7.yml +++ b/.github/workflows/generated-linux-bionic-cuda10.2-py3.9-gcc7.yml @@ -482,6 +482,7 @@ jobs: id: parse-ref run: .github/scripts/parse_ref.py - name: Display and upload test statistics (Click Me) + if: always() # temporary hack: set CIRCLE_* vars, until we update # tools/stats/print_test_stats.py to natively support GitHub Actions env: diff --git a/.github/workflows/generated-linux-bionic-py3.6-clang9.yml b/.github/workflows/generated-linux-bionic-py3.6-clang9.yml index adbd6cb..e4f1480 100644 --- a/.github/workflows/generated-linux-bionic-py3.6-clang9.yml +++ b/.github/workflows/generated-linux-bionic-py3.6-clang9.yml @@ -482,6 +482,7 @@ jobs: id: parse-ref run: .github/scripts/parse_ref.py - name: Display and upload test statistics (Click Me) + if: always() # temporary hack: set CIRCLE_* vars, until we update # tools/stats/print_test_stats.py to natively support GitHub Actions env: diff --git a/.github/workflows/generated-linux-bionic-py3.8-gcc9-coverage.yml b/.github/workflows/generated-linux-bionic-py3.8-gcc9-coverage.yml index 3abc455..21a5e02 100644 --- a/.github/workflows/generated-linux-bionic-py3.8-gcc9-coverage.yml +++ b/.github/workflows/generated-linux-bionic-py3.8-gcc9-coverage.yml @@ -486,6 +486,7 @@ jobs: id: parse-ref run: .github/scripts/parse_ref.py - name: Display and upload test statistics (Click Me) + if: always() # temporary hack: set CIRCLE_* vars, until we update # tools/stats/print_test_stats.py to natively support GitHub Actions env: diff --git a/.github/workflows/generated-linux-xenial-cuda10.2-py3.6-gcc7.yml b/.github/workflows/generated-linux-xenial-cuda10.2-py3.6-gcc7.yml index 7e3b495..331f388 100644 --- a/.github/workflows/generated-linux-xenial-cuda10.2-py3.6-gcc7.yml +++ b/.github/workflows/generated-linux-xenial-cuda10.2-py3.6-gcc7.yml @@ -482,6 +482,7 @@ jobs: id: parse-ref run: .github/scripts/parse_ref.py - name: Display and upload test statistics (Click Me) + if: always() # temporary hack: set CIRCLE_* vars, until we update # tools/stats/print_test_stats.py to natively support GitHub Actions env: diff --git a/.github/workflows/generated-linux-xenial-cuda11.3-py3.6-gcc7.yml b/.github/workflows/generated-linux-xenial-cuda11.3-py3.6-gcc7.yml index fc7651f..861c61e 100644 --- a/.github/workflows/generated-linux-xenial-cuda11.3-py3.6-gcc7.yml +++ b/.github/workflows/generated-linux-xenial-cuda11.3-py3.6-gcc7.yml @@ -482,6 +482,7 @@ jobs: id: parse-ref run: .github/scripts/parse_ref.py - name: Display and upload test statistics (Click Me) + if: always() # temporary hack: set CIRCLE_* vars, until we update # tools/stats/print_test_stats.py to natively support GitHub Actions env: diff --git a/.github/workflows/generated-linux-xenial-py3.6-gcc5.4.yml b/.github/workflows/generated-linux-xenial-py3.6-gcc5.4.yml index ffac23d..95ca25b 100644 --- a/.github/workflows/generated-linux-xenial-py3.6-gcc5.4.yml +++ b/.github/workflows/generated-linux-xenial-py3.6-gcc5.4.yml @@ -482,6 +482,7 @@ jobs: id: parse-ref run: .github/scripts/parse_ref.py - name: Display and upload test statistics (Click Me) + if: always() # temporary hack: set CIRCLE_* vars, until we update # tools/stats/print_test_stats.py to natively support GitHub Actions env: diff --git a/.github/workflows/generated-linux-xenial-py3.6-gcc7-bazel-test.yml b/.github/workflows/generated-linux-xenial-py3.6-gcc7-bazel-test.yml index a36e9aa..594e55d 100644 --- a/.github/workflows/generated-linux-xenial-py3.6-gcc7-bazel-test.yml +++ b/.github/workflows/generated-linux-xenial-py3.6-gcc7-bazel-test.yml @@ -309,6 +309,7 @@ jobs: path: test-reports-*.zip - name: Display and upload test statistics (Click Me) + if: always() # temporary hack: set CIRCLE_* vars, until we update # tools/stats/print_test_stats.py to natively support GitHub Actions env: diff --git a/.github/workflows/generated-parallelnative-linux-xenial-py3.6-gcc5.4.yml b/.github/workflows/generated-parallelnative-linux-xenial-py3.6-gcc5.4.yml index ecca773..dd8e722 100644 --- a/.github/workflows/generated-parallelnative-linux-xenial-py3.6-gcc5.4.yml +++ b/.github/workflows/generated-parallelnative-linux-xenial-py3.6-gcc5.4.yml @@ -482,6 +482,7 @@ jobs: id: parse-ref run: .github/scripts/parse_ref.py - name: Display and upload test statistics (Click Me) + if: always() # temporary hack: set CIRCLE_* vars, until we update # tools/stats/print_test_stats.py to natively support GitHub Actions env: diff --git a/.github/workflows/generated-paralleltbb-linux-xenial-py3.6-gcc5.4.yml b/.github/workflows/generated-paralleltbb-linux-xenial-py3.6-gcc5.4.yml index 73415ef..4bfb787 100644 --- a/.github/workflows/generated-paralleltbb-linux-xenial-py3.6-gcc5.4.yml +++ b/.github/workflows/generated-paralleltbb-linux-xenial-py3.6-gcc5.4.yml @@ -482,6 +482,7 @@ jobs: id: parse-ref run: .github/scripts/parse_ref.py - name: Display and upload test statistics (Click Me) + if: always() # temporary hack: set CIRCLE_* vars, until we update # tools/stats/print_test_stats.py to natively support GitHub Actions env: diff --git a/.github/workflows/generated-periodic-linux-xenial-cuda11.1-py3.6-gcc7.yml b/.github/workflows/generated-periodic-linux-xenial-cuda11.1-py3.6-gcc7.yml index d6f40c2..b1f93c5 100644 --- a/.github/workflows/generated-periodic-linux-xenial-cuda11.1-py3.6-gcc7.yml +++ b/.github/workflows/generated-periodic-linux-xenial-cuda11.1-py3.6-gcc7.yml @@ -480,6 +480,7 @@ jobs: id: parse-ref run: .github/scripts/parse_ref.py - name: Display and upload test statistics (Click Me) + if: always() # temporary hack: set CIRCLE_* vars, until we update # tools/stats/print_test_stats.py to natively support GitHub Actions env: diff --git a/.github/workflows/generated-periodic-win-vs2019-cuda11.1-py3.yml b/.github/workflows/generated-periodic-win-vs2019-cuda11.1-py3.yml index 94b3ec3..c071bc4 100644 --- a/.github/workflows/generated-periodic-win-vs2019-cuda11.1-py3.yml +++ b/.github/workflows/generated-periodic-win-vs2019-cuda11.1-py3.yml @@ -272,6 +272,7 @@ jobs: id: parse-ref run: .github/scripts/parse_ref.py - name: Display and upload test statistics (Click Me) + if: always() # temporary hack: set CIRCLE_* vars, until we update # tools/stats/print_test_stats.py to natively support GitHub Actions env: diff --git a/.github/workflows/generated-win-vs2019-cpu-py3.yml b/.github/workflows/generated-win-vs2019-cpu-py3.yml index 3c1e7a1..d0eb3fd 100644 --- a/.github/workflows/generated-win-vs2019-cpu-py3.yml +++ b/.github/workflows/generated-win-vs2019-cpu-py3.yml @@ -256,6 +256,7 @@ jobs: id: parse-ref run: .github/scripts/parse_ref.py - name: Display and upload test statistics (Click Me) + if: always() # temporary hack: set CIRCLE_* vars, until we update # tools/stats/print_test_stats.py to natively support GitHub Actions env: diff --git a/.github/workflows/generated-win-vs2019-cuda10.2-py3.yml b/.github/workflows/generated-win-vs2019-cuda10.2-py3.yml index 00b1ad9..c6c752f 100644 --- a/.github/workflows/generated-win-vs2019-cuda10.2-py3.yml +++ b/.github/workflows/generated-win-vs2019-cuda10.2-py3.yml @@ -274,6 +274,7 @@ jobs: id: parse-ref run: .github/scripts/parse_ref.py - name: Display and upload test statistics (Click Me) + if: always() # temporary hack: set CIRCLE_* vars, until we update # tools/stats/print_test_stats.py to natively support GitHub Actions env: diff --git a/.github/workflows/generated-win-vs2019-cuda11.3-py3.yml b/.github/workflows/generated-win-vs2019-cuda11.3-py3.yml index 064b369..67a4a2a 100644 --- a/.github/workflows/generated-win-vs2019-cuda11.3-py3.yml +++ b/.github/workflows/generated-win-vs2019-cuda11.3-py3.yml @@ -274,6 +274,7 @@ jobs: id: parse-ref run: .github/scripts/parse_ref.py - name: Display and upload test statistics (Click Me) + if: always() # temporary hack: set CIRCLE_* vars, until we update # tools/stats/print_test_stats.py to natively support GitHub Actions env: -- 2.7.4