From b45864d40ca6f453a708d1e74c2108424ac15bdb Mon Sep 17 00:00:00 2001 From: Viresh Kumar Date: Fri, 24 Jul 2015 15:32:21 +0530 Subject: [PATCH] greybus: svc: remove interface->svc pointer Its not updated/used anymore, remove it. Also move back the struct gb_svc to svc.c as its not referenced by external users anymore. Signed-off-by: Viresh Kumar Tested-by: Perry Hung Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/interface.h | 1 - drivers/staging/greybus/svc.c | 6 ++++++ drivers/staging/greybus/svc.h | 7 +------ 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/greybus/interface.h b/drivers/staging/greybus/interface.h index 9a9260c4..fc2d29f 100644 --- a/drivers/staging/greybus/interface.h +++ b/drivers/staging/greybus/interface.h @@ -14,7 +14,6 @@ struct gb_interface { struct device dev; struct gb_control *control; - struct gb_svc *svc; struct list_head bundles; struct list_head links; /* greybus_host_device->interfaces */ diff --git a/drivers/staging/greybus/svc.c b/drivers/staging/greybus/svc.c index 969c389..5f2b2b4 100644 --- a/drivers/staging/greybus/svc.c +++ b/drivers/staging/greybus/svc.c @@ -9,6 +9,12 @@ #include "greybus.h" +struct gb_svc { + struct gb_connection *connection; + u8 version_major; + u8 version_minor; +}; + static struct ida greybus_svc_device_id_map; /* diff --git a/drivers/staging/greybus/svc.h b/drivers/staging/greybus/svc.h index 6649780..ee39479 100644 --- a/drivers/staging/greybus/svc.h +++ b/drivers/staging/greybus/svc.h @@ -10,12 +10,7 @@ #ifndef __SVC_H #define __SVC_H -struct gb_svc { - struct gb_connection *connection; - u8 version_major; - u8 version_minor; -}; - +struct gb_svc; int gb_svc_intf_device_id(struct gb_svc *svc, u8 intf_id, u8 device_id); int gb_svc_intf_reset(struct gb_svc *svc, u8 intf_id); -- 2.7.4