From b453b6eacea2f6d859ca1e693d10156b715fdf10 Mon Sep 17 00:00:00 2001 From: Stephen Toub Date: Thu, 7 Jun 2018 13:24:11 -0400 Subject: [PATCH] Remove dead case from string.Compare (dotnet/coreclr#18345) Commit migrated from https://github.com/dotnet/coreclr/commit/33910ce097e4812d17edad61c88c9c348ed80fa8 --- .../System.Private.CoreLib/src/System/String.Comparison.cs | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/libraries/System.Private.CoreLib/src/System/String.Comparison.cs b/src/libraries/System.Private.CoreLib/src/System/String.Comparison.cs index 99efcbe..3ddc90a 100644 --- a/src/libraries/System.Private.CoreLib/src/System/String.Comparison.cs +++ b/src/libraries/System.Private.CoreLib/src/System/String.Comparison.cs @@ -415,11 +415,9 @@ namespace System case StringComparison.Ordinal: return CompareOrdinalHelper(strA, indexA, lengthA, strB, indexB, lengthB); - case StringComparison.OrdinalIgnoreCase: - return CompareInfo.CompareOrdinalIgnoreCase(strA, indexA, lengthA, strB, indexB, lengthB); - default: - throw new ArgumentException(SR.NotSupported_StringComparison, nameof(comparisonType)); + Debug.Assert(comparisonType == StringComparison.OrdinalIgnoreCase); // CheckStringComparison validated these earlier + return CompareInfo.CompareOrdinalIgnoreCase(strA, indexA, lengthA, strB, indexB, lengthB); } } -- 2.7.4