From b446bc8ef0d91b34212edf659253be5c51437a0a Mon Sep 17 00:00:00 2001 From: "Eunki, Hong" Date: Tue, 7 Nov 2023 21:58:10 +0900 Subject: [PATCH] [NUI.XamlBuild] Remove unused event : Element.DescendantAdded / Removed Those API was useless if we don't need to invoke those events. And those try to climb-up to parent root every Add / Remove API. It will spend heavy time if the scene tree is complex. Those event handerl are internal, and nobody use them. So just remove codes. Signed-off-by: Eunki, Hong --- .../src/internal/XamlBinding/Element.cs | 18 ++++++++++-------- src/Tizen.NUI/src/public/XamlBinding/Element.cs | 18 ++++++++++-------- 2 files changed, 20 insertions(+), 16 deletions(-) diff --git a/src/Tizen.NUI.XamlBuild/src/internal/XamlBinding/Element.cs b/src/Tizen.NUI.XamlBuild/src/internal/XamlBinding/Element.cs index 8eb2d08..be186b6 100755 --- a/src/Tizen.NUI.XamlBuild/src/internal/XamlBinding/Element.cs +++ b/src/Tizen.NUI.XamlBuild/src/internal/XamlBinding/Element.cs @@ -471,11 +471,12 @@ namespace Tizen.NUI.Binding child.ApplyBindings(skipBindingContext: false, fromBindingContextChanged:true); - ChildAdded?.Invoke(this, new ElementEventArgs(child)); + // 2023-11-08 : Just ignore Tizen.NUI don't using logics. + // ChildAdded?.Invoke(this, new ElementEventArgs(child)); - OnDescendantAdded(child); - foreach (Element element in child.Descendants()) - OnDescendantAdded(element); + // OnDescendantAdded(child); + // foreach (Element element in child.Descendants()) + // OnDescendantAdded(element); } /// @@ -488,11 +489,12 @@ namespace Tizen.NUI.Binding { child.Parent = null; - ChildRemoved?.Invoke(child, new ElementEventArgs(child)); + // 2023-11-08 : Just ignore Tizen.NUI don't using logics. + // ChildRemoved?.Invoke(child, new ElementEventArgs(child)); - OnDescendantRemoved(child); - foreach (Element element in child.Descendants()) - OnDescendantRemoved(element); + // OnDescendantRemoved(child); + // foreach (Element element in child.Descendants()) + // OnDescendantRemoved(element); } /// diff --git a/src/Tizen.NUI/src/public/XamlBinding/Element.cs b/src/Tizen.NUI/src/public/XamlBinding/Element.cs index b206d4f..13a3d2d 100755 --- a/src/Tizen.NUI/src/public/XamlBinding/Element.cs +++ b/src/Tizen.NUI/src/public/XamlBinding/Element.cs @@ -372,11 +372,12 @@ namespace Tizen.NUI.Binding child.ApplyBindings(skipBindingContext: false, fromBindingContextChanged: true); - ChildAdded?.Invoke(this, new ElementEventArgs(child)); + // 2023-11-08 : Just ignore Tizen.NUI don't using logics. + // ChildAdded?.Invoke(this, new ElementEventArgs(child)); - OnDescendantAdded(child); - foreach (Element element in child.Descendants()) - OnDescendantAdded(element); + // OnDescendantAdded(child); + // foreach (Element element in child.Descendants()) + // OnDescendantAdded(element); } /// @@ -395,11 +396,12 @@ namespace Tizen.NUI.Binding child.Parent = null; - ChildRemoved?.Invoke(child, new ElementEventArgs(child)); + // 2023-11-08 : Just ignore Tizen.NUI don't using logics. + // ChildRemoved?.Invoke(child, new ElementEventArgs(child)); - OnDescendantRemoved(child); - foreach (Element element in child.Descendants()) - OnDescendantRemoved(element); + // OnDescendantRemoved(child); + // foreach (Element element in child.Descendants()) + // OnDescendantRemoved(element); } /// -- 2.7.4